HIVE-27120: Warn when Authorizer V2 is configured - #4349
Conversation
aturoczy
left a comment
There was a problem hiding this comment.
This change is sound legit to me. BUT I guess it has some historical part why it is started with _
The change itself OK.
@ayushtkn @deniskuzZ @abstractdog @zabetak @nrg4878 Do you have a historical knowledge about this config?
(The description are pretty well described)
|
Kudos, SonarCloud Quality Gate passed! |
zabetak
left a comment
There was a problem hiding this comment.
LGTM. I checked the git history and I don't see an obvious reason of why "hive.internal" prefix was chosen. Choosing "_hive" to be inline with other "internal" params in this class makes sense.
ayushtkn
left a comment
There was a problem hiding this comment.
LGTM, couldn't find the reason why someone did like that, but it seems safe to me
|
Thanks. My environment will be a bit more silent thanks to your reviews! |
…min, reviewed by Stamatis Zampetakis, Ayush Saxena, Attila Turoczy)
…min, reviewed by Stamatis Zampetakis, Ayush Saxena, Attila Turoczy)








What changes were proposed in this pull request?
This PR will change an internal param name defined in SessionState.
Why are the changes needed?
The param causes WARN unless we disable
hive.conf.validation.That's because it is not listed in HiveConf even though it starts with
hive..https://github.com/apache/hive/blob/rel/release-4.0.0-alpha-2/common/src/java/org/apache/hadoop/hive/conf/HiveConf.java#L6429-L6440
So, this PR will change the prefix from
hive.internal.into_hive.. This manner is inherited from some other private params.https://github.com/apache/hive/blob/rel/release-4.0.0-alpha-2/ql/src/java/org/apache/hadoop/hive/ql/session/SessionState.java#L130-L132
Other options I considered.
hive.internal.ss.authz.settings.applied.markerin HiveConfhive.internal.ss.authz.settings.applied.markerto the allowlisthive.internal.Does this PR introduce any user-facing change?
I assume we can say NO. Precisely, it might change a behavior when a user explicity configures
hive.internal.ss.authz.settings.applied.marker. However, I assume this param must not be configured by users.How was this patch tested?
I have confirmed I don't see the WARN log with this change on my local environment.