HIVE-27575: MASK_HASH UDF generate a log per row - #4558
Conversation
| if (SessionState.get() != null) { | ||
| return "sha512".equalsIgnoreCase( | ||
| isSha512 = "sha512".equalsIgnoreCase( | ||
| HiveConf.getVar(SessionState.get().getConf(), HiveConf.ConfVars.HIVE_MASKING_ALGO).trim()); |
There was a problem hiding this comment.
I observed this is also invoked every row when it runs on HiveServer2 with fetch task conversion
ayushtkn
left a comment
ayushtkn
left a comment
There was a problem hiding this comment.
can we just remove the log line or change it to debug? On a quick look it seems we are doing more than just removing the log line here?
|
Kudos, SonarCloud Quality Gate passed!
|
|
Thanks. I decided to address only the logging part. I wonder if it could be not the best to access Configuration every row. But I postpone checking or improving that part until I am sure that we should fix it. |
…in, reviewed by Ayush Saxena)
3 participants
What changes were proposed in this pull request?
Avoid too many logs from being written.
https://issues.apache.org/jira/browse/HIVE-27575
Why are the changes needed?
Prevent disk-full or overhead.
Does this PR introduce any user-facing change?
No
Is the change a dependency upgrade?
No
How was this patch tested?
I checked the log is written only once.