Skip to content

HIVE-27950: STACK UDTF returns wrong results when # of argument is no… - #4938

Merged
SourabhBadhya merged 2 commits into
apache:masterfrom
okumin:HIVE-27950-stack
Feb 20, 2024
Merged

HIVE-27950: STACK UDTF returns wrong results when # of argument is no…#4938
SourabhBadhya merged 2 commits into
apache:masterfrom
okumin:HIVE-27950-stack

Conversation

@okumin

@okumin okumin commented Dec 12, 2023

Copy link
Copy Markdown
Contributor

…t a multiple of N

https://issues.apache.org/jira/browse/HIVE-27950

What changes were proposed in this pull request?

Fix a data integrity problem of the stack UDF.

Why are the changes needed?

This is a bug fix

Does this PR introduce any user-facing change?

Yes. This PR would prevent users from facing the issue and would change error messages a bit

Is the change a dependency upgrade?

No

How was this patch tested?

I added test cases

@okumin okumin changed the title HIVE-27950: STACK UDTF returns wrong results when # of argument is no… [WIP] HIVE-27950: STACK UDTF returns wrong results when # of argument is no… Dec 12, 2023
okumin
okumin commented Dec 12, 2023
View reviewed changes
Comment thread ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDTFStack.java
@sonarqubecloud

sonarqubecloud Bot commented Dec 12, 2023

Copy link
Copy Markdown

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@okumin okumin changed the title [WIP] HIVE-27950: STACK UDTF returns wrong results when # of argument is no… HIVE-27950: STACK UDTF returns wrong results when # of argument is no… Dec 13, 2023
@okumin
okumin marked this pull request as ready for review December 13, 2023 06:11
aturoczy
aturoczy reviewed Dec 13, 2023
View reviewed changes
Comment thread ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDTFStack.java
Comment thread ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDTFStack.java
@InvisibleProgrammer

InvisibleProgrammer commented Dec 15, 2023

Copy link
Copy Markdown
Contributor

LGTM

@github-actions

github-actions Bot commented Feb 14, 2024

Copy link
Copy Markdown

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.
Feel free to reach out on the dev@hive.apache.org list if the patch is in need of reviews.

@github-actions github-actions Bot added the stale label Feb 14, 2024
@okumin

okumin commented Feb 14, 2024

Copy link
Copy Markdown
Contributor Author

@aturoczy @InvisibleProgrammer Do you know anyone who can get this PR approved? Thanks.

@aturoczy

aturoczy commented Feb 14, 2024

Copy link
Copy Markdown
Contributor

@SourabhBadhya @deniskuzZ @abstractdog Could you pls check this?

SourabhBadhya
SourabhBadhya reviewed Feb 14, 2024
View reviewed changes
Comment thread ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDTFStack.java Outdated
Comment thread ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDTFStack.java
Comment thread ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDTFStack.java
@github-actions github-actions Bot removed the stale label Feb 15, 2024
SourabhBadhya
SourabhBadhya approved these changes Feb 15, 2024
View reviewed changes

@SourabhBadhya SourabhBadhya left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, you must probably rebase and retrigger the tests.

@sonarqubecloud

sonarqubecloud Bot commented Feb 15, 2024

Copy link
Copy Markdown

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@okumin

okumin commented Feb 16, 2024

Copy link
Copy Markdown
Contributor Author

@SourabhBadhya Thanks for your review! I rebased this branch and confirmed all tests passed 👍

@SourabhBadhya
SourabhBadhya merged commit 5b76949 into apache:master Feb 20, 2024
@okumin
okumin deleted the HIVE-27950-stack branch February 20, 2024 05:31
@okumin

okumin commented Feb 20, 2024

Copy link
Copy Markdown
Contributor Author

Thanks for reviewing and merging this PR 👍

dengzhhu653 pushed a commit to dengzhhu653/hive that referenced this pull request Mar 7, 2024
@okumin @dengzhhu653
HIVE-27950: STACK UDTF returns wrong results when number of arguments…
32c802a 
… is not a multiple of N (apache#4938) (okumin reviewed by Attila Turoczy, Zsolt Miskolczi and Sourabh Badhya)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SourabhBadhya SourabhBadhya SourabhBadhya approved these changes
+2 more reviewers
@aturoczy aturoczy aturoczy left review comments
@InvisibleProgrammer InvisibleProgrammer InvisibleProgrammer approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

tests passed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@okumin @InvisibleProgrammer @aturoczy @SourabhBadhya @asf-ci-hive