Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HIVE-20979: Fix memory leak in hive streaming #495

Open
wants to merge 2 commits into
base: master
from

Conversation

@ShubhamChaurasia
Copy link

commented Nov 28, 2018

Fixes two memory leaks.
-In HiveStreamingConnection due to Shutdown hook not being removed.
-In AbstractRecordWriter due to FileSystem not being closed.

try {
this.fs.close();
} catch (IOException e) {
LOG.error("Error while closing FileSystem", e);

This comment has been minimized.

Copy link
@EricWohlstadter

EricWohlstadter Nov 29, 2018

Contributor

I think we should propagate this error as a RuntimeException instead of swallowing it.
If FileSystem fails to close, that would signal a serious problem.

This comment has been minimized.

Copy link
@ShubhamChaurasia
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.