HIVE-28081: Code refine on ClearDanglingScratchDir::removeLocalTmpFiles#5090
Merged
Conversation
zhangbutao
commented
Feb 19, 2024
| if (file.canWrite() && file.delete()) { | ||
| consoleMessage("While removing '" + sessionName + "' dangling scratch dir from HDFS, " | ||
| + "local tmp session file '" + file.getPath() + "' has been cleaned as well."); | ||
| } else if (file.getName().startsWith(sessionName)) { |
Contributor
Author
There was a problem hiding this comment.
See Line 254, file in here is already startsWith(sessionName), so no need check this again.
|
okumin
approved these changes
Feb 19, 2024
dengzhhu653
pushed a commit
to dengzhhu653/hive
that referenced
this pull request
Mar 7, 2024
…es (apache#5090)(Butao Zhang, reviewed by okumin, Stamatis Zampetakis)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Why are the changes needed?
Code refine. Make code more readable.
Does this PR introduce any user-facing change?
No
Is the change a dependency upgrade?
No
How was this patch tested?
Existing UT.