Repository navigation
HIVE-28139: Upgrade to datasketches 1.2.0 - #5144
Conversation
|
We may ask the DataSketches community to cut a new tag someday. I recalled making changes to avoid WARNING when registering sketch UDFs. In another thought, we may port UDFs in datasketches-hive to hive in the future to maintain them on our own. |
Good to know you fix this issue!
I see datasketches-hive is still under development, though there is no commit for long time. I guess maybe it is stable. But if we Hive community has strong usage about datasketches-hive udf, i think it is good to port them into Hive's repository. I would hear more folk's opinion about this and i think this part can be discussed more through Hive dev email. I just did take a look at the Hive4 code. I found https://issues.apache.org/jira/browse/HIVE-22940 has registered some datasketches-hive udf, could you please help to double check this? @okumin |
Just a random thought but I agree as a future option.
That's true, and I remember I modified UDFs which are registered by FunctionRegistry so that I don't see WARNINGs. As far as I know, it is just a warning and no critical errors happen. |
|




What changes were proposed in this pull request?
https://datasketches.apache.org/docs/Community/Downloads.html shows that the latest version of datasketches-hive(Java Hive Adaptor) is 1.2.0, so we can upgrade it to from 1.1.0 to 1.2.0.
Why are the changes needed?
Does this PR introduce any user-facing change?
No
Is the change a dependency upgrade?
Yes
mvn_den_log.txt
How was this patch tested?
Existing UTs.