HIVE-28326: Fix StageIDsRearranger - #5299
Merged
Merged
Conversation
|
okumin
reviewed
Jun 24, 2024
| join_vc.q,\ | ||
| list_bucket_dml_8.q,\ | ||
| localtimezone.q,\ | ||
| manyViewJoin.q,\ |
Contributor
There was a problem hiding this comment.
Why can we test HIVE-28326 using manyViewJoin.q? I applied the change of StageIDsRearranger.java, built it, and run mvn test -Dtest=TestCliDriver -Dtest.output.overwrite=false -Dqfile=manyViewJoin.q. The test succeeded on my machine.
Contributor
There was a problem hiding this comment.
I understand the test case with the original revision fails with NPE when I use TestMiniLlapLocalCliDriver.
See ./ql/target/tmp/log/hive.log or ./itests/qtest/target/tmp/log/hive.log, or check ./ql/target/surefire-reports or ./itests/qtest/target/surefire-reports/ for specific test cases logs.
java.lang.NullPointerException
at org.apache.hadoop.hive.ql.optimizer.physical.LlapDecider.resolve(LlapDecider.java:530)
at org.apache.hadoop.hive.ql.parse.TezCompiler.optimizeTaskPlan(TezCompiler.java:834)
at org.apache.hadoop.hive.ql.parse.TaskCompiler.compile(TaskCompiler.java:340)
okumin
approved these changes
Jun 24, 2024
okumin
left a comment
okumin
left a comment
Contributor
There was a problem hiding this comment.
I have confirmed all PhysicalPlanResolvers used in TezCompiler returns a context now
dengzhhu653
pushed a commit
to dengzhhu653/hive
that referenced
this pull request
Sep 14, 2024
…ys Kuzmenko, Shohei Okumiya) Closes apache#5299
dengzhhu653
pushed a commit
to dengzhhu653/hive
that referenced
this pull request
Sep 20, 2024
…ys Kuzmenko, Shohei Okumiya) Closes apache#5299
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
StageIDsRearranger now returns PhysicalContext instead of null.
Why are the changes needed?
The return value of a PhysicalResolver is passed to another PhysicalResolver. So returning null makes problem in the following PhysicalResolver.
Does this PR introduce any user-facing change?
No
Is the change a dependency upgrade?
No
How was this patch tested?
Using manyViewJoin.q. Also I changed the test driver to TestMiniLlapLocalCliDriver, which becomes the default test driver since HIVE-23510.