HIVE-28439: Iceberg: Bucket partition transform with DECIMAL can throw NPE - #5387
Merged
Conversation
|
Contributor
Author
|
Thanks! |
dengzhhu653
pushed a commit
to dengzhhu653/hive
that referenced
this pull request
Sep 14, 2024
…w NPE (Shohei Okumiya, reviewed by Denys Kuzmenko) Closes apache#5387
dengzhhu653
pushed a commit
to dengzhhu653/hive
that referenced
this pull request
Sep 23, 2024
…w NPE (Shohei Okumiya, reviewed by Denys Kuzmenko) Closes apache#5387
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Fix a bug in the iceberg_bucket UDF.
Why are the changes needed?
A bucket partition transform with DECIMAL doesn't correctly work when the source column type has extreme configurations. Simply,
GenericUDFIcebergBucketalways uses the default precision and scale regardless of the precise source type.Does this PR introduce any user-facing change?
No
Is the change a dependency upgrade?
No
How was this patch tested?
Update a qtest which fails in the current master