HIVE-28446: Convert some reserved words to non-reserved words

[okumin]

What changes were proposed in this pull request?

Mark some reserved words as non-reserved based on the ANSI standard. I did the following.

1. Write unit tests using the existing parser
2. Pick up keywords that are not reserved in the ANSI standard
   • https://www.postgresql.org/docs/9.5/sql-keywords-appendix.html
   • SQL:2023
3. Add reserved words which are not declared in the WIKI to the non-reserved list

Why are the changes needed?

We found some extra reserved keywords have been added while we were testing Hive 2 -> Hive 4. I guess some of them are intentionally reserved, but some of them are unintentionally reserved.

One point. We're not biased toward making everything non-reserved. It is OK to discard this PR and add all keywords to the WIKI.

Does this PR introduce any user-facing change?

Users can use the changed words without adding quotes.

This PR would not tighten any restrictions, so I assume this is backward compatible.

Is the change a dependency upgrade?

No.

How was this patch tested?

Added unit tests, and checked the behavior of Trino and PostgreSQL.

trino> create table hive.default.test_keywords (APPLICATION int, COMPACTIONID int, CONF int, CONNECTOR int, CONNECTORS int, DATABASE int, DDL int, EXCHANGE int, EXTENDED int, FOLLOWING int, FORCE int, IF int, LESS int, MACRO int, MORE int, OLDER int, PKFK_JOIN int, PRECEDING int, SYNC int, THAN int, TIMESTAMPLOCALTZ int, UNBOUNDED int);
CREATE TABLE

postgres=# create table test_keywords (APPLICATION int, COMPACTIONID int, CONF int, CONNECTOR int, CONNECTORS int, DATABASE int, DDL int, EXCHANGE int, EXTENDED int, FOLLOWING int, FORCE int, IF int, LESS int, MACRO int, MORE int, OLDER int, PKFK_JOIN int, PRECEDING int, SYNC int, THAN int, TIMESTAMPLOCALTZ int, UNBOUNDED int);
CREATE TABLE

[okumin]

Tickets and fix versions

• KW_APPLICATION: HIVE-18004(fix version=3.0.0)
• KW_COMPACT_ID: HIVE-26580(4.0.0)
• KW_DATACONNECTOR & KW_DATACONNECTORS: HIVE-24396(4.0.0)
• KW_DDL: HIVE-24596(4.0.0)
• KW_FORCE: HIVE-4367(4.0.0)
• KW_OLDER & KW_THAN: HIVE-27906(4.0.0)
• KW_PKFK_JOIN: HIVE-23817(maybe 4.0.0)
• KW_TIMESTAMPLOCALTZ: HIVE-16614(3.0.0)
  • This could have replaced KW_TIMESTAMPTZ which is non-reserved

[deniskuzZ]

should we drop this as well since TOK_TIMESTAMPTZ doesn't exist?

[okumin]

You'll be right. I removed it.
03207b0

Also, I found some more extra words while addressing HIVE-19741. I cleaned them up in the same way.
a808727

[sonarqubecloud]

Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

[github-actions]

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.
Feel free to reach out on the dev@hive.apache.org list if the patch is in need of reviews.

[deniskuzZ]

LGTM +1

[okumin]

Thanks