HIVE-28625: Upgrade Apache Parquet version to 1.14.4 - #5552
Merged
Conversation
zhangbutao
force-pushed
the
HIVE-28625
branch
from
November 29, 2024 02:51
69ce9ca to
959123b
Compare
asf-ci-hive
added
tests pending
tests failed
and removed
tests unstable
tests pending
labels
asf-ci-hive
added
tests pending
tests passed
and removed
tests failed
tests pending
labels
okumin
reviewed
Nov 30, 2024
okumin
left a comment
okumin
left a comment
Contributor
There was a problem hiding this comment.
Generally, looks good to me
| 'current-schema'='{"type":"struct","schema-id":0,"fields":[{"id":1,"name":"i","required":false,"type":"int"},{"id":2,"name":"s","required":false,"type":"string"}]}', | ||
| 'current-snapshot-id'='#SnapshotId#', | ||
| 'current-snapshot-summary'='{"added-data-files":"1","added-records":"3","added-files-size":"628","changed-partition-count":"1","total-records":"3","total-files-size":"628","total-data-files":"1","total-delete-files":"0","total-position-deletes":"0","total-equality-deletes":"0","iceberg-version":"#Masked#"}', | ||
| 'current-snapshot-summary'='{"added-data-files":"1","added-records":"3","added-files-size":"#Masked#","changed-partition-count":"1","total-records":"3","total-files-size":"671","total-data-files":"1","total-delete-files":"0","total-position-deletes":"0","total-equality-deletes":"0","iceberg-version":"#Masked#"}', |
Contributor
There was a problem hiding this comment.
Should total-files-size be masked?
Contributor
Author
There was a problem hiding this comment.
Good catach. Masked it. 7adde55
IMO, all files size & Data size related properties should be masked.
Contributor
There was a problem hiding this comment.
Agree. We may finally mask all at the level of Iceberg driver or somewhere else someday
asf-ci-hive
added
tests pending
tests unstable
and removed
tests passed
tests pending
tests unstable
labels
okumin
reviewed
Nov 30, 2024
okumin
left a comment
okumin
left a comment
Contributor
There was a problem hiding this comment.
Waiting for CI to be completed
asf-ci-hive
added
tests unstable
tests pending
and removed
tests pending
tests unstable
labels
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Why are the changes needed?
https://github.com/apache/parquet-java/pull/3041/files fixed a bug related to data loss. We should upgrade the latest parquet version to avoid this issue.
btw, Iceberg also revert the low version 1.13.1 & upgrade to 1.14.4 to fix the issue. https://github.com/apache/iceberg/pull/11462/files
BTW, Parquet 1.14 has added the Hadoop Vectored IO feature in https://issues.apache.org/jira/browse/PARQUET-2171, so i think we can use this good feature after the upgrading. :)
Does this PR introduce any user-facing change?
No
Is the change a dependency upgrade?
see the file mvndep.log
How was this patch tested?
The existing tests