HIVE-28608: Resolve Issues in ReplicationMigrationTool and Activate Test Suite - #5595
Merged
Conversation
|
Contributor
Author
|
@ayushtkn Can you help to review. Thanks |
Contributor
Author
|
@deniskuzZ @ayushtkn @okumin Please help to review the PR. Thanks |
okumin
approved these changes
Jan 13, 2025
okumin
left a comment
okumin
left a comment
Contributor
There was a problem hiding this comment.
+1. I'm waiting for 24 hours to follow the guideline
| System.out.println("Time Taken: " + (System.currentTimeMillis() - startTime) + " ms"); | ||
| if (failed != 0) { | ||
| return -1; | ||
| } |
| LocatedFileStatus sourceFile = srcListing.next(); | ||
| if (filtersPattern != null && !isCopied(sourceFile.getPath(), filtersPattern)) { | ||
| LOG.info("Entry: {} is filtered.", sourceFile.getPath()); | ||
| continue; |
Contributor
There was a problem hiding this comment.
I understand this is just a cleanup that doesn't change behaviors
Contributor
Author
|
@okumin Can you help to check this PR |
henrib
pushed a commit
to henrib/hive
that referenced
this pull request
Jan 31, 2025
…est Suite (apache#5595) (Indhumathi Muthumurugesh, reviewed by Shohei Okumiya)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Fixed minor bugs in ReplicationMigrationTool and enabled TestReplicationMigrationTool class
Why are the changes needed?
The testcases were not running properly from beginning and went unnoticed because of lower Maven surefire plugin which suppressed the errors. Post HIVE-28519 the test cases started failing. Error log is added in the jira.
Does this PR introduce any user-facing change?
No
Is the change a dependency upgrade?
No
How was this patch tested?
Existing test case