HIVE-28619: TestHivePrivilegeObjectOwnerNameAndType to run on Tez - #5600
Merged
Merged
Conversation
|
Contributor
|
LGTM +1 (non-binding) |
okumin
approved these changes
Jan 11, 2025
Contributor
There was a problem hiding this comment.
+1. Thanks
The staging directory is created by the system user when the test is executed in local file system mode.
I can agree with this statement.
Since the main goal is to validate the privilege object type and count, without checking the owner name, the simplest fix is to run the tests as the system user.
It would be great if we could also check the name as String in testOwnerNames, but I think it is not easy because of the constraint of the local mode.
henrib
pushed a commit
to henrib/hive
that referenced
this pull request
Jan 31, 2025
…ache#5600) (Indhumathi Muthumurugesh, reviewed by Raghav Aggarwal, Shohei Okumiya)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This test class is intended to validate the HivePrivilegeObject for queries. If the current user is changed, insert queries fail when executed on Tez due to the validation of the staging directory's owner. The staging directory is created by the system user when the test is executed in local file system mode. Since the main goal is to validate the privilege object type and count, without checking the owner name, the simplest fix is to run the tests as the system user.
Why are the changes needed?
Since MR is deprecated, remove the test dependency as well, by running with Tez
Does this PR introduce any user-facing change?
No
Is the change a dependency upgrade?
No
How was this patch tested?
Test pipeline