HIVE-28725: Sorting is performed when order by position is disabled when CBO is enabled - #5623
Merged
Merged
Conversation
…hen CBO is enabled
kasakrisz
force-pushed
the
HIVE-28725-master-ob-pos
branch
from
January 28, 2025 08:34
fb87201 to
d4f0053
Compare
asf-ci-hive
added
tests pending
tests unstable
tests failed
and removed
tests unstable
tests pending
tests failed
labels
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
HiveSortLimitoperator whenhive.orderby.position.aliasis disabled and theOrder byclause of the query has integer constants as keys. Also ignore the constants as keys when there are both column references and constant keys.HiveSortExchangeoperator when both field collaction and distribution keys are all constants andhive.orderby.position.aliasis disabled. Also ignore the constants as keys when there are both column references and constant keys.Why are the changes needed?
To synchronize the Order/Sort/Distribute/Cluster by behaviors when
hive.orderby.position.aliasis disabled and CBO is enabled/disabled .Does this PR introduce any user-facing change?
Yes, the results of queries with Order/Sort/Cluster by clauses may have different order.
Is the change a dependency upgrade?
No.
How was this patch tested?