[HIVE-28794]: Remove junit version from hive-metastore-tools/pom.xml to inherit version from parent pom

[arorasimran0309]

What changes were proposed in this pull request?

Junit version upgrade in hive-metastore-tools

Why are the changes needed?

To bring version consistency throughout

Does this PR introduce any user-facing change?

No

Is the change a dependency upgrade?

Yes

How was this patch tested?

Before:

After:

dptree_junit.txt

[okumin]

The intention looks good to me. I wonder why we have to specify the version in both standalone-metastore/pom.xml and this file. Can we remove these properties and inherit the dependency management settings of the parent project?

[ayushtkn]

long long ago, there was a initiative HIVE-17159, where people wanted to make sure standalone-metastore should be independently releasable, so this is the reason these versions are duped here.

Though that initiative didn't work the way people wanted, but did leave this for us & I think going back has another set of challenges, considering it had consensus back then

[okumin]

Thanks for the explanation. In this case, we replicate the same property four times. I feel that the property in standalone-metastore/metastore-tools/pom.xml can be consolidated to that in standalone-metastore/pom.xml.

% git grep '<junit.jupiter.version>'
pom.xml:    <junit.jupiter.version>5.11.2</junit.jupiter.version>
standalone-metastore/metastore-tools/pom.xml:    <junit.jupiter.version>5.6.2</junit.jupiter.version>
standalone-metastore/pom.xml:    <junit.jupiter.version>5.11.2</junit.jupiter.version>
storage-api/pom.xml:    <junit.jupiter.version>5.11.2</junit.jupiter.version>

[arorasimran0309]

Thanks for the review and suggestions. Made the necessary changes.
<junit.jupiter.version> and <junit.vintage.version> consolidated, to be inherited from the parent standalone-metastore/pom.xml

[ayushtkn]

    <junit.platform.runner.version>1.2.0</junit.platform.runner.version>
    <junit.jupiter.api.version>5.2.0</junit.jupiter.api.version>

These are also defined in this pom, I don't think they are being used, can we drop them as well?

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[arorasimran0309]

    <junit.platform.runner.version>1.2.0</junit.platform.runner.version>
    <junit.jupiter.api.version>5.2.0</junit.jupiter.api.version>

These are also defined in this pom, I don't think they are being used, can we drop them as well?

Yes, the version specifications <junit.platform.runner.version> and <junit.jupiter.api.version> are orphaned, and therefore can be dropped. Have made the required changes to clean up the codebase.

[ayushtkn]

LGTM