Repository navigation
HIVE-28842: Hive ACID: Compaction cleaner refactor - #5705
Merged
Merged
Conversation
asf-ci-hive
added
tests pending
tests unstable
and removed
tests failed
tests pending
labels
okumin
reviewed
Mar 23, 2025
okumin
left a comment
okumin
left a comment
Contributor
There was a problem hiding this comment.
Looks good. I left only a minor comment
| requestBuilder.setUser(ci.runAs); | ||
| requestBuilder.setTransactionId(0); | ||
|
|
||
| LockComponentBuilder lockCompBuilder = new LockComponentBuilder() |
Contributor
There was a problem hiding this comment.
|
deniskuzZ
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Code refactor, reuse utils methods to avoid code duplication
Why are the changes needed?
TechDept
Does this PR introduce any user-facing change?
No
Is the change a dependency upgrade?
No
How was this patch tested?
Jenkins