Repository navigation
HIVE-28840: HMS Iceberg Catalog doesn't respect ICEBERG_CATALOG_SERVLET_AUTH - #5710
Merged
Merged
Conversation
okumin
changed the title
deniskuzZ
reviewed
Mar 23, 2025
deniskuzZ
reviewed
Mar 23, 2025
Member
|
hi @okumin, ping in case you missed the comments update |
Contributor
Author
|
@deniskuzZ Sorry, I could not respond promptly. I updated the branch |
deniskuzZ
reviewed
Apr 3, 2025
| public ServletSecurity(Configuration conf) { | ||
| this(conf, isAuthJwt(conf)); | ||
| public ServletSecurity(String authType, Configuration conf) { | ||
| this.conf = conf; |
Member
There was a problem hiding this comment.
@okumin, why not call the existing constructor?
this(conf, isAuthJwt(authTypeStr));
Contributor
Author
There was a problem hiding this comment.
Just my bad. Updated!
asf-ci-hive
added
tests pending
tests unstable
and removed
tests failed
tests pending
labels
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Let HMSCatalog, the Iceberg REST catalog on HMS, respect the parameter.
Why are the changes needed?
We can't configure the auth mode of the catalog API
Does this PR introduce any user-facing change?
No. This feature has not been released yet
Is the change a dependency upgrade?
No
How was this patch tested?
I ran the server on my local machine