HIVE-28904: Remove Arrow from Hive - #5772
Conversation
asf-ci-hive
added
tests failed
tests pending
and removed
tests pending
tests failed
labels
abstractdog
changed the title
asf-ci-hive
added
tests pending
tests passed
and removed
tests failed
tests pending
labels
okumin
left a comment
okumin
left a comment
There was a problem hiding this comment.
I'm not sure if we can justify the use case in LLAP. I reviewed only the correctness of these changes, assuming we should discontinue the feature.
Also, this PR will remove some flaky tests. Please void the following tickets when we merge this PR.
|
|
||
| LOG.info("Registered id: " + fragmentId); | ||
|
|
||
| @SuppressWarnings("rawtypes") |
There was a problem hiding this comment.
I guess this warning would disappear if we restored this annotation.
https://sonarcloud.io/project/issues?sinceLeakPeriod=true&issueStatuses=OPEN%2CCONFIRMED&pullRequest=5772&id=apache_hive&open=AZY1rqPeKcDofJK_Opr6
| int maxPendingWrites = HiveConf.getIntVar(conf, | ||
| HiveConf.ConfVars.LLAP_DAEMON_OUTPUT_SERVICE_MAX_PENDING_WRITES); | ||
| boolean useArrow = HiveConf.getBoolVar(conf, HiveConf.ConfVars.LLAP_OUTPUT_FORMAT_ARROW); | ||
| @SuppressWarnings("rawtypes") |
|
|
thanks @okumin for the review! |
done |
3 participants
What changes were proposed in this pull request?
To remove Arrow dependency and usage from hive.
Why are the changes needed?
Maintenance burden, and it's not used anymore.
https://lists.apache.org/thread/j1hclgwqytbhdbbbw12sy1nrpxvbq1c1
Does this PR introduce any user-facing change?
No, unless the user still utilizes a long-time abandoned hive warehouse connector reader mode.
Is the change a dependency upgrade?
No.
How was this patch tested?
Precommit testing.