HIVE-28937: Static analysis issues fixed in shell scripts

[bond-]

What changes were proposed in this pull request?

This pull request addresses several static analysis issues identified in the shell scripts located in the packaging folder. The issues were detected using ShellCheck and include:

1. SC2086: Double quote to prevent globbing and word splitting. Link to SC2086
2. SC2125: Brace expansion is not supported in POSIX sh. Link to SC2125
3. SC2223: This default assignment may cause problems when concatenating strings. Link to SC2223

Why are the changes needed?

These changes are necessary to ensure that the shell scripts in the packaging folder adhere to best practices and avoid potential issues related to globbing, word splitting, brace expansion, and string concatenation. Addressing these issues will improve the reliability and maintainability of the scripts.

Does this PR introduce any user-facing change?

No, this PR does not introduce any user-facing changes. It solely focuses on improving the internal shell scripts.

How was this patch tested?

The patch was tested by running ShellCheck on the modified shell scripts to ensure that the identified issues were resolved. Additionally, the scripts were manually tested to verify that they function correctly after the changes.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[okumin]

I tested it in the following way.

Build a snapshot Hive

mvn clean package -Dmaven.javadoc.skip=true -DskipTests -Pdist

Build an image

./packaging/src/docker/build.sh

Test HS2

docker run -it --rm --env SERVICE_NAME=hiveserver2 --name hive apache/hive:4.1.0-SNAPSHOT

[bond-]

@okumin thanks, who is going to be merging this PR?

[okumin]

I'll ignore the CI failure because this PR is very unrelated to our unit or integration tests

[okumin]

@bond- Merged. Thanks for your contributions! It looks like you're trying to create a minimal Docker image to expose HMS. I personally think it is an important step to have production-grade images of Hive. I'm willing to help you.
https://docs.google.com/document/d/1tKFmsjYeGlMQjvJ7QQDNcS5wvqrcHRvsDjbJlcHb7Gk/edit?tab=t.0

Thanks.

[bond-]

@okumin sure more the better, let me know how you would like to collaborate? Slack?

[okumin]

@bond-
The Apache Way requires us to make any decisions on the mailing list. I believe you can also use Slack to gather some information, e.g., by questioning me about my opinion or brainstorming it.