HIVE-28944: Mask File, data sizes in tests - #5803
Merged
Merged
Conversation
deniskuzZ
reviewed
May 7, 2025
asf-ci-hive
added
tests failed
tests pending
and removed
tests pending
tests failed
labels
kokila-19
changed the title
asf-ci-hive
added
tests pending
tests failed
and removed
tests failed
tests pending
labels
asf-ci-hive
added
tests pending
tests unstable
tests failed
and removed
tests failed
tests pending
tests unstable
labels
asf-ci-hive
added
tests pending
tests failed
and removed
tests passed
tests pending
labels
asf-ci-hive
added
tests pending
tests failed
and removed
tests failed
tests pending
labels
asf-ci-hive
added
tests pending
tests passed
and removed
tests failed
tests pending
labels
Contributor
Author
|
@deniskuzZ @okumin Thanks for the comments and I have addressed them. |
deniskuzZ
reviewed
May 22, 2025
deniskuzZ
reviewed
May 22, 2025
okumin
approved these changes
May 26, 2025
okumin
left a comment
okumin
left a comment
Contributor
There was a problem hiding this comment.
I checked all files and gave this +1!
|
Contributor
|
Merged. Thanks @kokila-19 for submitting the patch, @deniskuzZ @simhadri-g for your reviews! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Data size, table size, and file size values frequently change during upgrades or similar activities, so we are masking them in qtests.
Why are the changes needed?
To avoid the need for continual updates and maintenance of these values, we are masking them. This will help reduce overhead and improve maintainability.
Does this PR introduce any user-facing change?
No
How was this patch tested?
qtest