HIVE-28917: NPE in merge statement when checking nullability of joining column in matched clause - ADDENDUM

[soumyakanti3578]

…ng column in matched clause - ADDENDUM

What changes were proposed in this pull request?

Fix a failing test

Why are the changes needed?

Some time had passed between the green tests of #5781 and it's merge. #5798 was merged in between, which removes unnecessary virtual columns. This causes the test failure in merge_with_null_check_on_joining_col.q which was added in the former PR.

Does this PR introduce any user-facing change?

No

How was this patch tested?

mvn test -pl itests/qtest-iceberg -Piceberg -Pitests -Dtest=TestIcebergCliDriver -Dtest.output.overwrite=true -Dqfile="merge_with_null_check_on_joining_col.q"

[abstractdog]

let's merge this even if there are some unrelated problems and the test is not green (the point is the the affected qtest will pass)

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[soumyakanti3578]

I agree. Maybe @kasakrisz or @zabetak can help merge this. The last run failed because of infra issues. I do not expect any problems if this is merged before the tests are done.

[zabetak]

@abstractdog @okumin Have you verified that the test passes locally? If yes then let's just merge this immediately.

[okumin]

@zabetak Yes, I have. Precisely, I verified (1) mvn test -Pitests -pl itests/qtest-iceberg -Dtest=TestIcebergCliDriver -Dqfile=merge_with_null_check_on_joining_col.q failed with the master branch and (2) the same test command succeeded after I pulled it with gh pr checkout 5815 -R apache/hive and rebuilt hive-exec. I'll merge this pull request.

[okumin]

Now, it's green.
https://ci.hive.apache.org/blue/organizations/jenkins/hive-precommit/detail/master/2520/pipeline/

@soumyakanti3578 @abstractdog @zabetak Thanks for your quick fix and reviews!