HIVE-29047: Adjust httpclient5 httpcore dependencies in TestHttpServices#5907
Conversation
| <groupId>org.apache.httpcomponents.core5</groupId> | ||
| <artifactId>httpcore5</artifactId> | ||
| </exclusion> | ||
| </exclusions> |
There was a problem hiding this comment.
What happens if we don't exclude it? We eventually need this dependency when we adapt Hive QL to Iceberg REST API. It sounds fine to exclude it at this point.
There was a problem hiding this comment.
It works without the exclusions too.
|
I rebased the change on top of master |
asf-ci-hive
added
tests failed
tests pending
tests unstable
and removed
tests pending
tests failed
labels
|
Do we need an other clean test run or how can we move forward with this? |
|
@richardantal https://lists.apache.org/thread/qbfh1fq6rj629y5xrt45v0qw64828zf2 |
|
@richardantal : thanks for this patch! please ban http components 5 import to prevent future unintentional usage |
added restriction for the imports too
|
|
Merged. @richardantal Thanks for submitting the patch, @abstractdog thanks for the additional review! |
|
Thank you for merging, and for the reviews. |
4 participants
What changes were proposed in this pull request?
Adjust httpclient5 httpcore dependencies in TestHttpServices
https://github.com/richardantal/hive/pull/new/HIVE-29047
Why are the changes needed?
In TestHttpServices we use transitive httpclient5 and httpcore5 dependencies because of
174ac62
Later It will break in case of 1.26 avatica version
Does this PR introduce any user-facing change?
No.
How was this patch tested?
I ran TestHttpServices unit test