Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HIVE-21992: REPL DUMP throws NPE when dumping Create Function event. #725

Closed
wants to merge 2 commits into from

Conversation

sankarh
Copy link
Contributor

@sankarh sankarh commented Jul 16, 2019

No description provided.

@@ -0,0 +1,66 @@
/*
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

instead of mock we can add a replication test for functions.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

resourceUris.add(new ResourceUri(uri.getResourceType(), newFileUri));
} else {
resourceUris.add(uri);
if (function.getResourceUris() != null) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we need to inform user if the uri is null ? or we should throw exception ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it seems to be a valid case which "CREATE FUNCTION" command allows.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants