Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HIVE-21884 #794

Open
wants to merge 366 commits into
base: master
from
Open

HIVE-21884 #794

wants to merge 366 commits into from

Conversation

@kgyrtkirk
Copy link
Member

kgyrtkirk commented Oct 1, 2019

No description provided.


String scriptsDir = getScriptsDir();

this.initScript = scriptsDir + File.separator + testArgs.getInitScript();
this.cleanupScript = scriptsDir + File.separator + testArgs.getCleanupScript();

postInit();
conf.setVar(HiveConf.ConfVars.HIVE_SCHEDULED_QUERIES_EXECUTOR_IDLE_SLEEP_TIME, "1s");

This comment has been minimized.

Copy link
@jcamachor

jcamachor Nov 1, 2019

Contributor

Default for q tests could be changed by modifying files in data/conf/*.xml instead of adding them here (my understanding is that we only to the class those property values that need to be changed at initialization time).

This comment has been minimized.

Copy link
@kgyrtkirk

kgyrtkirk Nov 6, 2019

Author Member

yes; this was placed here in the beginning...I would agree with you - but I try to move in the direction of decomposing qtestutil by adding some qtest option - the scheduledqueryservice has a qtest option ; I moved this "set" to there - so that way it doesn't poison this file

thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.