Skip to content
Permalink
Browse files
Merge pull request #848 from nadment/HOP-2931
HOP-2931 Add plugin's documentation link in the plugin perspective
  • Loading branch information
hansva committed Jun 3, 2021
2 parents 729d292 + 38d1261 commit 4ba56bf20cf2c44b8ee3f19a2dbde5c5b3e05b9f
Showing 6 changed files with 6 additions and 7 deletions.
@@ -698,6 +698,7 @@ private IRowMeta getPluginInformationRowMeta() {
row.addValueMeta( new ValueMetaString( BaseMessages.getString( PKG, "PluginRegistry.Information.ImageFile.Label" ) ) );
row.addValueMeta( new ValueMetaString( BaseMessages.getString( PKG, "PluginRegistry.Information.Category.Label" ) ) );
row.addValueMeta( new ValueMetaString( BaseMessages.getString( PKG, "PluginRegistry.Information.Keywords.Label" ) ) );
row.addValueMeta( new ValueMetaString( BaseMessages.getString( PKG, "PluginRegistry.Information.DocumentationUrl.Label" ) ) );
row.addValueMeta( new ValueMetaString( BaseMessages.getString( PKG, "PluginRegistry.Information.ClassName.Label" ) ) );
row.addValueMeta( new ValueMetaString( BaseMessages.getString( PKG, "PluginRegistry.Information.Libraries.Label" ) ) );

@@ -724,6 +725,7 @@ public RowBuffer getPluginInformation( Class<? extends IPluginType> pluginType )
row[ rowIndex++ ] = Const.NVL( plugin.getImageFile(), "" );
row[ rowIndex++ ] = Const.NVL( plugin.getCategory(), "" );
row[ rowIndex++ ] = String.join( ",", plugin.getKeywords() );
row[ rowIndex++ ] = Const.NVL( plugin.getDocumentationUrl(), "" );
row[ rowIndex++ ] = plugin.getClassMap().values().toString();
row[ rowIndex++ ] = String.join( ",", plugin.getLibraries() );

@@ -27,6 +27,7 @@ PluginRegistry.Information.Name.Label=Name
PluginRegistry.Information.Category.Label=Category
PluginRegistry.Information.Keywords.Label=Keywords
PluginRegistry.Information.Description.Label=Description
PluginRegistry.Information.DocumentationUrl.Label=Documentation url
PluginRegistry.RuntimeError.UnExpectedCreatingClassLoader.PLUGINREGISTRY008=Error creating class loader
PluginRegistry.RuntimeError.ClassNotFound.PLUGINREGISTRY003=Class not found
PluginRegistry.RuntimeError.MalformedURL.PLUGINREGISTRY006=Malformed URL
@@ -54,7 +54,7 @@ public void getGetPluginInformation() throws HopPluginException {
PluginRegistry.getInstance().reset();
RowBuffer result = PluginRegistry.getInstance().getPluginInformation( BasePluginType.class );
assertNotNull( result );
assertEquals( 9, result.getRowMeta().size() );
assertEquals( 10, result.getRowMeta().size() );

for ( IValueMeta vmi : result.getRowMeta().getValueMetaList() ) {
assertEquals( IValueMeta.TYPE_STRING, vmi.getType() );
@@ -48,7 +48,7 @@
image = "event-hubs-listener.svg",
categoryDescription = "Streaming",
documentationUrl =
"http://hop.apache.org/manual/latest/pipeline/transforms/azure-event-hubs-listener.html")
"https://hop.apache.org/manual/latest/pipeline/transforms/azure-event-hubs-listener.html")
public class AzureListenerMeta extends BaseTransformMeta
implements ITransformMeta<AzureListener, AzureListenerData> {

@@ -41,7 +41,7 @@
image = "event-hubs-writer.svg",
categoryDescription = "Streaming",
documentationUrl =
"http://hop.apache.org/manual/latest/pipeline/transforms/azure-event-hubs-writer.html")
"https://hop.apache.org/manual/latest/pipeline/transforms/azure-event-hubs-writer.html")
public class AzureWriterMeta extends BaseTransformMeta
implements ITransformMeta<AzureWrite, AzureWriterData> {

@@ -20,8 +20,6 @@
import org.apache.hop.core.exception.HopPluginException;
import org.apache.hop.core.exception.HopValueException;
import org.apache.hop.core.gui.plugin.GuiPlugin;
import org.apache.hop.core.gui.plugin.key.GuiKeyboardShortcut;
import org.apache.hop.core.gui.plugin.key.GuiOsxKeyboardShortcut;
import org.apache.hop.core.plugins.IPluginType;
import org.apache.hop.core.plugins.PluginRegistry;
import org.apache.hop.core.row.IRowMeta;
@@ -36,7 +34,6 @@
import org.apache.hop.ui.core.widget.ColumnInfo;
import org.apache.hop.ui.core.widget.TableView;
import org.apache.hop.ui.hopgui.HopGui;
import org.apache.hop.ui.hopgui.HopGuiKeyHandler;
import org.apache.hop.ui.hopgui.context.IGuiContextHandler;
import org.apache.hop.ui.hopgui.file.IHopFileType;
import org.apache.hop.ui.hopgui.file.IHopFileTypeHandler;
@@ -150,7 +147,6 @@ public void initialize( HopGui hopGui, Composite parent ) {
fdlSubject.left = new FormAttachment( label, props.getMargin() );
fdlSubject.top = new FormAttachment( label, 0, SWT.CENTER );
wPluginType.setLayoutData( fdlSubject );

wPluginType.addSelectionListener( new SelectionAdapter() {
@Override
public void widgetSelected( SelectionEvent arg0 ) {

0 comments on commit 4ba56bf

Please sign in to comment.