Expose method to check the cache is still active.#332
Merged
Conversation
arturobernalg
force-pushed
the
feature/active_cache
branch
from
7bf6ff5 to
414525f
Compare
ok2c
requested changes
Dec 11, 2021
| * @return {@code true} if the cache is active, otherwise return {@code false}. | ||
| * @since 5.2 | ||
| */ | ||
| default boolean isActive() { |
Member
There was a problem hiding this comment.
@arturobernalg Why adding this method to HttpCacheStorage when it clearly applies to ManagedHttpCacheStorage only and it makes no sense for all other implementations?
Member
Author
There was a problem hiding this comment.
ManagedHttpCacheStorage
that make sense. Didn't see the other implementations. My bad.
Changed only for ManagedHttpCacheStorage
arturobernalg
force-pushed
the
feature/active_cache
branch
from
c1cb88c to
16a91ad
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
And reuse code for
this.active.compareAndSet(true, false);validations.