added setAuthorityResolver() methods to AsyncServerBootstrap / ServerBootstrap #565
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I migrated a project from httpcore4 to httpcore5 just recently and when it didn't work, I had to dive into the httpcore5 sources to understand what was going wrong and that I need to create a custom
RequestRouterwithLOCAL_AUTHORITY_RESOLVERscheme to get the same behavior as before with httpcore4 just using simpleServerBootstrapmethods. It is quite a pain to build the customRequestRouterin the application itself, especially because this isn't really very well documented.With this new
setAuthorityResolver()method, the legacy behavior can be achieved by callingsetAuthorityResolver(RequestRouter.LOCAL_AUTHORITY_RESOLVER)in combination withsetCanonicalHostName("localhost")onServerBootstraporAsyncServerBootstrap.