Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not hard-define empty env var #28

Closed
wants to merge 10,000 commits into from
Closed

Do not hard-define empty env var #28

wants to merge 10,000 commits into from

Conversation

@benrubson
Copy link

benrubson commented Feb 28, 2017

Hello,

This PR solves issue #59371 :
https://bz.apache.org/bugzilla/show_bug.cgi?id=59371

Thank you 馃憤

Ben

jimjag and others added 30 commits Dec 13, 2016
git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1774070 13f79535-47bb-0310-9956-ffa450edef68
PR60478

Submitted By: Jeff Wheelouse <apache wheelhouse.org>
Committed By: covener


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1774288 13f79535-47bb-0310-9956-ffa450edef68
filtered out from the outgoing brigade by ap_http_outerror_filter() applying
the EOC semantic.


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1774322 13f79535-47bb-0310-9956-ffa450edef68
git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1774493 13f79535-47bb-0310-9956-ffa450edef68
On graceful shutdown/restart, kill kept-alive connections before poll()ing
again, avoiding to wait for their "normal" timers (before being woken up)
when they remain the last handled connections.



git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1774538 13f79535-47bb-0310-9956-ffa450edef68
鈥 they

are already or about to be closed.



git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1774541 13f79535-47bb-0310-9956-ffa450edef68
apr_uint64_t on some platforms.

Followup to r1649491.


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1774602 13f79535-47bb-0310-9956-ffa450edef68
build of mod_socache_memcache. It now needs
mod_status.h.

Untested but exactly analogous to what works for
mod_socache_shmcb and others.


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1774609 13f79535-47bb-0310-9956-ffa450edef68
git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1774893 13f79535-47bb-0310-9956-ffa450edef68
git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1774894 13f79535-47bb-0310-9956-ffa450edef68
"686: warning: 'ok' may be used uninitialized in
this function"
This is a false positive, because the value of "ok"
will only be used if stapling_get_cached_response()
sets "rsp" to non-NULL in which case it will always
have set "ok".


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1775173 13f79535-47bb-0310-9956-ffa450edef68
鈥d EOC

semantics to respectively warn the caller and cleanly terminate the connection
afterwards.

Suggested by: rpluem



git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1775195 13f79535-47bb-0310-9956-ffa450edef68
git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1775196 13f79535-47bb-0310-9956-ffa450edef68
on zOS, isascii() really means 7 bit ascii, but our strings
are in ebcdic for 99.95% of the lifetime of the server.



git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1775199 13f79535-47bb-0310-9956-ffa450edef68
 *) mod_proxy_fcgi, mod_fcgid: Fix crashes in ap_fcgi_encoded_env_len() when
    modules add empty environment variables to the request. PR60275.
    [<alex2grad AT gmail.com>]

Submitted By: <alex2grad AT gmail.com>]
Committed By: covener




git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1775487 13f79535-47bb-0310-9956-ffa450edef68
git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1775490 13f79535-47bb-0310-9956-ffa450edef68
git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1775491 13f79535-47bb-0310-9956-ffa450edef68
We are already checking an even narrower set of characters
just below.



git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1775664 13f79535-47bb-0310-9956-ffa450edef68
ylavic and others added 24 commits Feb 3, 2017
git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1781679 13f79535-47bb-0310-9956-ffa450edef68
git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1781680 13f79535-47bb-0310-9956-ffa450edef68
git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1781683 13f79535-47bb-0310-9956-ffa450edef68
git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1781684 13f79535-47bb-0310-9956-ffa450edef68
git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1781771 13f79535-47bb-0310-9956-ffa450edef68
seems like a steady stream of comments/questions in this area.



git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1781930 13f79535-47bb-0310-9956-ffa450edef68
When using shared MPMs, `httpd -V` will perform a full configuration
check, which emits warnings when there is no defined ServerName.
Unfortunately the test suite does a -V check for every test section,
spamming the output with noise.

Work around this by just uncommenting the example ServerName in the test
config.

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/branches/trunk-test-integration@1782066 13f79535-47bb-0310-9956-ffa450edef68
In bugzilla and users@ we keep receiving questions about
how to test the new restrictions imposed by HttpProtocolOptions.
Added some info about how to use openssl s_client properly
and the mod_dumpio's directives to debug (thanks to
Daniel Ferradal for this suggestion).



git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1782140 13f79535-47bb-0310-9956-ffa450edef68
git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1782164 13f79535-47bb-0310-9956-ffa450edef68
git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1782247 13f79535-47bb-0310-9956-ffa450edef68
As pointed out by Mark Brooks in the site comments.

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1782252 13f79535-47bb-0310-9956-ffa450edef68
git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1782254 13f79535-47bb-0310-9956-ffa450edef68
@benrubson

This comment has been minimized.

Copy link
Author

benrubson commented Mar 6, 2017

I Would also be very glad to see this backported to 2.4.x.
Many thx 馃憤

@covener

This comment has been minimized.

Copy link
Member

covener commented Jun 3, 2017

I am not sure this is safe to backport, it might be reasonable for people to be using empty native environment variables, e.g. when things are deactivated. It seems better to address the overlap between the different kinds of interpolation

@benrubson

This comment has been minimized.

Copy link
Author

benrubson commented Jun 3, 2017

Thank you for your feedback Eric 馃憤
Mmmmh you think that some may intentionally use MYVAR= "instead" of just running unset MYVAR.
Regarding the overlap issue you are talking about, to be honest, I'm not sure I'll be able to correct it :|

@asfgit asfgit closed this Oct 5, 2019
@asfgit asfgit force-pushed the apache:trunk branch from 91fd63d to 62d50ea Oct 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
You can鈥檛 perform that action at this time.