Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

*) mod_http2: fixes 2 regressions in server limit handling. #281

Closed
wants to merge 1 commit into from
Closed

*) mod_http2: fixes 2 regressions in server limit handling. #281

wants to merge 1 commit into from

Conversation

icing
Copy link
Contributor

@icing icing commented Dec 9, 2021 

 1. When reaching server limits, such as MaxRequestsPerChild, the
    HTTP/2 connection send a GOAWAY frame much too early on new
    connections, leading to invalid protocol state and a client
    failing the request. See PR65731.
    The module now initializes the HTTP/2 protocol correctly and
    allows the client to submit one request before the shutdown
    via a GOAWAY frame is being announced.
 2. A regression in v1.15.24 was fixed that could lead to httpd
    child processes not being terminated on a graceful reload or
    when reaching MaxConnectionsPerChild. When unprocessed h2
    requests were queued at the time, these could stall.
    See <https://github.com/icing/mod_h2/issues/212>.

*) mod_http2: fixes 2 regressions in server limit handling.
befd50a 
     1. When reaching server limits, such as MaxRequestsPerChild, the
        HTTP/2 connection send a GOAWAY frame much too early on new
        connections, leading to invalid protocol state and a client
        failing the request. See PR65731.
        The module now initializes the HTTP/2 protocol correctly and
        allows the client to submit one request before the shutdown
        via a GOAWAY frame is being announced.
     2. A regression in v1.15.24 was fixed that could lead to httpd
        child processes not being terminated on a graceful reload or
        when reaching MaxConnectionsPerChild. When unprocessed h2
        requests were queued at the time, these could stall.
        See <icing/mod_h2#212>.
asfgit pushed a commit that referenced this pull request Dec 13, 2021
@minfrin
Backport:
c1e16a6 
  *) mod_http2: fixes PR65731 and icing/mod_h2#212
     trunk patch: na, fixed on 2.4.x source base
     backport PR: #281
     +1: icing, minfrin, ylavic



git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/branches/2.4.x@1895869 13f79535-47bb-0310-9956-ffa450edef68
@minfrin
Copy link
Contributor

minfrin commented Dec 13, 2021

Backported to v2.4.52:

*) mod_http2: fixes PR65731 and icing/mod_h2#212
trunk patch: na, fixed on 2.4.x source base
backport PR: #281
+1: icing, minfrin, ylavic

@icing icing closed this Feb 14, 2022
@icing icing deleted the icing/pr65731 branch October 17, 2022 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@icing @minfrin