[MINOR] typo fix in BaseTableMetadata wrt spurious deletes handling (#…

…4673) Co-authored-by: yuezhang <yuezhang@freewheel.tv>
apache · Jan 24, 2022 · 7bd389fb4756193cbe22576911e51da863d1c345 · 7bd389f
1 parent e00a904
commit 7bd389fb4756193cbe22576911e51da863d1c345
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 6 deletions.
diff --git a/...client-common/src/main/java/org/apache/hudi/metadata/HoodieBackedTableMetadataWriter.java b/...client-common/src/main/java/org/apache/hudi/metadata/HoodieBackedTableMetadataWriter.java
@@ -535,7 +535,7 @@ private List<DirectoryInfo> listAllPartitions(HoodieTableMetaClient datasetMetaC
    * All FileGroups for a given metadata partition has a fixed prefix as per the {@link MetadataPartitionType#getFileIdPrefix()}.
    * Each file group is suffixed with 4 digits with increments of 1 starting with 0000.
    *
-   * Lets say we configure 10 file groups for record level index partittion, and prefix as "record-index-bucket-"
+   * Lets say we configure 10 file groups for record level index partition, and prefix as "record-index-bucket-"
    * File groups will be named as :
    *    record-index-bucket-0000, .... -> ..., record-index-bucket-0009
    */

diff --git a/hudi-common/src/main/java/org/apache/hudi/metadata/BaseTableMetadata.java b/hudi-common/src/main/java/org/apache/hudi/metadata/BaseTableMetadata.java
@@ -231,18 +231,18 @@ Map<String, FileStatus[]> fetchAllFilesInPartitionPaths(List<Path> partitionPath
   }
 
   /**
-   * May be handle spurious deletes. Depending on config, throw an exception or log a warn msg.
+   * Maybe handle spurious deletes. Depending on config, throw an exception or log a warn msg.
    * @param hoodieRecord instance of {@link HoodieRecord} of interest.
    * @param partitionName partition name of interest.
    */
   private void mayBeHandleSpuriousDeletes(Option<HoodieRecord<HoodieMetadataPayload>> hoodieRecord, String partitionName) {
     if (!hoodieRecord.get().getData().getDeletions().isEmpty()) {
-      if (!metadataConfig.ignoreSpuriousDeletes()) {
+      if (metadataConfig.ignoreSpuriousDeletes()) {
+        LOG.warn("Metadata record for " + partitionName + " encountered some files to be deleted which was not added before. "
+            + "Ignoring the spurious deletes as the `" + HoodieMetadataConfig.IGNORE_SPURIOUS_DELETES.key() + "` config is set to true");
+      } else {
         throw new HoodieMetadataException("Metadata record for " + partitionName + " is inconsistent: "
             + hoodieRecord.get().getData());
-      } else {
-        LOG.warn("Metadata record for " + partitionName + " encountered some files to be deleted which was not added before. "
-            + "Ignoring the spurious deletes as the `" + HoodieMetadataConfig.IGNORE_SPURIOUS_DELETES.key() + "` config is set to false");
       }
     }
   }