From cc1cf9ef4e0c6e64c8171a6cf246d0e4df63c64f Mon Sep 17 00:00:00 2001
From: lamber-ken <lamberken@163.com>
Date: Tue, 14 Jan 2020 08:55:40 +0800
Subject: [PATCH] [MINOR] Reuse random object

---
 .../apache/hudi/io/strategy/TestHoodieCompactionStrategy.java  | 3 ++-
 .../org/apache/hudi/utilities/TestHoodieDeltaStreamer.java     | 3 ++-
 2 files changed, 4 insertions(+), 2 deletions(-)

diff --git a/hudi-client/src/test/java/org/apache/hudi/io/strategy/TestHoodieCompactionStrategy.java b/hudi-client/src/test/java/org/apache/hudi/io/strategy/TestHoodieCompactionStrategy.java
index 86447f33b0f67..5eda0b2c945c3 100644
--- a/hudi-client/src/test/java/org/apache/hudi/io/strategy/TestHoodieCompactionStrategy.java
+++ b/hudi-client/src/test/java/org/apache/hudi/io/strategy/TestHoodieCompactionStrategy.java
@@ -53,6 +53,7 @@ public class TestHoodieCompactionStrategy {
 
   private static final long MB = 1024 * 1024L;
   private String[] partitionPaths = {"2017/01/01", "2017/01/02", "2017/01/03"};
+  private static final Random RANDOM = new Random();
 
   @Test
   public void testUnBounded() {
@@ -228,7 +229,7 @@ public void testUnboundedPartitionAwareCompactionSimple() {
   private List<HoodieCompactionOperation> createCompactionOperations(HoodieWriteConfig config,
       Map<Long, List<Long>> sizesMap) {
     Map<Long, String> keyToPartitionMap = sizesMap.keySet().stream()
-        .map(e -> Pair.of(e, partitionPaths[new Random().nextInt(partitionPaths.length - 1)]))
+        .map(e -> Pair.of(e, partitionPaths[RANDOM.nextInt(partitionPaths.length - 1)]))
         .collect(Collectors.toMap(Pair::getKey, Pair::getValue));
     return createCompactionOperations(config, sizesMap, keyToPartitionMap);
   }
diff --git a/hudi-utilities/src/test/java/org/apache/hudi/utilities/TestHoodieDeltaStreamer.java b/hudi-utilities/src/test/java/org/apache/hudi/utilities/TestHoodieDeltaStreamer.java
index 36ebb41ca9ba3..ed45346f4a2d2 100644
--- a/hudi-utilities/src/test/java/org/apache/hudi/utilities/TestHoodieDeltaStreamer.java
+++ b/hudi-utilities/src/test/java/org/apache/hudi/utilities/TestHoodieDeltaStreamer.java
@@ -93,6 +93,7 @@
  */
 public class TestHoodieDeltaStreamer extends UtilitiesTestBase {
 
+  private static final Random RANDOM = new Random();
   private static final String PROPS_FILENAME_TEST_SOURCE = "test-source.properties";
   private static final String PROPS_FILENAME_TEST_INVALID = "test-invalid.properties";
   private static final Logger LOG = LogManager.getLogger(TestHoodieDeltaStreamer.class);
@@ -634,7 +635,7 @@ public static class DistanceUDF implements UDF4<Double, Double, Double, Double,
      */
     @Override
     public Double call(Double lat1, Double lat2, Double lon1, Double lon2) {
-      return new Random().nextDouble();
+      return RANDOM.nextDouble();
     }
   }