refactor: consolidate common utility classes for Flink CDC read#18436
Merged
Conversation
HuangZhenQiu
force-pushed
the
refactor-source-v2
branch
from
e6568e4 to
0c20de4
Compare
HuangZhenQiu
force-pushed
the
refactor-source-v2
branch
from
0c20de4 to
358df2d
Compare
HuangZhenQiu
changed the title
cshuo
reviewed
Apr 2, 2026
Collaborator
cshuo
left a comment
cshuo
left a comment
There was a problem hiding this comment.
Thks for the contribution, left some comments.
| } | ||
| } | ||
|
|
||
| private ClosableIterator<RowData> createRecordIterator( |
Collaborator
There was a problem hiding this comment.
Is it possible refactor this method as an util method in CdcIterators, since it's almost same with CdcInputFormat#getRecordIterator
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #18436 +/- ##
============================================
+ Coverage 68.54% 68.70% +0.15%
- Complexity 27975 28044 +69
============================================
Files 2442 2446 +4
Lines 134530 134481 -49
Branches 16251 16264 +13
============================================
+ Hits 92218 92390 +172
+ Misses 35038 34810 -228
- Partials 7274 7281 +7
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Collaborator
danny0405
approved these changes
Apr 3, 2026
rahil-c
pushed a commit
to rahil-c/hudi
that referenced
this pull request
Apr 20, 2026
…he#18436) * refactor: consolidate common utility classes for Flink CDC read * resolve shuo's comments
dwshmilyss
pushed a commit
to dwshmilyss/hudi
that referenced
this pull request
May 21, 2026
…he#18436) * refactor: consolidate common utility classes for Flink CDC read * resolve shuo's comments
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the issue this Pull Request addresses
Consolidate common utility classes for Flink CDC read to reduce duplicated code
Summary and Changelog
Impact
none
Risk Level
none
Documentation Update
none
Contributor's checklist