[HUDI-6776] Replace JSON with Avro bytes for commit metadata #9579
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codope
force-pushed
the
HUDI-6776-commit-metadata-avro
branch
2 times, most recently
from
fb84dcf
to
8a550a0
Compare
|
Complete removal of JSON |
codope
force-pushed
the
HUDI-6776-commit-metadata-avro
branch
2 times, most recently
from
93953ca
to
5171318
Compare
danny0405
requested changes
Sep 11, 2023
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/BaseHoodieWriteClient.java
Show resolved
Hide resolved
hudi-cli/src/test/java/org/apache/hudi/cli/testutils/HoodieTestCommitMetadataGenerator.java
Show resolved
Hide resolved
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/BaseHoodieWriteClient.java
Outdated
Show resolved
Hide resolved
hudi-common/src/main/java/org/apache/avro/io/NoWrappingJsonEncoder.java
Outdated
Show resolved
Hide resolved
hudi-common/src/main/java/org/apache/hudi/common/model/HoodieCommitMetadata.java
Show resolved
Hide resolved
hudi-common/src/main/java/org/apache/hudi/common/table/timeline/MetadataConversionUtils.java
Show resolved
Hide resolved
| if (hoodieCommitMetadata instanceof HoodieReplaceCommitMetadata) { | ||
| return (T) convertReplaceCommitMetadata((HoodieReplaceCommitMetadata) hoodieCommitMetadata); | ||
| } | ||
| hoodieCommitMetadata.getPartitionToWriteStats().remove(null); |
There was a problem hiding this comment.
Can we add some doc why there is a null key in the map.
There was a problem hiding this comment.
i'm not sure why this was there even previously. I just kept the same logic.
hudi-common/src/test/java/org/apache/hudi/common/table/view/TestHoodieTableFileSystemView.java
Show resolved
Hide resolved
danny0405
approved these changes
Sep 12, 2023
codope
force-pushed
the
HUDI-6776-commit-metadata-avro
branch
from
3622194
to
731c9a5
Compare
Fix avro to json conversion and some tests Fix compilation issue Cleanup timeline utils and fix replace commit metadata serialization Fix import Fix some test paths Fix fsview tests Address comments and fix commit metadata avro schema
This reverts commit 01a6dda.
codope
force-pushed
the
HUDI-6776-commit-metadata-avro
branch
from
01a6dda
to
0a8df01
Compare
codope
commented
Sep 14, 2023
| * <p>This encoder is particularly useful when the standard Avro JSON format's verbosity | ||
| * for union types is not desired. | ||
| */ | ||
| public class JsonEncoder extends ParsingEncoder implements Parser.ActionHandler { |
There was a problem hiding this comment.
As mentioned in the javadoc, we need this to avoid wrapping field type when encoding avro to json. Initially, I had tried subclassing this under org.apache.avro.io package in hudi-common. Bundle validation failed with that appraoch because of illegal access. The constructor in the original code is package-private. So, I had to port over the code with some minor modifications as mentioned in the javadoc of this class. I have already attributed this code in LICENSE file and updated the NOTICE file.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Logs
Today we write the commit metadata for most of the actions as avro byte arrays. But, for commit, deltacommit and replacecommits, it is in json. This PR replaces JSON with Avro bytes for all such commit metadata.
Impact
This is a storage format change. We need to make sure that older timeline with json metadata is still readable.
Risk level (write none, low medium or high below)
medium
Documentation Update
Describe any necessary documentation update if there is any new feature, config, or user-facing change
ticket number here and follow the instruction to make
changes to the website.
Contributor's checklist