Skip to content

chore: Add a lock check to CI#2484

Merged
CTTY merged 2 commits into
apache:mainfrom
xanderbailey:xb/ci-check-lock
May 21, 2026
Merged

chore: Add a lock check to CI#2484
CTTY merged 2 commits into
apache:mainfrom
xanderbailey:xb/ci-check-lock

Conversation

@xanderbailey
Copy link
Copy Markdown
Contributor

@xanderbailey xanderbailey commented May 21, 2026

Which issue does this PR close?

We don't currently check in CI that the lock file is up-to-date and that seems wrong to me. Checked that without updating the lock file (currently out of date) that this fails https://github.com/apache/iceberg-rust/actions/runs/26219087517/job/77149052535

This fails with:

note: pass `--verbose` to see 142 unchanged dependencies behind latest
error: the lock file /Users/runner/work/iceberg-rust/iceberg-rust/Cargo.lock needs to be updated but --locked was passed to prevent this
If you want to try to generate the lock file without accessing the network, remove the --locked flag and use --offline instead.
Error: Process completed with exit code 101.
  • Closes #.

What changes are included in this PR?

Are these changes tested?

@xanderbailey xanderbailey changed the title Add a lock check to CI chore: Add a lock check to CI May 21, 2026
Copy link
Copy Markdown
Collaborator

@CTTY CTTY left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@CTTY CTTY merged commit 3ae4017 into apache:main May 21, 2026
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants