Core: Generalize Util::blockLocations#11053
Merged
Merged
Conversation
okumin
force-pushed
the
block-locations-task-group
branch
from
November 4, 2024 03:37
9e43894 to
40fed51
Compare
nastra
reviewed
Dec 3, 2024
| - code: "java.class.removed" | ||
| old: "enum org.apache.iceberg.BaseMetastoreTableOperations.CommitStatus" | ||
| justification: "Removing deprecated code" | ||
| - code: "java.method.parameterTypeChanged" |
Contributor
There was a problem hiding this comment.
unfortunately we can't just break APIs. You would have you create an additional method and deprecate the old one
Contributor
Author
There was a problem hiding this comment.
@nastra
I understand we have to keep the binary compatibility 100%. Is the current style more acceptable? I'm also checking why the CI failed
Contributor
There was a problem hiding this comment.
I've updated the deprecation message but the new version looks much better, thanks
okumin
force-pushed
the
block-locations-task-group
branch
from
December 3, 2024 12:04
40fed51 to
9d75dcc
Compare
nastra
reviewed
Dec 4, 2024
nastra
approved these changes
Dec 4, 2024
Contributor
Author
|
Thanks for reviewing my change. It helps the Hive community |
nastra
pushed a commit
to nastra/iceberg
that referenced
this pull request
Dec 9, 2024
zachdisc
pushed a commit
to zachdisc/iceberg
that referenced
this pull request
Dec 23, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Apache Hive community is trying to implement optimizations, such as Bucket Map Join, using partition transform specs. We presume
Util::blockLocationsshould accept notCombinedScanTaskbutScanTaskGroup<FileScanTask>, which is a more general expression.See also apache/hive#5409