Core: Fix typo in HadoopTableOperations - #11880
Merged
Merged
Conversation
ebyhr
reviewed
Dec 28, 2024
okumin
force-pushed
the
version-hint-typo
branch
from
December 28, 2024 04:02
af0536e to
c07287a
Compare
okumin
commented
Dec 28, 2024
| return maxVersion; | ||
| } catch (IOException io) { | ||
| LOG.warn("Error trying to recover version-hint.txt data for {}", versionHintFile, e); | ||
| LOG.warn("Error trying to recover the latest version number for {}", versionHintFile, io); |
Contributor
Author
There was a problem hiding this comment.
version-hint.txt is not correct. Based on this discussion, I replaced it with a more informative and non-redundant expression, as versionHintFile already includes the filename.
This is the new message.
Error trying to recover the latest version number for file:/var/folders/0n/191xk_2s2_3dbz7t6_jpws100000gn/T/junit-8523266742929144891/metadata/version-hint.text
Additionally, this change would make the message capture io instead of e so that users can quickly identify the direct cause.
Fokko
approved these changes
Dec 28, 2024
ebyhr
approved these changes
Dec 28, 2024
Contributor
Contributor
Author
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
version-hint.txtis incorrect and confusing asversion-hint.textis the valid file name.