From af1dcba67fe6d846e11a9680fb2e3889ceb6b748 Mon Sep 17 00:00:00 2001
From: Yuya Ebihara <ebyhry@gmail.com>
Date: Mon, 13 Apr 2026 14:45:31 +0900
Subject: [PATCH] Build: Ban toLowerCase/toUpperCase without locale

---
 .baseline/checkstyle/checkstyle.xml | 5 +++++
 baseline.gradle                     | 2 ++
 2 files changed, 7 insertions(+)

diff --git a/.baseline/checkstyle/checkstyle.xml b/.baseline/checkstyle/checkstyle.xml
index 943d299b338f..f94848450a9b 100644
--- a/.baseline/checkstyle/checkstyle.xml
+++ b/.baseline/checkstyle/checkstyle.xml
@@ -450,6 +450,11 @@
             <property name="format" value="^\s*(public\s+)?(abstract\s+)?class\s+[A-Za-z0-9]*Test(\s|&lt;)"/>
             <property name="message" value="Test class names should start with 'Test' prefix, not end with 'Test' suffix. Example: 'TestNewFeature' instead of 'NewFeatureTest'"/>
         </module>
+        <module name="RegexpSinglelineJava">
+            <property name="ignoreComments" value="true"/>
+            <property name="format" value="String::to(Lower|Upper)Case"/>
+            <property name="message" value="Use toLowerCase(Locale)/toUpperCase(Locale) instead of no-arg versions or method references. Prefer Locale.ROOT for locale-insensitive operations."/>
+        </module>
         <module name="IllegalToken">
             <property name="tokens" value="LITERAL_ASSERT"/>
         </module>
diff --git a/baseline.gradle b/baseline.gradle
index 4efbd89eda02..6b180effbbbf 100644
--- a/baseline.gradle
+++ b/baseline.gradle
@@ -157,6 +157,8 @@ subprojects {
           '-Xep:Slf4jThrowable:ERROR',
           // Added because it errors out compile, but we need to figure out if we want it
           '-Xep:StrictUnusedVariable:OFF',
+          // This rule doesn't enforce the use of method references. That's handled by checkstyle.
+          '-Xep:StringCaseLocaleUsage:ERROR',
           // Enforce safe string splitting
           '-Xep:StringSplitter:ERROR',
           '-Xep:TypeParameterShadowing:OFF',