Flink: Handle table comments in FlinkSQL#16423
Merged
Merged
Conversation
pvary
reviewed
May 19, 2026
| } | ||
|
|
||
| @TestTemplate | ||
| public void testCreateTableComment() { |
Contributor
There was a problem hiding this comment.
I would create the following tests:
testCreateTableWithTableComment
testAlterTableModifyTableComment
I'm not sure why the alter parameter is here in this test
pvary
reviewed
May 20, 2026
| sql("CREATE TABLE tl(id BIGINT) COMMENT 'table comment'"); | ||
| Map<String, String> properties = Maps.newHashMap(); | ||
| properties.put("comment", "table comment"); | ||
| assertThat(table("tl").properties()).containsAllEntriesOf(properties); |
Contributor
There was a problem hiding this comment.
Suggested change
| assertThat(table("tl").properties()).containsAllEntriesOf(properties); | |
| assertThat(table("tl").properties()).containsEntry(TableProperties.COMMENT, "table comment"); |
And then we don't need the extra Map
pvary
reviewed
May 20, 2026
| // alter table comment | ||
| sql("ALTER TABLE tl SET('comment' = 'new comment')"); | ||
| properties.put("comment", "new comment"); | ||
| assertThat(table("tl").properties()).containsAllEntriesOf(properties); |
pvary
approved these changes
May 21, 2026
pvary
changed the title
Contributor
|
Merged to main. |
pvary
pushed a commit
that referenced
this pull request
May 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This closes #16422.
Summary
testCreateTableComment()toTestFlinkCatalogTableto verify changes