ci: collapse status into finalize_pr, fix cancel hang#3282
Merged
Conversation
`status` aggregated test results and built CI Summary; `finalize_pr` only re-checked status.result and exited 0/1, adding a second runner per PR with no extra signal. ASF branch protection (.asf.yaml) requires context `finalize_pr` as the sole required check on master. Rename `status` -> `finalize_pr` and drop `name: CI Status` so GitHub resolves the context from the job key. Delete the old pass-through. Job-level `if: always()` re-evaluates after cancel-in-progress fires, schedules itself, and waits indefinitely for a runner that never arrives, holding the concurrency lock and blocking the next PR push for tens of minutes. Replace with `!cancelled()` on all aggregator/release jobs (pre-merge finalize_pr, _common.yml summary, publish-docker, docker-manifests, publish, release final aggregator). Step-level `always()` untouched (no phantom-queue risk).
hubcio
force-pushed
the
remove-ci-status-job
branch
from
ce74c1f to
bbb34e7
Compare
hubcio
changed the title
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3282 +/- ##
=========================================
Coverage 73.79% 73.79%
Complexity 943 943
=========================================
Files 1200 1200
Lines 109116 109116
Branches 86006 86023 +17
=========================================
Hits 80524 80524
+ Misses 25866 25847 -19
- Partials 2726 2745 +19
🚀 New features to boost your workflow:
|
krishvishal
approved these changes
May 19, 2026
mmodzelewski
approved these changes
May 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
statusaggregated test results and built CI Summary;finalize_pronly re-checked status.result and exited 0/1,adding a second runner per PR with no extra signal. ASF
branch protection (.asf.yaml) requires context
finalize_pras the sole required check on master. Rename
status->finalize_prand dropname: CI Statusso GitHub resolvesthe context from the job key. Delete the old pass-through.
Job-level
if: always()re-evaluates after cancel-in-progressfires, schedules itself, and waits indefinitely for a runner
that never arrives, holding the concurrency lock and blocking
the next PR push for tens of minutes. Replace with
!cancelled()on all aggregator/release jobs (pre-mergefinalize_pr, _common.yml summary, publish-docker,
docker-manifests, publish, release final aggregator).
Step-level
always()untouched (no phantom-queue risk).