IGNITE-16124 change signature in method deleteAllById in spring data 2.2 #94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikereiche
approved these changes
Jan 12, 2022
ashapkin
requested changes
Jan 14, 2022
...s/spring-data-2.2-ext/src/test/java/org/apache/ignite/springdata/compoundkey/CityKeyExt.java
Show resolved
Hide resolved
...s/spring-data-2.2-ext/src/test/java/org/apache/ignite/springdata/compoundkey/CityKeyExt.java
Show resolved
Hide resolved
...data-2.2-ext/src/test/java/org/apache/ignite/springdata/IgniteSpringDataCompoundKeyTest.java
Show resolved
Hide resolved
ashapkin
requested changes
Jan 14, 2022
...-ext/src/test/java/org/apache/ignite/springdata/IgniteSpringDataCompoundExtendedKeyTest.java
Outdated
Show resolved
Hide resolved
| import java.util.Set; | ||
|
|
||
| /** | ||
| * Test with using conpoud key in spring-data |
There was a problem hiding this comment.
Feels like it should not be just copy-pasted from IgniteSpringDataCompoundKeyTest
- it looks like both classes share a lot with each other, probably it might be worth having a single base class.
There was a problem hiding this comment.
good idea - duplicate code now inherited from IgniteSpringDataCompoundKeyTest
...-ext/src/test/java/org/apache/ignite/springdata/IgniteSpringDataCompoundExtendedKeyTest.java
Outdated
Show resolved
Hide resolved
...s/spring-data-2.2-ext/src/test/java/org/apache/ignite/springdata/compoundkey/CityKeyExt.java
Outdated
Show resolved
Hide resolved
ashapkin
approved these changes
Jan 18, 2022
|
@ashapkin
|
|
how to fix this error ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.