Skip to content
Permalink
Browse files
Revert "Checkbox 'Delete all files in checkout directory before each …
…snapshot dependency build' added (#161)"

This reverts commit 6d9f9a5
  • Loading branch information
glukos committed Jun 25, 2020
1 parent f724478 commit 6fa6ce616c69d846b6473cdedbe4323bebc2ab29
Showing 3 changed files with 8 additions and 16 deletions.
@@ -267,7 +267,6 @@ private void insertTicketStatus(Set<MuteInfo> mutes, Collection<Ticket> tickets,
@Nullable String ticketId,
@Nullable String prNum,
@Nullable String baseBranchForTc,
@Nonnull Boolean cleanSources,
@Nullable ITcBotUserCreds prov) {
String jiraRes = "";

@@ -298,7 +297,7 @@ private void insertTicketStatus(Set<MuteInfo> mutes, Collection<Ticket> tickets,
Set<Integer> buildidsToSync = new HashSet<>();

for (int i = 0; i < suiteIds.length; i++) {
T2<Build, Set<Integer>> objects = teamcity.triggerBuild(suiteIds[i], branchForTc, cleanSources, top != null && top, new HashMap<>(),
T2<Build, Set<Integer>> objects = teamcity.triggerBuild(suiteIds[i], branchForTc, false, top != null && top, new HashMap<>(),
false, "");
buildidsToSync.addAll(objects.get2());
builds[i] = objects.get1();
@@ -83,8 +83,7 @@ public TriggerResult triggerBuilds(
@Nullable @QueryParam("observe") Boolean observe,
@Nullable @QueryParam("ticketId") String ticketId,
@Nullable @QueryParam("prNum") String prNum,
@Nullable @QueryParam("baseBranchForTc") String baseBranchForTc,
@Nonnull @QueryParam("cleanSources") Boolean cleanSources
@Nullable @QueryParam("baseBranchForTc") String baseBranchForTc
) {
ITcBotUserCreds prov = ITcBotUserCreds.get(req);
Injector injector = CtxListener.getInjector(ctx);
@@ -96,7 +95,7 @@ public TriggerResult triggerBuilds(

String jiraRes = injector
.getInstance(TcBotTriggerAndSignOffService.class)
.triggerBuildsAndObserve(srvCodeOrAlias, branchForTc, parentSuiteId, suiteIdList, top, observe, ticketId, prNum, baseBranchForTc, cleanSources, prov);
.triggerBuildsAndObserve(srvCodeOrAlias, branchForTc, parentSuiteId, suiteIdList, top, observe, ticketId, prNum, baseBranchForTc, prov);

return new TriggerResult("Tests started." + (!jiraRes.isEmpty() ? "<br>" + jiraRes : ""));
}
@@ -302,7 +302,7 @@ function showChainCurrentStatusData(chain, settings) {
"\"" + chain.branchName + "\", " +
"\"" + parentSuitId + "\", " +
"\"\", " + // ticket id
"\"" + baseBranchForTc + "\")'>Comment JIRA</button><br>";
"\"" + baseBranchForTc + "\")'>Comment JIRA</button>&nbsp;&nbsp;";

var blockersList = "";

@@ -319,8 +319,6 @@ function showChainCurrentStatusData(chain, settings) {
}
}

res += "<label for='cleanSources'><input id='cleanSources' type='checkbox'>Delete all files in checkout directory before each snapshot dependency build</label><br>"

res += "<button onclick='triggerBuilds(" +
"\"" + srvCodeForTriggering + "\", " +
"\"" + parentSuitId + "\", " +
@@ -330,8 +328,7 @@ function showChainCurrentStatusData(chain, settings) {
"false, " + //observe
"null, " + // ticketId
"\"" + + chain.prNum + "\", " +
"\"" + baseBranchForTc + "\", " +
"document.getElementById(\"cleanSources\").checked" +
"\"" + baseBranchForTc + "\" " +
")'> " +
"Re-run possible blockers</button><br>";

@@ -344,9 +341,7 @@ function showChainCurrentStatusData(chain, settings) {
"false, " + //observe
"null, " + // ticketId
"\"" + chain.prNum + "\", " + //prNum
"\"" + baseBranchForTc + "\", " +
"document.getElementById(\"cleanSources\").checked" +
")'> " +
"\"" + baseBranchForTc + "\")'> " +
"Re-run possible blockers (top queue)</button><br>";
}

@@ -450,7 +445,7 @@ function filterPossibleBlocker(suite) {
return null;
}

function triggerBuilds(tcServerCode, parentSuiteId, suiteIdList, branchName, top, observe, ticketId, prNum, baseBranchForTc, cleanSources) {
function triggerBuilds(tcServerCode, parentSuiteId, suiteIdList, branchName, top, observe, ticketId, prNum, baseBranchForTc) {
var queueAtTop = isDefinedAndFilled(top) && top;
var observeJira = isDefinedAndFilled(observe) && observe;
var suiteIdsNotExists = !isDefinedAndFilled(suiteIdList) || suiteIdList.length === 0;
@@ -515,8 +510,7 @@ function triggerBuilds(tcServerCode, parentSuiteId, suiteIdList, branchName, top
"observe": observeJira,
"ticketId": ticketId,
"prNum": prNum,
"baseBranchForTc": baseBranchForTc,
"cleanSources": cleanSources
"baseBranchForTc": baseBranchForTc
},
success: successDialog,
error: showErrInLoadStatus

0 comments on commit 6fa6ce6

Please sign in to comment.