diff --git a/checkstyle/checkstyle-suppressions.xml b/checkstyle/checkstyle-suppressions.xml new file mode 100644 index 0000000000000..32731694703b0 --- /dev/null +++ b/checkstyle/checkstyle-suppressions.xml @@ -0,0 +1,24 @@ + + + + + + + diff --git a/checkstyle/checkstyle.xml b/checkstyle/checkstyle.xml new file mode 100644 index 0000000000000..58848e25b0fa9 --- /dev/null +++ b/checkstyle/checkstyle.xml @@ -0,0 +1,42 @@ + + + + + + + + + + + + + + + + + + + + + + + + + + diff --git a/examples/src/main/java/org/apache/ignite/examples/ml/genetic/change/OptimizeMakeChangeFitnessFunction.java b/examples/src/main/java/org/apache/ignite/examples/ml/genetic/change/OptimizeMakeChangeFitnessFunction.java index 36b577713aa54..b7c54a311b3e0 100644 --- a/examples/src/main/java/org/apache/ignite/examples/ml/genetic/change/OptimizeMakeChangeFitnessFunction.java +++ b/examples/src/main/java/org/apache/ignite/examples/ml/genetic/change/OptimizeMakeChangeFitnessFunction.java @@ -38,13 +38,8 @@ public OptimizeMakeChangeFitnessFunction(int targetAmount) { this.targetAmount = targetAmount; } - /** - * Calculate fitness. - * - * @param genes List of genes. - * @return Fitness value. - */ - public double evaluate(List genes) { + /** {@inheritDoc} */ + @Override public double evaluate(List genes) { int changeAmount = getAmountOfChange(genes); int totalCoins = getTotalNumberOfCoins(genes); int changeDifference = Math.abs(targetAmount - changeAmount); diff --git a/examples/src/main/java/org/apache/ignite/examples/ml/genetic/change/OptimizeMakeChangeTerminateCriteria.java b/examples/src/main/java/org/apache/ignite/examples/ml/genetic/change/OptimizeMakeChangeTerminateCriteria.java index 2d65d3f3c600f..f08f80e746d7c 100644 --- a/examples/src/main/java/org/apache/ignite/examples/ml/genetic/change/OptimizeMakeChangeTerminateCriteria.java +++ b/examples/src/main/java/org/apache/ignite/examples/ml/genetic/change/OptimizeMakeChangeTerminateCriteria.java @@ -46,15 +46,8 @@ public class OptimizeMakeChangeTerminateCriteria implements ITerminateCriteria { this.logConsumer = logConsumer; } - /** - * Check whether termination condition is met. - * - * @param fittestChromosome Most fit chromosome at for the nth generation. - * @param averageFitnessScore Average fitness score as of the nth generation. - * @param currGeneration Current generation. - * @return Status whether condition is met or not. - */ - public boolean isTerminationConditionMet(Chromosome fittestChromosome, double averageFitnessScore, + /** {@inheritDoc} */ + @Override public boolean isTerminationConditionMet(Chromosome fittestChromosome, double averageFitnessScore, int currGeneration) { boolean isTerminate = true; diff --git a/examples/src/main/java/org/apache/ignite/examples/ml/genetic/helloworld/HelloWorldFitnessFunction.java b/examples/src/main/java/org/apache/ignite/examples/ml/genetic/helloworld/HelloWorldFitnessFunction.java index a339ff502dd5c..22875fe610759 100644 --- a/examples/src/main/java/org/apache/ignite/examples/ml/genetic/helloworld/HelloWorldFitnessFunction.java +++ b/examples/src/main/java/org/apache/ignite/examples/ml/genetic/helloworld/HelloWorldFitnessFunction.java @@ -33,13 +33,8 @@ * contains 11 characters.

*/ public class HelloWorldFitnessFunction implements IFitnessFunction { - /** - * Calculate fitness. - * - * @param genes List of Genes. - * @return Fitness value. - */ - public double evaluate(List genes) { + /** {@inheritDoc} */ + @Override public double evaluate(List genes) { double matches = 0; for (int i = 0; i < genes.size(); i++) { diff --git a/examples/src/main/java/org/apache/ignite/examples/ml/genetic/helloworld/HelloWorldTerminateCriteria.java b/examples/src/main/java/org/apache/ignite/examples/ml/genetic/helloworld/HelloWorldTerminateCriteria.java index 610d4790a2144..6ee45427d99f5 100644 --- a/examples/src/main/java/org/apache/ignite/examples/ml/genetic/helloworld/HelloWorldTerminateCriteria.java +++ b/examples/src/main/java/org/apache/ignite/examples/ml/genetic/helloworld/HelloWorldTerminateCriteria.java @@ -48,15 +48,8 @@ public class HelloWorldTerminateCriteria implements ITerminateCriteria { this.logConsumer = logConsumer; } - /** - * Check whether termination condition is met. - * - * @param fittestChromosome Most fit chromosome at for the nth generation. - * @param averageFitnessScore Average fitness score as of the nth generation. - * @param currGeneration Current generation. - * @return Status whether condition is met or not. - */ - public boolean isTerminationConditionMet(Chromosome fittestChromosome, double averageFitnessScore, + /** {@inheritDoc} */ + @Override public boolean isTerminationConditionMet(Chromosome fittestChromosome, double averageFitnessScore, int currGeneration) { boolean isTerminate = true; diff --git a/examples/src/main/java/org/apache/ignite/examples/ml/genetic/knapsack/KnapsackFitnessFunction.java b/examples/src/main/java/org/apache/ignite/examples/ml/genetic/knapsack/KnapsackFitnessFunction.java index e7c72b07b5671..5fd21d11f7952 100644 --- a/examples/src/main/java/org/apache/ignite/examples/ml/genetic/knapsack/KnapsackFitnessFunction.java +++ b/examples/src/main/java/org/apache/ignite/examples/ml/genetic/knapsack/KnapsackFitnessFunction.java @@ -31,13 +31,8 @@ * To do this, we total the weights and values of all the genes within a chromosome.

*/ public class KnapsackFitnessFunction implements IFitnessFunction { - /** - * Calculate fitness. - * - * @param genes List of Genes. - * @return Fitness value. - */ - public double evaluate(List genes) { + /** {@inheritDoc} */ + @Override public double evaluate(List genes) { double val = 0; double weight = 0; diff --git a/examples/src/main/java/org/apache/ignite/examples/ml/genetic/knapsack/KnapsackTerminateCriteria.java b/examples/src/main/java/org/apache/ignite/examples/ml/genetic/knapsack/KnapsackTerminateCriteria.java index 09e047ba4f30f..b2337f63dbffa 100644 --- a/examples/src/main/java/org/apache/ignite/examples/ml/genetic/knapsack/KnapsackTerminateCriteria.java +++ b/examples/src/main/java/org/apache/ignite/examples/ml/genetic/knapsack/KnapsackTerminateCriteria.java @@ -48,15 +48,8 @@ public class KnapsackTerminateCriteria implements ITerminateCriteria { this.logConsumer = logConsumer; } - /** - * Check whether termination condition is met. - * - * @param fittestChromosome Most fit chromosome at for the nth generation. - * @param averageFitnessScore Average fitness score as of the nth generation. - * @param currGeneration Current generation. - * @return Status whether condition is met or not. - */ - public boolean isTerminationConditionMet(Chromosome fittestChromosome, double averageFitnessScore, + /** {@inheritDoc} */ + @Override public boolean isTerminationConditionMet(Chromosome fittestChromosome, double averageFitnessScore, int currGeneration) { boolean isTerminate = true; diff --git a/examples/src/main/java/org/apache/ignite/examples/ml/genetic/movie/MovieFitnessFunction.java b/examples/src/main/java/org/apache/ignite/examples/ml/genetic/movie/MovieFitnessFunction.java index 154ce79fdab83..b433790787365 100644 --- a/examples/src/main/java/org/apache/ignite/examples/ml/genetic/movie/MovieFitnessFunction.java +++ b/examples/src/main/java/org/apache/ignite/examples/ml/genetic/movie/MovieFitnessFunction.java @@ -46,13 +46,8 @@ public MovieFitnessFunction(List genres) { this.genres = genres; } - /** - * Calculate fitness score. - * - * @param genes List of Genes. - * @return Fitness score. - */ - public double evaluate(List genes) { + /** {@inheritDoc} */ + @Override public double evaluate(List genes) { double score = 0; List duplicates = new ArrayList<>(); int badSolution = 1; diff --git a/examples/src/main/java/org/apache/ignite/examples/ml/genetic/movie/MovieTerminateCriteria.java b/examples/src/main/java/org/apache/ignite/examples/ml/genetic/movie/MovieTerminateCriteria.java index 68c577f4ecbc5..c8d7d58b92207 100644 --- a/examples/src/main/java/org/apache/ignite/examples/ml/genetic/movie/MovieTerminateCriteria.java +++ b/examples/src/main/java/org/apache/ignite/examples/ml/genetic/movie/MovieTerminateCriteria.java @@ -49,15 +49,8 @@ public class MovieTerminateCriteria implements ITerminateCriteria { } - /** - * Check whether termination condition is met. - * - * @param fittestChromosome Most fit chromosome at for the nth generation. - * @param averageFitnessScore Average fitness score as of the nth generation. - * @param currGeneration Current generation. - * @return Status whether condition is met or not. - */ - public boolean isTerminationConditionMet(Chromosome fittestChromosome, double averageFitnessScore, + /** {@inheritDoc} */ + @Override public boolean isTerminationConditionMet(Chromosome fittestChromosome, double averageFitnessScore, int currGeneration) { boolean isTerminate = true; diff --git a/idea/disabled_plugins.txt b/idea/disabled_plugins.txt deleted file mode 100644 index 1dad326632016..0000000000000 --- a/idea/disabled_plugins.txt +++ /dev/null @@ -1,113 +0,0 @@ -AntSupport -CVS -ClearcasePlugin -Coverage -DevKit -Emma -GenerateToString -Geronimo -Glassfish -Guice -HtmlTools -IdeaServerPlugin -Inspection-JS -InspectionGadgets -IntentionPowerPack -J2ME -JBoss -JSIntentionPowerPack -JSR45Plugin -JSTestDriver Plugin -JUnit -Java EE: Web Services (JAX-WS) -JavaScript -JavaScriptDebugger -Jetty -NodeJS -Osmorc -PerforceDirectPlugin -Pythonid -QuirksMode -Refactor-X -Resin -SourceSafe -StrutsAssistant -Subversion -TFS -TestNG-J -Tomcat -Type Migration -W3Validators -WebServicesPlugin -WebSphere -Weblogic -XPathView -XSLT-Debugger -ZKM -com.android.tools.idea.smali -com.intellij.aop -com.intellij.apacheConfig -com.intellij.appengine -com.intellij.aspectj -com.intellij.beanValidation -com.intellij.cdi -com.intellij.commander -com.intellij.copyright -com.intellij.css -com.intellij.database -com.intellij.diagram -com.intellij.dmserver -com.intellij.dsm -com.intellij.flex -com.intellij.freemarker -com.intellij.guice -com.intellij.gwt -com.intellij.hibernate -com.intellij.java-i18n -com.intellij.java.cucumber -com.intellij.javaee -com.intellij.javaee.view -com.intellij.jsf -com.intellij.jsp -com.intellij.persistence -com.intellij.phing -com.intellij.seam -com.intellij.seam.pageflow -com.intellij.seam.pages -com.intellij.spring -com.intellij.spring.batch -com.intellij.spring.data -com.intellij.spring.integration -com.intellij.spring.osgi -com.intellij.spring.roo -com.intellij.spring.security -com.intellij.spring.webflow -com.intellij.spring.ws -com.intellij.struts2 -com.intellij.tapestry -com.intellij.tasks -com.intellij.tcserver -com.intellij.uiDesigner -com.intellij.velocity -com.jetbrains.jarFinder -com.jetbrains.php -com.jetbrains.php.framework -com.jetbrains.plugins.asp -com.jetbrains.plugins.webDeployment -hg4idea -org.coffeescript -org.intellij.grails -org.intellij.groovy -org.intellij.intelliLang -org.jetbrains.android -org.jetbrains.idea.eclipse -org.jetbrains.idea.maven.ext -org.jetbrains.kotlin -org.jetbrains.plugins.django-db-config -org.jetbrains.plugins.github -org.jetbrains.plugins.gradle -org.jetbrains.plugins.haml -org.jetbrains.plugins.less -org.jetbrains.plugins.ruby -org.jetbrains.plugins.sass -org.jetbrains.plugins.yaml \ No newline at end of file diff --git a/idea/ignite_inspections_teamcity.xml b/idea/ignite_inspections_teamcity.xml deleted file mode 100644 index 10d3c212968c5..0000000000000 --- a/idea/ignite_inspections_teamcity.xml +++ /dev/null @@ -1,1461 +0,0 @@ - - diff --git a/modules/benchmarks/src/main/java/org/apache/ignite/internal/benchmarks/jmh/cache/JmhCacheBenchmark.java b/modules/benchmarks/src/main/java/org/apache/ignite/internal/benchmarks/jmh/cache/JmhCacheBenchmark.java index f55d16cfe5358..3613887587925 100644 --- a/modules/benchmarks/src/main/java/org/apache/ignite/internal/benchmarks/jmh/cache/JmhCacheBenchmark.java +++ b/modules/benchmarks/src/main/java/org/apache/ignite/internal/benchmarks/jmh/cache/JmhCacheBenchmark.java @@ -32,13 +32,8 @@ */ @SuppressWarnings("unchecked") public class JmhCacheBenchmark extends JmhCacheAbstractBenchmark { - /** - * Set up routine. - * - * @throws Exception If failed. - */ - - public void setup() throws Exception { + /** {@inheritDoc} */ + @Override public void setup() throws Exception { super.setup(); IgniteDataStreamer dataLdr = node.dataStreamer(cache.getName()); diff --git a/modules/benchmarks/src/main/java/org/apache/ignite/internal/benchmarks/jmh/notify/JmhWaitStategyBenchmark.java b/modules/benchmarks/src/main/java/org/apache/ignite/internal/benchmarks/jmh/notify/JmhWaitStategyBenchmark.java index b08d98e101b5d..1a620cb4e98f9 100644 --- a/modules/benchmarks/src/main/java/org/apache/ignite/internal/benchmarks/jmh/notify/JmhWaitStategyBenchmark.java +++ b/modules/benchmarks/src/main/java/org/apache/ignite/internal/benchmarks/jmh/notify/JmhWaitStategyBenchmark.java @@ -199,7 +199,7 @@ private static Factory getExpiryPolicyFactoryWithDecreasingRate(fi /** {@inheritDoc} */ @TearDown - public void tearDown() throws Exception { + @Override public void tearDown() throws Exception { Ignition.stopAll(true); } diff --git a/modules/cassandra/serializers/src/test/java/org/apache/ignite/tests/MyPojo.java b/modules/cassandra/serializers/src/test/java/org/apache/ignite/tests/MyPojo.java index f901db31e2724..ea6a93232faf4 100644 --- a/modules/cassandra/serializers/src/test/java/org/apache/ignite/tests/MyPojo.java +++ b/modules/cassandra/serializers/src/test/java/org/apache/ignite/tests/MyPojo.java @@ -63,13 +63,8 @@ public MyPojo(String field1, int field2, long field3, Date field4, MyPojo ref) { this.ref = ref; } - /** - * Compare POJOs. - * - * @param obj POJO to compare with. - * @return {@code true} if equals. - */ - public boolean equals(Object obj) { + /** {@inheritDoc} */ + @Override public boolean equals(Object obj) { if (!(obj instanceof MyPojo)) return false; diff --git a/modules/cassandra/store/src/main/java/org/apache/ignite/cache/store/cassandra/common/CassandraHelper.java b/modules/cassandra/store/src/main/java/org/apache/ignite/cache/store/cassandra/common/CassandraHelper.java index c3981b34f37da..80ea2e4551202 100644 --- a/modules/cassandra/store/src/main/java/org/apache/ignite/cache/store/cassandra/common/CassandraHelper.java +++ b/modules/cassandra/store/src/main/java/org/apache/ignite/cache/store/cassandra/common/CassandraHelper.java @@ -24,7 +24,6 @@ import com.datastax.driver.core.exceptions.InvalidQueryException; import com.datastax.driver.core.exceptions.NoHostAvailableException; import com.datastax.driver.core.exceptions.ReadTimeoutException; - import java.net.InetSocketAddress; import java.util.Map; import java.util.regex.Pattern; @@ -100,7 +99,7 @@ public static boolean isTableAbsenceError(Throwable e) { while (e != null) { if (e instanceof InvalidQueryException && (TABLE_EXIST_ERROR1.matcher(e.getMessage()).matches() || - TABLE_EXIST_ERROR3.matcher(e.getMessage()).matches() || + TABLE_EXIST_ERROR3.matcher(e.getMessage()).matches() || KEYSPACE_EXIST_ERROR1.matcher(e.getMessage()).matches() || KEYSPACE_EXIST_ERROR2.matcher(e.getMessage()).matches())) return true; diff --git a/modules/clients/src/test/java/org/apache/ignite/internal/client/util/ClientConsistentHashSelfTest.java b/modules/clients/src/test/java/org/apache/ignite/internal/client/util/ClientConsistentHashSelfTest.java index 4d7c1ea317f01..67ad9c1825d12 100644 --- a/modules/clients/src/test/java/org/apache/ignite/internal/client/util/ClientConsistentHashSelfTest.java +++ b/modules/clients/src/test/java/org/apache/ignite/internal/client/util/ClientConsistentHashSelfTest.java @@ -104,8 +104,8 @@ public void testTreeSetRestrictions() throws Exception { try { // Add several objects with the same hash without neither natural ordering nor comparator. - hash.addNode(new Object() { public int hashCode() { return 0; } }, 1); - hash.addNode(new Object() { public int hashCode() { return 0; } }, 1); + hash.addNode(new Object() { @Override public int hashCode() { return 0; } }, 1); + hash.addNode(new Object() { @Override public int hashCode() { return 0; } }, 1); fail("Expects failed due to internal TreeSet requires comparator or natural ordering."); } @@ -122,8 +122,8 @@ public void testTreeSetRestrictions() throws Exception { }, null); // Add several objects with the same hash into consistent hash with explicit comparator. - hash.addNode(new Object() { public int hashCode() { return 0; } }, 1); - hash.addNode(new Object() { public int hashCode() { return 0; } }, 1); + hash.addNode(new Object() { @Override public int hashCode() { return 0; } }, 1); + hash.addNode(new Object() { @Override public int hashCode() { return 0; } }, 1); info("Expected pass due to internal TreeSet has explicit comparator."); } diff --git a/modules/clients/src/test/java/org/apache/ignite/internal/processors/rest/TestBinaryClient.java b/modules/clients/src/test/java/org/apache/ignite/internal/processors/rest/TestBinaryClient.java index 49ea1ce82af94..605cfd0764631 100644 --- a/modules/clients/src/test/java/org/apache/ignite/internal/processors/rest/TestBinaryClient.java +++ b/modules/clients/src/test/java/org/apache/ignite/internal/processors/rest/TestBinaryClient.java @@ -225,7 +225,7 @@ final class TestBinaryClient { rdr.start(); } - /** {@inheritDoc} */ + /** */ public void shutdown() throws IgniteCheckedException { try { if (rdr != null) { diff --git a/modules/clients/src/test/java/org/apache/ignite/internal/processors/rest/TestMemcacheClient.java b/modules/clients/src/test/java/org/apache/ignite/internal/processors/rest/TestMemcacheClient.java index adf1c50007b43..b6f572489a68c 100644 --- a/modules/clients/src/test/java/org/apache/ignite/internal/processors/rest/TestMemcacheClient.java +++ b/modules/clients/src/test/java/org/apache/ignite/internal/processors/rest/TestMemcacheClient.java @@ -248,7 +248,7 @@ else if (i >= HDR_LEN + extrasLength + keyLength && i < HDR_LEN + totalLength) { rdr.start(); } - /** {@inheritDoc} */ + /** */ public void shutdown() throws IgniteCheckedException { try { if (rdr != null) { diff --git a/modules/clients/src/test/java/org/apache/ignite/internal/processors/rest/protocols/tcp/redis/RedisCommonAbstractTest.java b/modules/clients/src/test/java/org/apache/ignite/internal/processors/rest/protocols/tcp/redis/RedisCommonAbstractTest.java index 241e239d08411..6f0b0f615acf5 100644 --- a/modules/clients/src/test/java/org/apache/ignite/internal/processors/rest/protocols/tcp/redis/RedisCommonAbstractTest.java +++ b/modules/clients/src/test/java/org/apache/ignite/internal/processors/rest/protocols/tcp/redis/RedisCommonAbstractTest.java @@ -100,7 +100,7 @@ public class RedisCommonAbstractTest extends GridCommonAbstractTest { return grid(0).cache(DFLT_CACHE_NAME); } - /** {@inheritDoc} */ + /** */ protected int gridCount() { return GRID_CNT; } diff --git a/modules/core/src/main/java/org/apache/ignite/internal/IgniteKernal.java b/modules/core/src/main/java/org/apache/ignite/internal/IgniteKernal.java index 42a33d0cf9629..f09e8589d669d 100644 --- a/modules/core/src/main/java/org/apache/ignite/internal/IgniteKernal.java +++ b/modules/core/src/main/java/org/apache/ignite/internal/IgniteKernal.java @@ -147,7 +147,6 @@ import org.apache.ignite.internal.processors.job.GridJobProcessor; import org.apache.ignite.internal.processors.jobmetrics.GridJobMetricsProcessor; import org.apache.ignite.internal.processors.marshaller.GridMarshallerMappingProcessor; -import org.apache.ignite.internal.processors.metastorage.DistributedMetaStorage; import org.apache.ignite.internal.processors.metastorage.persistence.DistributedMetaStorageImpl; import org.apache.ignite.internal.processors.nodevalidation.DiscoveryNodeValidationProcessor; import org.apache.ignite.internal.processors.nodevalidation.OsDiscoveryNodeValidationProcessor; diff --git a/modules/core/src/main/java/org/apache/ignite/internal/client/GridClientPartitionAffinity.java b/modules/core/src/main/java/org/apache/ignite/internal/client/GridClientPartitionAffinity.java index 36120d8325f7a..882999a1f4e37 100644 --- a/modules/core/src/main/java/org/apache/ignite/internal/client/GridClientPartitionAffinity.java +++ b/modules/core/src/main/java/org/apache/ignite/internal/client/GridClientPartitionAffinity.java @@ -247,7 +247,7 @@ public GridClientPartitionAffinity setBackupFilter(GridClientPredicate bac return lookup.get(nodeInfo); } - /** {@inheritDoc} */ + /** */ private int partition(Object key) { return Math.abs(key.hashCode() % getPartitions()); } diff --git a/modules/core/src/main/java/org/apache/ignite/internal/cluster/IgniteClusterImpl.java b/modules/core/src/main/java/org/apache/ignite/internal/cluster/IgniteClusterImpl.java index a8a8d5e957859..a5e1b12238ebe 100644 --- a/modules/core/src/main/java/org/apache/ignite/internal/cluster/IgniteClusterImpl.java +++ b/modules/core/src/main/java/org/apache/ignite/internal/cluster/IgniteClusterImpl.java @@ -44,8 +44,6 @@ import org.apache.ignite.cluster.ClusterNode; import org.apache.ignite.cluster.ClusterStartNodeResult; import org.apache.ignite.configuration.IgniteConfiguration; -import org.apache.ignite.events.ClusterActivationEvent; -import org.apache.ignite.events.EventType; import org.apache.ignite.internal.GridKernalContext; import org.apache.ignite.internal.IgniteComponentType; import org.apache.ignite.internal.IgniteInternalFuture; @@ -71,7 +69,6 @@ import org.apache.ignite.lang.IgniteProductVersion; import org.jetbrains.annotations.Nullable; -import static org.apache.ignite.IgniteSystemProperties.getBoolean; import static org.apache.ignite.internal.IgniteNodeAttributes.ATTR_IPS; import static org.apache.ignite.internal.IgniteNodeAttributes.ATTR_MACS; import static org.apache.ignite.internal.util.nodestart.IgniteNodeStartUtils.parseFile; diff --git a/modules/core/src/main/java/org/apache/ignite/internal/commandline/CommandHandler.java b/modules/core/src/main/java/org/apache/ignite/internal/commandline/CommandHandler.java index 2b04bc7391b9f..32bb062b4cd81 100644 --- a/modules/core/src/main/java/org/apache/ignite/internal/commandline/CommandHandler.java +++ b/modules/core/src/main/java/org/apache/ignite/internal/commandline/CommandHandler.java @@ -55,7 +55,6 @@ import org.apache.ignite.internal.client.GridClientHandshakeException; import org.apache.ignite.internal.client.GridClientNode; import org.apache.ignite.internal.client.GridServerUnreachableException; -import org.apache.ignite.internal.client.impl.GridClientImpl; import org.apache.ignite.internal.client.impl.connection.GridClientConnectionResetException; import org.apache.ignite.internal.client.ssl.GridSslBasicContextFactory; import org.apache.ignite.internal.commandline.argument.CommandArgUtils; diff --git a/modules/core/src/main/java/org/apache/ignite/internal/managers/discovery/ClusterMetricsImpl.java b/modules/core/src/main/java/org/apache/ignite/internal/managers/discovery/ClusterMetricsImpl.java index 5d8138a3b3b54..6525e650b644c 100644 --- a/modules/core/src/main/java/org/apache/ignite/internal/managers/discovery/ClusterMetricsImpl.java +++ b/modules/core/src/main/java/org/apache/ignite/internal/managers/discovery/ClusterMetricsImpl.java @@ -18,7 +18,6 @@ package org.apache.ignite.internal.managers.discovery; import java.util.Collection; -import java.util.concurrent.Future; import java.util.concurrent.TimeUnit; import org.apache.ignite.cluster.ClusterMetrics; import org.apache.ignite.internal.GridKernalContext; diff --git a/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/GridCacheAdapter.java b/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/GridCacheAdapter.java index 7058733442395..7db51a5f9e52f 100644 --- a/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/GridCacheAdapter.java +++ b/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/GridCacheAdapter.java @@ -89,7 +89,6 @@ import org.apache.ignite.internal.processors.cache.distributed.IgniteExternalizableExpiryPolicy; import org.apache.ignite.internal.processors.cache.distributed.dht.GridDhtCacheAdapter; import org.apache.ignite.internal.processors.cache.distributed.dht.GridDhtTopologyFuture; -import org.apache.ignite.internal.processors.cache.distributed.dht.GridDhtTxLocalAdapter; import org.apache.ignite.internal.processors.cache.distributed.dht.topology.GridDhtInvalidPartitionException; import org.apache.ignite.internal.processors.cache.distributed.dht.topology.GridDhtLocalPartition; import org.apache.ignite.internal.processors.cache.distributed.dht.topology.GridDhtPartitionTopology; diff --git a/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/GridCacheMapEntry.java b/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/GridCacheMapEntry.java index 352ca0c6e662b..5ca9c41f94496 100644 --- a/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/GridCacheMapEntry.java +++ b/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/GridCacheMapEntry.java @@ -701,7 +701,7 @@ protected IgniteBiTuple valueBytes0() { readerArgs); } - /** {@inheritDoc} */ + /** */ @SuppressWarnings({"TooBroadScope"}) private Object innerGet0( GridCacheVersion nextVer, diff --git a/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/IgniteCacheOffheapManagerImpl.java b/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/IgniteCacheOffheapManagerImpl.java index 04443be2cf7d7..a0ebcdc89588e 100644 --- a/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/IgniteCacheOffheapManagerImpl.java +++ b/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/IgniteCacheOffheapManagerImpl.java @@ -36,7 +36,6 @@ import org.apache.ignite.IgniteCheckedException; import org.apache.ignite.IgniteException; import org.apache.ignite.IgniteLogger; -import org.apache.ignite.IgniteSystemProperties; import org.apache.ignite.internal.NodeStoppingException; import org.apache.ignite.internal.pagemem.FullPageId; import org.apache.ignite.internal.pagemem.wal.record.delta.DataPageMvccMarkUpdatedRecord; diff --git a/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/distributed/dht/GridDhtTxAbstractEnlistFuture.java b/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/distributed/dht/GridDhtTxAbstractEnlistFuture.java index d1bd295c64f90..77ca470f387bb 100644 --- a/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/distributed/dht/GridDhtTxAbstractEnlistFuture.java +++ b/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/distributed/dht/GridDhtTxAbstractEnlistFuture.java @@ -52,7 +52,6 @@ import org.apache.ignite.internal.processors.cache.mvcc.MvccCoordinator; import org.apache.ignite.internal.processors.cache.mvcc.MvccSnapshot; import org.apache.ignite.internal.processors.cache.mvcc.MvccUtils; -import org.apache.ignite.internal.processors.cache.mvcc.txlog.TxState; import org.apache.ignite.internal.processors.cache.persistence.CacheDataRowAdapter; import org.apache.ignite.internal.processors.cache.query.IgniteQueryErrorCode; import org.apache.ignite.internal.processors.cache.tree.mvcc.data.MvccDataRow; diff --git a/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/distributed/dht/GridDhtTxPrepareFuture.java b/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/distributed/dht/GridDhtTxPrepareFuture.java index 97a1f03da25db..fb485a551228f 100644 --- a/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/distributed/dht/GridDhtTxPrepareFuture.java +++ b/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/distributed/dht/GridDhtTxPrepareFuture.java @@ -75,7 +75,6 @@ import org.apache.ignite.internal.processors.dr.GridDrType; import org.apache.ignite.internal.processors.timeout.GridTimeoutObjectAdapter; import org.apache.ignite.internal.transactions.IgniteTxOptimisticCheckedException; -import org.apache.ignite.internal.transactions.IgniteTxTimeoutCheckedException; import org.apache.ignite.internal.util.GridLeanSet; import org.apache.ignite.internal.util.future.GridCompoundFuture; import org.apache.ignite.internal.util.future.GridFutureAdapter; diff --git a/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/distributed/dht/atomic/UpdateErrors.java b/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/distributed/dht/atomic/UpdateErrors.java index d1a132fec292b..840f449e973e1 100644 --- a/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/distributed/dht/atomic/UpdateErrors.java +++ b/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/distributed/dht/atomic/UpdateErrors.java @@ -126,7 +126,7 @@ void addFailedKeys(Collection keys, Throwable e) { err.addSuppressed(e); } - /** {@inheritDoc} */ + /** */ void prepareMarshal(GridCacheMessage msg, GridCacheContext cctx) throws IgniteCheckedException { msg.prepareMarshalCacheObjects(failedKeys, cctx); @@ -134,7 +134,7 @@ void prepareMarshal(GridCacheMessage msg, GridCacheContext cctx) throws IgniteCh errBytes = U.marshal(cctx.marshaller(), err); } - /** {@inheritDoc} */ + /** */ void finishUnmarshal(GridCacheMessage msg, GridCacheContext cctx, ClassLoader ldr) throws IgniteCheckedException { msg.finishUnmarshalCacheObjects(failedKeys, cctx, ldr); diff --git a/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/distributed/dht/topology/GridDhtPartitionsStateValidator.java b/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/distributed/dht/topology/GridDhtPartitionsStateValidator.java index 7fca51a67fc27..8bea47420a3be 100644 --- a/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/distributed/dht/topology/GridDhtPartitionsStateValidator.java +++ b/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/distributed/dht/topology/GridDhtPartitionsStateValidator.java @@ -33,7 +33,6 @@ import org.apache.ignite.internal.processors.cache.distributed.dht.preloader.CachePartitionPartialCountersMap; import org.apache.ignite.internal.processors.cache.distributed.dht.preloader.GridDhtPartitionsExchangeFuture; import org.apache.ignite.internal.processors.cache.distributed.dht.preloader.GridDhtPartitionsSingleMessage; -import org.apache.ignite.internal.processors.cache.mvcc.MvccUtils; import org.apache.ignite.internal.util.typedef.internal.SB; import org.apache.ignite.lang.IgniteProductVersion; import org.jetbrains.annotations.Nullable; diff --git a/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/persistence/DbCheckpointListener.java b/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/persistence/DbCheckpointListener.java index 02f90f9b74c47..7c6938e0f4b21 100644 --- a/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/persistence/DbCheckpointListener.java +++ b/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/persistence/DbCheckpointListener.java @@ -19,7 +19,6 @@ import java.util.concurrent.Executor; import org.apache.ignite.IgniteCheckedException; -import org.apache.ignite.internal.processors.cache.persistence.pagemem.CheckpointMetricsTracker; import org.apache.ignite.internal.processors.cache.persistence.partstate.PartitionAllocationMap; import org.jetbrains.annotations.Nullable; diff --git a/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/persistence/GridCacheOffheapManager.java b/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/persistence/GridCacheOffheapManager.java index ab48540f6dfc5..2107d6c52c4a6 100644 --- a/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/persistence/GridCacheOffheapManager.java +++ b/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/persistence/GridCacheOffheapManager.java @@ -184,7 +184,7 @@ public IndexStorage getIndexStorage() { } /** {@inheritDoc} */ - public void beforeCheckpointBegin(Context ctx) throws IgniteCheckedException { + @Override public void beforeCheckpointBegin(Context ctx) throws IgniteCheckedException { if (!ctx.nextSnapshot()) syncMetadata(ctx); } diff --git a/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/persistence/tree/io/DataPageIO.java b/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/persistence/tree/io/DataPageIO.java index f67c89ee598dd..5db54210f1eec 100644 --- a/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/persistence/tree/io/DataPageIO.java +++ b/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/persistence/tree/io/DataPageIO.java @@ -22,7 +22,6 @@ import org.apache.ignite.internal.pagemem.PageUtils; import org.apache.ignite.internal.processors.cache.CacheObject; import org.apache.ignite.internal.processors.cache.mvcc.MvccUtils; -import org.apache.ignite.internal.processors.cache.mvcc.MvccVersion; import org.apache.ignite.internal.processors.cache.persistence.CacheDataRow; import org.apache.ignite.internal.processors.cache.tree.mvcc.data.MvccUpdateResult; import org.apache.ignite.internal.processors.cache.version.GridCacheVersion; diff --git a/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/persistence/wal/FileWriteAheadLogManager.java b/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/persistence/wal/FileWriteAheadLogManager.java index cf83e3a29c16d..06d7cd05ede18 100644 --- a/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/persistence/wal/FileWriteAheadLogManager.java +++ b/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/persistence/wal/FileWriteAheadLogManager.java @@ -30,7 +30,6 @@ import java.nio.ByteBuffer; import java.nio.ByteOrder; import java.nio.channels.ClosedByInterruptException; -import java.nio.channels.FileChannel; import java.nio.file.FileAlreadyExistsException; import java.nio.file.Files; import java.sql.Time; @@ -128,7 +127,6 @@ import org.jetbrains.annotations.Nullable; import static java.nio.file.StandardOpenOption.CREATE; -import static java.nio.file.StandardOpenOption.CREATE_NEW; import static java.nio.file.StandardOpenOption.READ; import static java.nio.file.StandardOpenOption.WRITE; import static org.apache.ignite.IgniteSystemProperties.IGNITE_CHECKPOINT_TRIGGER_ARCHIVE_SIZE_PERCENTAGE; diff --git a/modules/core/src/main/java/org/apache/ignite/internal/processors/cacheobject/NoOpBinary.java b/modules/core/src/main/java/org/apache/ignite/internal/processors/cacheobject/NoOpBinary.java index 32c3be6b74308..28ca35b049164 100644 --- a/modules/core/src/main/java/org/apache/ignite/internal/processors/cacheobject/NoOpBinary.java +++ b/modules/core/src/main/java/org/apache/ignite/internal/processors/cacheobject/NoOpBinary.java @@ -85,7 +85,7 @@ public class NoOpBinary implements IgniteBinary { throw unsupported(); } - /** {@inheritDoc} */ + /** */ private BinaryObjectException unsupported() { return new BinaryObjectException("Binary marshaller is not configured."); } diff --git a/modules/core/src/main/java/org/apache/ignite/internal/processors/platform/PlatformContextImpl.java b/modules/core/src/main/java/org/apache/ignite/internal/processors/platform/PlatformContextImpl.java index af2fa7d0dc00b..0f6f252d38441 100644 --- a/modules/core/src/main/java/org/apache/ignite/internal/processors/platform/PlatformContextImpl.java +++ b/modules/core/src/main/java/org/apache/ignite/internal/processors/platform/PlatformContextImpl.java @@ -67,7 +67,6 @@ import org.apache.ignite.internal.processors.platform.message.PlatformMessageFilter; import org.apache.ignite.internal.processors.platform.messaging.PlatformMessageFilterImpl; import org.apache.ignite.internal.processors.platform.utils.PlatformUtils; -import org.apache.ignite.lang.IgniteProductVersion; import org.jetbrains.annotations.Nullable; import java.sql.Timestamp; diff --git a/modules/core/src/main/java/org/apache/ignite/spi/discovery/tcp/internal/DiscoveryDataPacket.java b/modules/core/src/main/java/org/apache/ignite/spi/discovery/tcp/internal/DiscoveryDataPacket.java index 1eb08558c5faa..646565eb716d8 100644 --- a/modules/core/src/main/java/org/apache/ignite/spi/discovery/tcp/internal/DiscoveryDataPacket.java +++ b/modules/core/src/main/java/org/apache/ignite/spi/discovery/tcp/internal/DiscoveryDataPacket.java @@ -322,7 +322,7 @@ private boolean isZipped(byte[] value) { * @param b Source of bytes. * @return Made int. */ - static private int makeInt(byte[] b) { + private static int makeInt(byte[] b) { return (((b[3]) << 24) | ((b[2] & 0xff) << 16) | ((b[1] & 0xff) << 8) | diff --git a/modules/core/src/main/java/org/jsr166/ConcurrentLinkedDeque8.java b/modules/core/src/main/java/org/jsr166/ConcurrentLinkedDeque8.java index 9315feca2ef2b..8ee9909fd2381 100644 --- a/modules/core/src/main/java/org/jsr166/ConcurrentLinkedDeque8.java +++ b/modules/core/src/main/java/org/jsr166/ConcurrentLinkedDeque8.java @@ -1143,17 +1143,13 @@ public E peekLast() { return null; } - /** - * @throws NoSuchElementException {@inheritDoc} - */ - public E getFirst() { + /** {@inheritDoc} */ + @Override public E getFirst() { return screenNullResult(peekFirst()); } - /** - * @throws NoSuchElementException {@inheritDoc} - */ - public E getLast() { + /** {@inheritDoc} */ + @Override public E getLast() { return screenNullResult(peekLast()); } @@ -1179,17 +1175,13 @@ public E pollLast() { return null; } - /** - * @throws NoSuchElementException {@inheritDoc} - */ - public E removeFirst() { + /** {@inheritDoc} */ + @Override public E removeFirst() { return screenNullResult(pollFirst()); } - /** - * @throws NoSuchElementException {@inheritDoc} - */ - public E removeLast() { + /**{@inheritDoc} */ + @Override public E removeLast() { return screenNullResult(pollLast()); } diff --git a/modules/core/src/test/java/org/apache/ignite/cache/ResetLostPartitionTest.java b/modules/core/src/test/java/org/apache/ignite/cache/ResetLostPartitionTest.java index bef69a284a493..8d318dc064c1e 100644 --- a/modules/core/src/test/java/org/apache/ignite/cache/ResetLostPartitionTest.java +++ b/modules/core/src/test/java/org/apache/ignite/cache/ResetLostPartitionTest.java @@ -33,9 +33,7 @@ import org.apache.ignite.internal.processors.cache.distributed.dht.topology.GridDhtPartitionTopologyImpl; import org.apache.ignite.internal.util.typedef.internal.CU; import org.apache.ignite.internal.util.typedef.internal.U; -import org.apache.ignite.testframework.MvccFeatureChecker; import org.apache.ignite.testframework.junits.common.GridCommonAbstractTest; -import org.junit.Assume; import org.junit.Test; import static org.apache.ignite.internal.processors.cache.distributed.dht.topology.GridDhtPartitionState.LOST; diff --git a/modules/core/src/test/java/org/apache/ignite/cache/store/jdbc/model/TestJdbcPojoDataSource.java b/modules/core/src/test/java/org/apache/ignite/cache/store/jdbc/model/TestJdbcPojoDataSource.java index 627b4a36fb5b8..a20c08d537828 100644 --- a/modules/core/src/test/java/org/apache/ignite/cache/store/jdbc/model/TestJdbcPojoDataSource.java +++ b/modules/core/src/test/java/org/apache/ignite/cache/store/jdbc/model/TestJdbcPojoDataSource.java @@ -165,12 +165,12 @@ public Logger getParentLogger() throws SQLFeatureNotSupportedException { throw new SQLFeatureNotSupportedException(); } - /** {@inheritDoc} */ + /** */ private Connection createConnection() throws SQLException { return DriverManager.getConnection(url, username, password); } - /** {@inheritDoc} */ + /** */ private class ConnectionHolder implements Connection { /** */ private Connection conn; @@ -192,8 +192,7 @@ else if (System.currentTimeMillis() - lastAccessTs > idleCheckTimeout && !conn.i } /** {@inheritDoc} */ - @Override - public void close() throws SQLException { + @Override public void close() throws SQLException { if (!perThreadMode) conn.close(); } diff --git a/modules/core/src/test/java/org/apache/ignite/internal/IgniteClientReconnectAbstractTest.java b/modules/core/src/test/java/org/apache/ignite/internal/IgniteClientReconnectAbstractTest.java index 892757b1702c6..efafae5cb2802 100644 --- a/modules/core/src/test/java/org/apache/ignite/internal/IgniteClientReconnectAbstractTest.java +++ b/modules/core/src/test/java/org/apache/ignite/internal/IgniteClientReconnectAbstractTest.java @@ -34,7 +34,6 @@ import org.apache.ignite.IgniteClientDisconnectedException; import org.apache.ignite.IgniteException; import org.apache.ignite.IgniteLogger; -import org.apache.ignite.IgniteSystemProperties; import org.apache.ignite.cluster.ClusterNode; import org.apache.ignite.configuration.IgniteConfiguration; import org.apache.ignite.events.Event; diff --git a/modules/core/src/test/java/org/apache/ignite/internal/managers/deployment/GridDeploymentMessageCountSelfTest.java b/modules/core/src/test/java/org/apache/ignite/internal/managers/deployment/GridDeploymentMessageCountSelfTest.java index f07dd81584db8..3cb7d3a1797f4 100644 --- a/modules/core/src/test/java/org/apache/ignite/internal/managers/deployment/GridDeploymentMessageCountSelfTest.java +++ b/modules/core/src/test/java/org/apache/ignite/internal/managers/deployment/GridDeploymentMessageCountSelfTest.java @@ -68,7 +68,7 @@ public class GridDeploymentMessageCountSelfTest extends GridCommonAbstractTest { return cfg; } - /** {@inheritDoc} */ + /** */ @Test public void testTaskDeployment() throws Exception { ClassLoader ldr = getExternalClassLoader(); diff --git a/modules/core/src/test/java/org/apache/ignite/internal/marshaller/optimized/OptimizedMarshallerSelfTest.java b/modules/core/src/test/java/org/apache/ignite/internal/marshaller/optimized/OptimizedMarshallerSelfTest.java index 1c56854b3b5ad..29e769080e701 100644 --- a/modules/core/src/test/java/org/apache/ignite/internal/marshaller/optimized/OptimizedMarshallerSelfTest.java +++ b/modules/core/src/test/java/org/apache/ignite/internal/marshaller/optimized/OptimizedMarshallerSelfTest.java @@ -138,7 +138,7 @@ private NestedTestObject(String str, int val) { this.val = val; } - /** {@inheritDoc} */ + /** */ private void writeObject(ObjectOutputStream out) throws IOException { try { byte[] arr = marshal(str); @@ -153,7 +153,7 @@ private void writeObject(ObjectOutputStream out) throws IOException { } } - /** {@inheritDoc} */ + /** */ private void readObject(ObjectInputStream in) throws IOException { try { byte[] arr = new byte[in.readInt()]; diff --git a/modules/core/src/test/java/org/apache/ignite/internal/marshaller/optimized/OptimizedObjectStreamSelfTest.java b/modules/core/src/test/java/org/apache/ignite/internal/marshaller/optimized/OptimizedObjectStreamSelfTest.java index ce6412202099e..4b48a2294737a 100644 --- a/modules/core/src/test/java/org/apache/ignite/internal/marshaller/optimized/OptimizedObjectStreamSelfTest.java +++ b/modules/core/src/test/java/org/apache/ignite/internal/marshaller/optimized/OptimizedObjectStreamSelfTest.java @@ -2266,7 +2266,7 @@ public CustomWriteObjectMethodObject(String name) { this.name = name; } - /** {@inheritDoc} */ + /** */ private void writeObject(ObjectOutputStream stream) throws IOException { stream.defaultWriteObject(); diff --git a/modules/core/src/test/java/org/apache/ignite/internal/processors/cache/CacheFutureExceptionSelfTest.java b/modules/core/src/test/java/org/apache/ignite/internal/processors/cache/CacheFutureExceptionSelfTest.java index ad10889213842..1a5fc1c71741f 100644 --- a/modules/core/src/test/java/org/apache/ignite/internal/processors/cache/CacheFutureExceptionSelfTest.java +++ b/modules/core/src/test/java/org/apache/ignite/internal/processors/cache/CacheFutureExceptionSelfTest.java @@ -140,12 +140,12 @@ private void testGet(boolean nearCache, boolean cpyOnRead) throws Exception { * Test class. */ private static class NotSerializableClass implements Serializable { - /** {@inheritDoc}*/ + /** */ private void writeObject(ObjectOutputStream out) throws IOException { out.writeObject(this); } - /** {@inheritDoc}*/ + /** */ private void readObject(ObjectInputStream in) throws IOException, ClassNotFoundException { if (fail) throw new RuntimeException("Deserialization failed."); diff --git a/modules/core/src/test/java/org/apache/ignite/internal/processors/cache/GridCacheLifecycleAwareSelfTest.java b/modules/core/src/test/java/org/apache/ignite/internal/processors/cache/GridCacheLifecycleAwareSelfTest.java index 8a4357d66d29b..d7270e853564c 100644 --- a/modules/core/src/test/java/org/apache/ignite/internal/processors/cache/GridCacheLifecycleAwareSelfTest.java +++ b/modules/core/src/test/java/org/apache/ignite/internal/processors/cache/GridCacheLifecycleAwareSelfTest.java @@ -164,7 +164,7 @@ public TestAffinityFunction() { return res; } - /** {@inheritDoc} */ + /** */ public List nodes(int part, Collection nodes) { return new ArrayList<>(nodes); } diff --git a/modules/core/src/test/java/org/apache/ignite/internal/processors/cache/GridCacheOnCopyFlagAbstractSelfTest.java b/modules/core/src/test/java/org/apache/ignite/internal/processors/cache/GridCacheOnCopyFlagAbstractSelfTest.java index 0af5b13de77ca..b11f172e3e008 100644 --- a/modules/core/src/test/java/org/apache/ignite/internal/processors/cache/GridCacheOnCopyFlagAbstractSelfTest.java +++ b/modules/core/src/test/java/org/apache/ignite/internal/processors/cache/GridCacheOnCopyFlagAbstractSelfTest.java @@ -85,7 +85,7 @@ public abstract class GridCacheOnCopyFlagAbstractSelfTest extends GridCommonAbst return c; } - /** {@inheritDoc} */ + /** */ @SuppressWarnings("unchecked") protected CacheConfiguration cacheConfiguration() throws Exception { CacheConfiguration ccfg = defaultCacheConfiguration(); diff --git a/modules/core/src/test/java/org/apache/ignite/internal/processors/cache/GridCachePutAllFailoverSelfTest.java b/modules/core/src/test/java/org/apache/ignite/internal/processors/cache/GridCachePutAllFailoverSelfTest.java index 3bfc0af5d551b..4935e4b7fa506 100644 --- a/modules/core/src/test/java/org/apache/ignite/internal/processors/cache/GridCachePutAllFailoverSelfTest.java +++ b/modules/core/src/test/java/org/apache/ignite/internal/processors/cache/GridCachePutAllFailoverSelfTest.java @@ -37,7 +37,6 @@ import org.apache.ignite.IgniteCompute; import org.apache.ignite.IgniteException; import org.apache.ignite.IgniteLogger; -import org.apache.ignite.IgniteSystemProperties; import org.apache.ignite.cache.CacheAtomicityMode; import org.apache.ignite.cluster.ClusterNode; import org.apache.ignite.compute.ComputeJobContext; diff --git a/modules/core/src/test/java/org/apache/ignite/internal/processors/cache/IgniteCachePutAllRestartTest.java b/modules/core/src/test/java/org/apache/ignite/internal/processors/cache/IgniteCachePutAllRestartTest.java index 03285bbe269c1..9adafa64fe885 100644 --- a/modules/core/src/test/java/org/apache/ignite/internal/processors/cache/IgniteCachePutAllRestartTest.java +++ b/modules/core/src/test/java/org/apache/ignite/internal/processors/cache/IgniteCachePutAllRestartTest.java @@ -26,7 +26,6 @@ import javax.cache.CacheException; import org.apache.ignite.Ignite; import org.apache.ignite.IgniteCache; -import org.apache.ignite.IgniteSystemProperties; import org.apache.ignite.cache.CacheMode; import org.apache.ignite.configuration.CacheConfiguration; import org.apache.ignite.configuration.IgniteConfiguration; diff --git a/modules/core/src/test/java/org/apache/ignite/internal/processors/cache/IgniteDynamicCacheStartSelfTest.java b/modules/core/src/test/java/org/apache/ignite/internal/processors/cache/IgniteDynamicCacheStartSelfTest.java index b384896d77f92..86e95bdec80b1 100644 --- a/modules/core/src/test/java/org/apache/ignite/internal/processors/cache/IgniteDynamicCacheStartSelfTest.java +++ b/modules/core/src/test/java/org/apache/ignite/internal/processors/cache/IgniteDynamicCacheStartSelfTest.java @@ -873,7 +873,7 @@ public void testNearNodesCache() throws Exception { } } - /** {@inheritDoc} */ + /** */ @Test public void testGetOrCreate() throws Exception { try { @@ -935,7 +935,7 @@ public void testGetOrCreate() throws Exception { } } - /** {@inheritDoc} */ + /** */ @Test public void testGetOrCreateCollection() throws Exception { final int cacheCnt = 3; diff --git a/modules/core/src/test/java/org/apache/ignite/internal/processors/cache/IgniteTxAbstractTest.java b/modules/core/src/test/java/org/apache/ignite/internal/processors/cache/IgniteTxAbstractTest.java index 585b2012a87a6..359277dfb3b20 100644 --- a/modules/core/src/test/java/org/apache/ignite/internal/processors/cache/IgniteTxAbstractTest.java +++ b/modules/core/src/test/java/org/apache/ignite/internal/processors/cache/IgniteTxAbstractTest.java @@ -39,7 +39,6 @@ import org.apache.ignite.transactions.TransactionConcurrency; import org.apache.ignite.transactions.TransactionIsolation; import org.apache.ignite.transactions.TransactionOptimisticException; -import org.apache.ignite.transactions.TransactionSerializationException; import static org.apache.ignite.transactions.TransactionConcurrency.OPTIMISTIC; import static org.apache.ignite.transactions.TransactionIsolation.SERIALIZABLE; @@ -92,7 +91,7 @@ protected IgniteTxAbstractTest() { */ protected abstract boolean printMemoryStats(); - /** {@inheritDoc} */ + /** */ private void debug(String msg) { if (isTestDebug()) info(msg); diff --git a/modules/core/src/test/java/org/apache/ignite/internal/processors/cache/datastructures/IgniteSequenceInternalCleanupTest.java b/modules/core/src/test/java/org/apache/ignite/internal/processors/cache/datastructures/IgniteSequenceInternalCleanupTest.java index 47f4997ca7cf1..8b9d7314d58fc 100644 --- a/modules/core/src/test/java/org/apache/ignite/internal/processors/cache/datastructures/IgniteSequenceInternalCleanupTest.java +++ b/modules/core/src/test/java/org/apache/ignite/internal/processors/cache/datastructures/IgniteSequenceInternalCleanupTest.java @@ -75,7 +75,7 @@ public class IgniteSequenceInternalCleanupTest extends GridCommonAbstractTest { return cfg; } - /** {@inheritDoc} */ + /** */ protected AtomicConfiguration atomicConfiguration() { AtomicConfiguration cfg = new AtomicConfiguration(); diff --git a/modules/core/src/test/java/org/apache/ignite/internal/processors/cache/datastructures/partitioned/GridCachePartitionedQueueCreateMultiNodeSelfTest.java b/modules/core/src/test/java/org/apache/ignite/internal/processors/cache/datastructures/partitioned/GridCachePartitionedQueueCreateMultiNodeSelfTest.java index dd05fe4fba677..5a206105d1deb 100644 --- a/modules/core/src/test/java/org/apache/ignite/internal/processors/cache/datastructures/partitioned/GridCachePartitionedQueueCreateMultiNodeSelfTest.java +++ b/modules/core/src/test/java/org/apache/ignite/internal/processors/cache/datastructures/partitioned/GridCachePartitionedQueueCreateMultiNodeSelfTest.java @@ -88,7 +88,7 @@ public class GridCachePartitionedQueueCreateMultiNodeSelfTest extends IgniteColl return c; } - /** {@inheritDoc} */ + /** */ protected CacheConfiguration cacheConfiguration() { CacheConfiguration cc = defaultCacheConfiguration(); diff --git a/modules/core/src/test/java/org/apache/ignite/internal/processors/cache/distributed/CacheGetInsideLockChangingTopologyTest.java b/modules/core/src/test/java/org/apache/ignite/internal/processors/cache/distributed/CacheGetInsideLockChangingTopologyTest.java index 3b462327ed4f2..0e97aa3588246 100644 --- a/modules/core/src/test/java/org/apache/ignite/internal/processors/cache/distributed/CacheGetInsideLockChangingTopologyTest.java +++ b/modules/core/src/test/java/org/apache/ignite/internal/processors/cache/distributed/CacheGetInsideLockChangingTopologyTest.java @@ -28,7 +28,6 @@ import org.apache.ignite.Ignite; import org.apache.ignite.IgniteCache; import org.apache.ignite.IgniteException; -import org.apache.ignite.IgniteSystemProperties; import org.apache.ignite.cache.CacheAtomicityMode; import org.apache.ignite.configuration.CacheConfiguration; import org.apache.ignite.configuration.IgniteConfiguration; diff --git a/modules/core/src/test/java/org/apache/ignite/internal/processors/cache/distributed/GridCacheModuloAffinityFunction.java b/modules/core/src/test/java/org/apache/ignite/internal/processors/cache/distributed/GridCacheModuloAffinityFunction.java index d6735ba76db8c..869d3953ab198 100644 --- a/modules/core/src/test/java/org/apache/ignite/internal/processors/cache/distributed/GridCacheModuloAffinityFunction.java +++ b/modules/core/src/test/java/org/apache/ignite/internal/processors/cache/distributed/GridCacheModuloAffinityFunction.java @@ -105,7 +105,7 @@ public int backups() { return Collections.unmodifiableList(res); } - /** {@inheritDoc} */ + /** */ public Collection nodes(int part, Collection nodes) { List sorted = new ArrayList<>(nodes); diff --git a/modules/core/src/test/java/org/apache/ignite/internal/processors/cache/distributed/IgniteBinaryMetadataUpdateNodeRestartTest.java b/modules/core/src/test/java/org/apache/ignite/internal/processors/cache/distributed/IgniteBinaryMetadataUpdateNodeRestartTest.java index 78c911908ce66..af3f2c5511efd 100644 --- a/modules/core/src/test/java/org/apache/ignite/internal/processors/cache/distributed/IgniteBinaryMetadataUpdateNodeRestartTest.java +++ b/modules/core/src/test/java/org/apache/ignite/internal/processors/cache/distributed/IgniteBinaryMetadataUpdateNodeRestartTest.java @@ -26,7 +26,6 @@ import org.apache.ignite.Ignite; import org.apache.ignite.IgniteCache; import org.apache.ignite.IgniteException; -import org.apache.ignite.IgniteSystemProperties; import org.apache.ignite.cache.CacheAtomicityMode; import org.apache.ignite.cache.CacheEntryProcessor; import org.apache.ignite.cluster.ClusterTopologyException; diff --git a/modules/core/src/test/java/org/apache/ignite/internal/processors/cache/distributed/IgniteCacheGetRestartTest.java b/modules/core/src/test/java/org/apache/ignite/internal/processors/cache/distributed/IgniteCacheGetRestartTest.java index 701e9f07400a6..39c79b1460d09 100644 --- a/modules/core/src/test/java/org/apache/ignite/internal/processors/cache/distributed/IgniteCacheGetRestartTest.java +++ b/modules/core/src/test/java/org/apache/ignite/internal/processors/cache/distributed/IgniteCacheGetRestartTest.java @@ -26,7 +26,6 @@ import org.apache.ignite.Ignite; import org.apache.ignite.IgniteCache; import org.apache.ignite.IgniteDataStreamer; -import org.apache.ignite.IgniteSystemProperties; import org.apache.ignite.cache.CacheMode; import org.apache.ignite.configuration.CacheConfiguration; import org.apache.ignite.configuration.IgniteConfiguration; diff --git a/modules/core/src/test/java/org/apache/ignite/internal/processors/cache/distributed/IgniteCacheNearRestartRollbackSelfTest.java b/modules/core/src/test/java/org/apache/ignite/internal/processors/cache/distributed/IgniteCacheNearRestartRollbackSelfTest.java index ce9d7c51016ce..6ed725139d4ca 100644 --- a/modules/core/src/test/java/org/apache/ignite/internal/processors/cache/distributed/IgniteCacheNearRestartRollbackSelfTest.java +++ b/modules/core/src/test/java/org/apache/ignite/internal/processors/cache/distributed/IgniteCacheNearRestartRollbackSelfTest.java @@ -31,7 +31,6 @@ import javax.cache.processor.MutableEntry; import org.apache.ignite.Ignite; import org.apache.ignite.IgniteCache; -import org.apache.ignite.IgniteSystemProperties; import org.apache.ignite.cache.CacheAtomicityMode; import org.apache.ignite.cache.CacheRebalanceMode; import org.apache.ignite.cache.CacheWriteSynchronizationMode; diff --git a/modules/core/src/test/java/org/apache/ignite/internal/processors/cache/distributed/dht/IgniteCachePutRetryAbstractSelfTest.java b/modules/core/src/test/java/org/apache/ignite/internal/processors/cache/distributed/dht/IgniteCachePutRetryAbstractSelfTest.java index 725c835668bfd..d035d14ea71b6 100644 --- a/modules/core/src/test/java/org/apache/ignite/internal/processors/cache/distributed/dht/IgniteCachePutRetryAbstractSelfTest.java +++ b/modules/core/src/test/java/org/apache/ignite/internal/processors/cache/distributed/dht/IgniteCachePutRetryAbstractSelfTest.java @@ -34,7 +34,6 @@ import javax.cache.processor.MutableEntry; import org.apache.ignite.Ignite; import org.apache.ignite.IgniteCache; -import org.apache.ignite.IgniteSystemProperties; import org.apache.ignite.cache.CacheAtomicityMode; import org.apache.ignite.cache.CacheEntryProcessor; import org.apache.ignite.cache.CachePartialUpdateException; diff --git a/modules/core/src/test/java/org/apache/ignite/internal/processors/cache/distributed/dht/atomic/GridCacheAtomicInvalidPartitionHandlingSelfTest.java b/modules/core/src/test/java/org/apache/ignite/internal/processors/cache/distributed/dht/atomic/GridCacheAtomicInvalidPartitionHandlingSelfTest.java index b2931c7091454..e4603be5e0c7f 100644 --- a/modules/core/src/test/java/org/apache/ignite/internal/processors/cache/distributed/dht/atomic/GridCacheAtomicInvalidPartitionHandlingSelfTest.java +++ b/modules/core/src/test/java/org/apache/ignite/internal/processors/cache/distributed/dht/atomic/GridCacheAtomicInvalidPartitionHandlingSelfTest.java @@ -91,7 +91,7 @@ public class GridCacheAtomicInvalidPartitionHandlingSelfTest extends GridCommonA return cfg; } - /** {@inheritDoc} */ + /** */ protected CacheConfiguration cacheConfiguration() { CacheConfiguration ccfg = new CacheConfiguration(DEFAULT_CACHE_NAME); diff --git a/modules/core/src/test/java/org/apache/ignite/internal/processors/cache/distributed/near/GridCacheNearMetricsSelfTest.java b/modules/core/src/test/java/org/apache/ignite/internal/processors/cache/distributed/near/GridCacheNearMetricsSelfTest.java index d16a7fce11395..0f36fbc279e00 100644 --- a/modules/core/src/test/java/org/apache/ignite/internal/processors/cache/distributed/near/GridCacheNearMetricsSelfTest.java +++ b/modules/core/src/test/java/org/apache/ignite/internal/processors/cache/distributed/near/GridCacheNearMetricsSelfTest.java @@ -51,7 +51,7 @@ public class GridCacheNearMetricsSelfTest extends GridCacheAbstractSelfTest { return false; } - /** {@inheritDoc} */ + /** */ protected boolean perEntryMetricsEnabled() { return true; } diff --git a/modules/core/src/test/java/org/apache/ignite/internal/processors/cache/distributed/rebalancing/GridCacheRebalancingUnmarshallingFailedSelfTest.java b/modules/core/src/test/java/org/apache/ignite/internal/processors/cache/distributed/rebalancing/GridCacheRebalancingUnmarshallingFailedSelfTest.java index 81cfaad7193e5..567773e788906 100644 --- a/modules/core/src/test/java/org/apache/ignite/internal/processors/cache/distributed/rebalancing/GridCacheRebalancingUnmarshallingFailedSelfTest.java +++ b/modules/core/src/test/java/org/apache/ignite/internal/processors/cache/distributed/rebalancing/GridCacheRebalancingUnmarshallingFailedSelfTest.java @@ -32,7 +32,6 @@ import org.apache.ignite.internal.marshaller.optimized.OptimizedMarshaller; import org.apache.ignite.marshaller.Marshaller; import org.apache.ignite.marshaller.jdk.JdkMarshaller; -import org.apache.ignite.testframework.config.GridTestProperties; import org.apache.ignite.testframework.junits.common.GridCommonAbstractTest; import org.apache.ignite.thread.IgniteThread; import org.junit.Test; diff --git a/modules/core/src/test/java/org/apache/ignite/internal/processors/cache/persistence/IgnitePdsCacheStartStopWithFreqCheckpointTest.java b/modules/core/src/test/java/org/apache/ignite/internal/processors/cache/persistence/IgnitePdsCacheStartStopWithFreqCheckpointTest.java index 382bb2ed510b0..0843ce3406c32 100644 --- a/modules/core/src/test/java/org/apache/ignite/internal/processors/cache/persistence/IgnitePdsCacheStartStopWithFreqCheckpointTest.java +++ b/modules/core/src/test/java/org/apache/ignite/internal/processors/cache/persistence/IgnitePdsCacheStartStopWithFreqCheckpointTest.java @@ -79,7 +79,7 @@ public class IgnitePdsCacheStartStopWithFreqCheckpointTest extends GridCommonAbs return cfg; } - /** {@inheritDoc} */ + /** */ private CacheConfiguration cacheConfiguration(int cacheIdx) { CacheConfiguration ccfg = new CacheConfiguration(CACHE_NAME + cacheIdx) .setAtomicityMode(CacheAtomicityMode.TRANSACTIONAL) diff --git a/modules/core/src/test/java/org/apache/ignite/internal/processors/cache/persistence/IgnitePdsContinuousRestartTest.java b/modules/core/src/test/java/org/apache/ignite/internal/processors/cache/persistence/IgnitePdsContinuousRestartTest.java index b52d03d40192d..8b8b3f4243beb 100644 --- a/modules/core/src/test/java/org/apache/ignite/internal/processors/cache/persistence/IgnitePdsContinuousRestartTest.java +++ b/modules/core/src/test/java/org/apache/ignite/internal/processors/cache/persistence/IgnitePdsContinuousRestartTest.java @@ -44,7 +44,6 @@ import org.apache.ignite.testframework.GridTestUtils; import org.apache.ignite.testframework.MvccFeatureChecker; import org.apache.ignite.testframework.junits.common.GridCommonAbstractTest; -import org.junit.Assume; import org.junit.Test; /** diff --git a/modules/core/src/test/java/org/apache/ignite/internal/processors/cache/persistence/pagemem/IgniteThrottlingUnitTest.java b/modules/core/src/test/java/org/apache/ignite/internal/processors/cache/persistence/pagemem/IgniteThrottlingUnitTest.java index 070f3c9783509..c4a26a8c5aba0 100644 --- a/modules/core/src/test/java/org/apache/ignite/internal/processors/cache/persistence/pagemem/IgniteThrottlingUnitTest.java +++ b/modules/core/src/test/java/org/apache/ignite/internal/processors/cache/persistence/pagemem/IgniteThrottlingUnitTest.java @@ -213,7 +213,7 @@ public void enforceThrottleAtTheEndOfCp() { public void tooMuchPagesMarkedDirty() { PagesWriteSpeedBasedThrottle throttle = new PagesWriteSpeedBasedThrottle(pageMemory2g, null, stateChecker, log); - // 363308 350004 348976 10604 + // 363308 350004 348976 10604 long time = throttle.getParkTime(0.75, ((350004 + 348976) / 2), 350004 - 10604, diff --git a/modules/core/src/test/java/org/apache/ignite/internal/processors/cache/persistence/pagemem/PageMemoryLazyAllocationWithPDSTest.java b/modules/core/src/test/java/org/apache/ignite/internal/processors/cache/persistence/pagemem/PageMemoryLazyAllocationWithPDSTest.java index c84928b60f6a3..6763bdc120434 100644 --- a/modules/core/src/test/java/org/apache/ignite/internal/processors/cache/persistence/pagemem/PageMemoryLazyAllocationWithPDSTest.java +++ b/modules/core/src/test/java/org/apache/ignite/internal/processors/cache/persistence/pagemem/PageMemoryLazyAllocationWithPDSTest.java @@ -18,13 +18,10 @@ package org.apache.ignite.internal.processors.cache.persistence.pagemem; import org.apache.ignite.IgniteCache; -import org.apache.ignite.IgniteCheckedException; -import org.apache.ignite.configuration.CacheConfiguration; import org.apache.ignite.configuration.DataRegionConfiguration; import org.apache.ignite.configuration.IgniteConfiguration; import org.apache.ignite.failure.StopNodeFailureHandler; import org.apache.ignite.internal.IgniteEx; -import org.apache.ignite.testframework.GridTestUtils; import org.jetbrains.annotations.NotNull; import org.junit.Ignore; import org.junit.Test; diff --git a/modules/core/src/test/java/org/apache/ignite/internal/processors/cache/persistence/standbycluster/AbstractNodeJoinTemplate.java b/modules/core/src/test/java/org/apache/ignite/internal/processors/cache/persistence/standbycluster/AbstractNodeJoinTemplate.java index 3d24f1b568819..119389f18674c 100644 --- a/modules/core/src/test/java/org/apache/ignite/internal/processors/cache/persistence/standbycluster/AbstractNodeJoinTemplate.java +++ b/modules/core/src/test/java/org/apache/ignite/internal/processors/cache/persistence/standbycluster/AbstractNodeJoinTemplate.java @@ -300,7 +300,7 @@ protected CacheConfiguration[] allCacheConfigurations() { .setMaxSize(100 * 1024 * 1024))); } - /** {@inheritDoc} */ + /** */ protected IgniteConfiguration persistentCfg(IgniteConfiguration cfg) throws Exception { cfg.setDataStorageConfiguration(new DataStorageConfiguration() .setDefaultDataRegionConfiguration(new DataRegionConfiguration() diff --git a/modules/core/src/test/java/org/apache/ignite/internal/processors/cache/persistence/wal/ExplicitWalDeltaConsistencyTest.java b/modules/core/src/test/java/org/apache/ignite/internal/processors/cache/persistence/wal/ExplicitWalDeltaConsistencyTest.java index 2d6f4d511811d..28668c9531689 100644 --- a/modules/core/src/test/java/org/apache/ignite/internal/processors/cache/persistence/wal/ExplicitWalDeltaConsistencyTest.java +++ b/modules/core/src/test/java/org/apache/ignite/internal/processors/cache/persistence/wal/ExplicitWalDeltaConsistencyTest.java @@ -20,8 +20,6 @@ import org.apache.ignite.IgniteCache; import org.apache.ignite.internal.IgniteEx; import org.apache.ignite.internal.processors.cache.persistence.wal.memtracker.PageMemoryTrackerPluginProvider; -import org.apache.ignite.testframework.MvccFeatureChecker; -import org.junit.Assume; import org.junit.Test; /** diff --git a/modules/core/src/test/java/org/apache/ignite/internal/processors/igfs/IgfsCacheSelfTest.java b/modules/core/src/test/java/org/apache/ignite/internal/processors/igfs/IgfsCacheSelfTest.java index a54d3adca845c..e837972d10a0c 100644 --- a/modules/core/src/test/java/org/apache/ignite/internal/processors/igfs/IgfsCacheSelfTest.java +++ b/modules/core/src/test/java/org/apache/ignite/internal/processors/igfs/IgfsCacheSelfTest.java @@ -69,7 +69,7 @@ public class IgfsCacheSelfTest extends IgfsCommonAbstractTest { return cfg; } - /** {@inheritDoc} */ + /** */ protected CacheConfiguration cacheConfiguration(@NotNull String cacheName) { CacheConfiguration cacheCfg = defaultCacheConfiguration(); diff --git a/modules/core/src/test/java/org/apache/ignite/internal/processors/igfs/IgfsDataManagerSelfTest.java b/modules/core/src/test/java/org/apache/ignite/internal/processors/igfs/IgfsDataManagerSelfTest.java index bce4ff852f96f..651b9baf33415 100644 --- a/modules/core/src/test/java/org/apache/ignite/internal/processors/igfs/IgfsDataManagerSelfTest.java +++ b/modules/core/src/test/java/org/apache/ignite/internal/processors/igfs/IgfsDataManagerSelfTest.java @@ -98,7 +98,7 @@ public class IgfsDataManagerSelfTest extends IgfsCommonAbstractTest { return cfg; } - /** {@inheritDoc} */ + /** */ protected CacheConfiguration cacheConfiguration(@NotNull String cacheName) { CacheConfiguration cacheCfg = defaultCacheConfiguration(); diff --git a/modules/core/src/test/java/org/apache/ignite/internal/processors/igfs/IgfsMetaManagerSelfTest.java b/modules/core/src/test/java/org/apache/ignite/internal/processors/igfs/IgfsMetaManagerSelfTest.java index 5a41e78d137a8..f8149a1ba56b9 100644 --- a/modules/core/src/test/java/org/apache/ignite/internal/processors/igfs/IgfsMetaManagerSelfTest.java +++ b/modules/core/src/test/java/org/apache/ignite/internal/processors/igfs/IgfsMetaManagerSelfTest.java @@ -83,7 +83,7 @@ public class IgfsMetaManagerSelfTest extends IgfsCommonAbstractTest { return cfg; } - /** {@inheritDoc} */ + /** */ protected CacheConfiguration cacheConfiguration(@NotNull String cacheName) { CacheConfiguration cacheCfg = defaultCacheConfiguration(); diff --git a/modules/core/src/test/java/org/apache/ignite/internal/processors/igfs/IgfsOneClientNodeTest.java b/modules/core/src/test/java/org/apache/ignite/internal/processors/igfs/IgfsOneClientNodeTest.java index d3fe71cb37583..11c632b131345 100644 --- a/modules/core/src/test/java/org/apache/ignite/internal/processors/igfs/IgfsOneClientNodeTest.java +++ b/modules/core/src/test/java/org/apache/ignite/internal/processors/igfs/IgfsOneClientNodeTest.java @@ -65,7 +65,7 @@ public class IgfsOneClientNodeTest extends GridCommonAbstractTest { return cfg; } - /** {@inheritDoc} */ + /** */ protected CacheConfiguration cacheConfiguration(@NotNull String cacheName) { CacheConfiguration cacheCfg = defaultCacheConfiguration(); diff --git a/modules/core/src/test/java/org/apache/ignite/internal/processors/igfs/IgfsProcessorSelfTest.java b/modules/core/src/test/java/org/apache/ignite/internal/processors/igfs/IgfsProcessorSelfTest.java index 623faddbcc84f..f39f6b817921b 100644 --- a/modules/core/src/test/java/org/apache/ignite/internal/processors/igfs/IgfsProcessorSelfTest.java +++ b/modules/core/src/test/java/org/apache/ignite/internal/processors/igfs/IgfsProcessorSelfTest.java @@ -119,7 +119,7 @@ public class IgfsProcessorSelfTest extends IgfsCommonAbstractTest { return cfg; } - /** {@inheritDoc} */ + /** */ protected CacheConfiguration cacheConfiguration(@NotNull String cacheName) { CacheConfiguration cacheCfg = defaultCacheConfiguration(); diff --git a/modules/core/src/test/java/org/apache/ignite/internal/processors/igfs/IgfsStreamsSelfTest.java b/modules/core/src/test/java/org/apache/ignite/internal/processors/igfs/IgfsStreamsSelfTest.java index 31d2f77f5620e..ede1b80d56bdd 100644 --- a/modules/core/src/test/java/org/apache/ignite/internal/processors/igfs/IgfsStreamsSelfTest.java +++ b/modules/core/src/test/java/org/apache/ignite/internal/processors/igfs/IgfsStreamsSelfTest.java @@ -120,7 +120,7 @@ public class IgfsStreamsSelfTest extends IgfsCommonAbstractTest { return cfg; } - /** {@inheritDoc} */ + /** */ protected CacheConfiguration cacheConfiguration(@NotNull String cacheName) { CacheConfiguration cacheCfg = defaultCacheConfiguration(); diff --git a/modules/core/src/test/java/org/apache/ignite/internal/processors/metastorage/DistributedMetaStoragePersistentTest.java b/modules/core/src/test/java/org/apache/ignite/internal/processors/metastorage/DistributedMetaStoragePersistentTest.java index 63f9c534325c4..6280c4b3d2ada 100644 --- a/modules/core/src/test/java/org/apache/ignite/internal/processors/metastorage/DistributedMetaStoragePersistentTest.java +++ b/modules/core/src/test/java/org/apache/ignite/internal/processors/metastorage/DistributedMetaStoragePersistentTest.java @@ -21,11 +21,7 @@ import java.util.ArrayList; import java.util.List; import java.util.Map; -import java.util.concurrent.ThreadLocalRandom; -import java.util.concurrent.atomic.AtomicBoolean; -import java.util.concurrent.atomic.AtomicInteger; import org.apache.ignite.internal.IgniteEx; -import org.apache.ignite.internal.IgniteInternalFuture; import org.apache.ignite.internal.processors.cache.persistence.IgniteCacheDatabaseSharedManager; import org.apache.ignite.internal.processors.cache.persistence.metastorage.MetaStorage; import org.apache.ignite.internal.processors.metastorage.persistence.DistributedMetaStorageImpl; diff --git a/modules/core/src/test/java/org/apache/ignite/internal/util/GridStartupWithUndefinedIgniteHomeSelfTest.java b/modules/core/src/test/java/org/apache/ignite/internal/util/GridStartupWithUndefinedIgniteHomeSelfTest.java index 4374a908e06ea..75711a6cefb9c 100644 --- a/modules/core/src/test/java/org/apache/ignite/internal/util/GridStartupWithUndefinedIgniteHomeSelfTest.java +++ b/modules/core/src/test/java/org/apache/ignite/internal/util/GridStartupWithUndefinedIgniteHomeSelfTest.java @@ -49,7 +49,7 @@ public class GridStartupWithUndefinedIgniteHomeSelfTest { /** */ private static final int GRID_COUNT = 2; - /** {@inheritDoc} */ + /** */ @After public void tearDown() { // Next grid in the same VM shouldn't use cached values produced by these tests. diff --git a/modules/core/src/test/java/org/apache/ignite/spi/discovery/tcp/IgniteClientConnectTest.java b/modules/core/src/test/java/org/apache/ignite/spi/discovery/tcp/IgniteClientConnectTest.java index 5ae26d23be5cc..d20b3c469ba18 100644 --- a/modules/core/src/test/java/org/apache/ignite/spi/discovery/tcp/IgniteClientConnectTest.java +++ b/modules/core/src/test/java/org/apache/ignite/spi/discovery/tcp/IgniteClientConnectTest.java @@ -30,7 +30,6 @@ import org.apache.ignite.Ignite; import org.apache.ignite.IgniteCache; import org.apache.ignite.IgniteCheckedException; -import org.apache.ignite.IgniteSystemProperties; import org.apache.ignite.cache.CacheMode; import org.apache.ignite.cache.affinity.rendezvous.RendezvousAffinityFunction; import org.apache.ignite.configuration.CacheConfiguration; diff --git a/modules/core/src/test/java/org/apache/ignite/spi/discovery/tcp/TcpDiscoveryNetworkIssuesTest.java b/modules/core/src/test/java/org/apache/ignite/spi/discovery/tcp/TcpDiscoveryNetworkIssuesTest.java index 8191bcaee6db9..dfc15e01687d8 100644 --- a/modules/core/src/test/java/org/apache/ignite/spi/discovery/tcp/TcpDiscoveryNetworkIssuesTest.java +++ b/modules/core/src/test/java/org/apache/ignite/spi/discovery/tcp/TcpDiscoveryNetworkIssuesTest.java @@ -34,7 +34,6 @@ import org.apache.ignite.spi.discovery.tcp.ipfinder.vm.TcpDiscoveryVmIpFinder; import org.apache.ignite.testframework.GridTestUtils; import org.apache.ignite.testframework.junits.common.GridCommonAbstractTest; -import org.junit.After; import org.junit.Test; /** diff --git a/modules/core/src/test/java/org/apache/ignite/spi/discovery/tcp/TcpDiscoverySpiMBeanTest.java b/modules/core/src/test/java/org/apache/ignite/spi/discovery/tcp/TcpDiscoverySpiMBeanTest.java index 522289779271f..8b8d8dec710c4 100644 --- a/modules/core/src/test/java/org/apache/ignite/spi/discovery/tcp/TcpDiscoverySpiMBeanTest.java +++ b/modules/core/src/test/java/org/apache/ignite/spi/discovery/tcp/TcpDiscoverySpiMBeanTest.java @@ -39,7 +39,6 @@ import org.junit.Test; import static java.util.concurrent.TimeUnit.MILLISECONDS; -import static org.apache.ignite.events.EventType.EVT_NODE_FAILED; import static org.apache.ignite.events.EventType.EVT_NODE_SEGMENTED; /** diff --git a/modules/core/src/test/java/org/apache/ignite/testframework/junits/IgniteConfigVariationsAbstractTest.java b/modules/core/src/test/java/org/apache/ignite/testframework/junits/IgniteConfigVariationsAbstractTest.java index 0b81a8fc94bf9..44aa79733977c 100644 --- a/modules/core/src/test/java/org/apache/ignite/testframework/junits/IgniteConfigVariationsAbstractTest.java +++ b/modules/core/src/test/java/org/apache/ignite/testframework/junits/IgniteConfigVariationsAbstractTest.java @@ -222,7 +222,7 @@ private void memoryUsage() { return resCfg; } - /** {@inheritDoc} */ + /** */ protected final int gridCount() { return testsCfg.gridCount(); } diff --git a/modules/core/src/test/java/org/apache/ignite/testframework/junits/JUnit3TestLegacySupport.java b/modules/core/src/test/java/org/apache/ignite/testframework/junits/JUnit3TestLegacySupport.java index a5ded510b9b9a..be3d9bf03610c 100644 --- a/modules/core/src/test/java/org/apache/ignite/testframework/junits/JUnit3TestLegacySupport.java +++ b/modules/core/src/test/java/org/apache/ignite/testframework/junits/JUnit3TestLegacySupport.java @@ -19,7 +19,6 @@ import org.junit.Rule; import org.junit.rules.TestName; -import org.junit.runners.model.Statement; /** * Supports compatibility with old tests that expect specific threading behavior of JUnit 3 TestCase class, diff --git a/modules/core/src/test/java/org/apache/ignite/testsuites/IgniteBinaryObjectsSimpleNameMapperComputeGridTestSuite.java b/modules/core/src/test/java/org/apache/ignite/testsuites/IgniteBinaryObjectsSimpleNameMapperComputeGridTestSuite.java index 2c9bc6ad73652..85a6bbbdb2afe 100644 --- a/modules/core/src/test/java/org/apache/ignite/testsuites/IgniteBinaryObjectsSimpleNameMapperComputeGridTestSuite.java +++ b/modules/core/src/test/java/org/apache/ignite/testsuites/IgniteBinaryObjectsSimpleNameMapperComputeGridTestSuite.java @@ -17,7 +17,6 @@ package org.apache.ignite.testsuites; -import org.apache.ignite.internal.binary.BinaryMarshaller; import org.apache.ignite.testframework.config.GridTestProperties; import org.junit.BeforeClass; import org.junit.runner.RunWith; diff --git a/modules/core/src/test/java/org/apache/ignite/testsuites/IgniteBinarySimpleNameMapperBasicTestSuite.java b/modules/core/src/test/java/org/apache/ignite/testsuites/IgniteBinarySimpleNameMapperBasicTestSuite.java index d66c63fc6afe3..25a492139483e 100644 --- a/modules/core/src/test/java/org/apache/ignite/testsuites/IgniteBinarySimpleNameMapperBasicTestSuite.java +++ b/modules/core/src/test/java/org/apache/ignite/testsuites/IgniteBinarySimpleNameMapperBasicTestSuite.java @@ -17,7 +17,6 @@ package org.apache.ignite.testsuites; -import org.apache.ignite.internal.binary.BinaryMarshaller; import org.apache.ignite.testframework.config.GridTestProperties; import org.junit.BeforeClass; import org.junit.runner.RunWith; diff --git a/modules/core/src/test/java/org/apache/ignite/testsuites/IgniteBinarySimpleNameMapperCacheFullApiTestSuite.java b/modules/core/src/test/java/org/apache/ignite/testsuites/IgniteBinarySimpleNameMapperCacheFullApiTestSuite.java index 453b99946f22f..f56abcb7ff9eb 100644 --- a/modules/core/src/test/java/org/apache/ignite/testsuites/IgniteBinarySimpleNameMapperCacheFullApiTestSuite.java +++ b/modules/core/src/test/java/org/apache/ignite/testsuites/IgniteBinarySimpleNameMapperCacheFullApiTestSuite.java @@ -17,7 +17,6 @@ package org.apache.ignite.testsuites; -import org.apache.ignite.internal.binary.BinaryMarshaller; import org.apache.ignite.testframework.config.GridTestProperties; import org.junit.BeforeClass; import org.junit.runner.RunWith; diff --git a/modules/flink/src/test/java/org/apache/ignite/source/flink/FlinkIgniteSourceSelfTest.java b/modules/flink/src/test/java/org/apache/ignite/source/flink/FlinkIgniteSourceSelfTest.java index 88b16b9af50ef..f59007ed24e07 100644 --- a/modules/flink/src/test/java/org/apache/ignite/source/flink/FlinkIgniteSourceSelfTest.java +++ b/modules/flink/src/test/java/org/apache/ignite/source/flink/FlinkIgniteSourceSelfTest.java @@ -60,7 +60,7 @@ public class FlinkIgniteSourceSelfTest extends GridCommonAbstractTest { /** Ignite Source instance */ private IgniteSource igniteSrc; - /** {@inheritDoc} */ + /** */ @SuppressWarnings("unchecked") @Before public void setUpTest() throws Exception { diff --git a/modules/hadoop/src/main/java/org/apache/ignite/internal/processors/hadoop/HadoopExternalSplit.java b/modules/hadoop/src/main/java/org/apache/ignite/internal/processors/hadoop/HadoopExternalSplit.java index 7db535af8102a..956d3dea563e0 100644 --- a/modules/hadoop/src/main/java/org/apache/ignite/internal/processors/hadoop/HadoopExternalSplit.java +++ b/modules/hadoop/src/main/java/org/apache/ignite/internal/processors/hadoop/HadoopExternalSplit.java @@ -91,7 +91,7 @@ public long offset() { } /** {@inheritDoc} */ - public String toString() { + @Override public String toString() { return S.toString(HadoopExternalSplit.class, this, "hosts", Arrays.toString(hosts)); } } \ No newline at end of file diff --git a/modules/hadoop/src/main/java/org/apache/ignite/internal/processors/hadoop/HadoopSplitWrapper.java b/modules/hadoop/src/main/java/org/apache/ignite/internal/processors/hadoop/HadoopSplitWrapper.java index 5340ad1e9d351..73eae37f8eecf 100644 --- a/modules/hadoop/src/main/java/org/apache/ignite/internal/processors/hadoop/HadoopSplitWrapper.java +++ b/modules/hadoop/src/main/java/org/apache/ignite/internal/processors/hadoop/HadoopSplitWrapper.java @@ -122,7 +122,7 @@ public byte[] bytes() { } /** {@inheritDoc} */ - public String toString() { + @Override public String toString() { return S.toString(HadoopSplitWrapper.class, this, "hosts", Arrays.toString(hosts)); } } \ No newline at end of file diff --git a/modules/hadoop/src/main/java/org/apache/ignite/internal/processors/hadoop/impl/delegate/HadoopFileSystemCounterWriterDelegateImpl.java b/modules/hadoop/src/main/java/org/apache/ignite/internal/processors/hadoop/impl/delegate/HadoopFileSystemCounterWriterDelegateImpl.java index 6b36d26e8df91..2a500e3a36650 100644 --- a/modules/hadoop/src/main/java/org/apache/ignite/internal/processors/hadoop/impl/delegate/HadoopFileSystemCounterWriterDelegateImpl.java +++ b/modules/hadoop/src/main/java/org/apache/ignite/internal/processors/hadoop/impl/delegate/HadoopFileSystemCounterWriterDelegateImpl.java @@ -60,7 +60,7 @@ public HadoopFileSystemCounterWriterDelegateImpl(IgniteHadoopFileSystemCounterWr } /** {@inheritDoc} */ - public void write(HadoopJobEx job, HadoopCounters cntrs) throws IgniteCheckedException { + @Override public void write(HadoopJobEx job, HadoopCounters cntrs) throws IgniteCheckedException { Configuration hadoopCfg = HadoopUtils.safeCreateConfiguration(); final HadoopJobInfo jobInfo = job.info(); diff --git a/modules/hadoop/src/main/java/org/apache/ignite/internal/processors/hadoop/impl/delegate/HadoopIgfsSecondaryFileSystemDelegateImpl.java b/modules/hadoop/src/main/java/org/apache/ignite/internal/processors/hadoop/impl/delegate/HadoopIgfsSecondaryFileSystemDelegateImpl.java index 55d8521bfe48c..51bd08ba4abc6 100644 --- a/modules/hadoop/src/main/java/org/apache/ignite/internal/processors/hadoop/impl/delegate/HadoopIgfsSecondaryFileSystemDelegateImpl.java +++ b/modules/hadoop/src/main/java/org/apache/ignite/internal/processors/hadoop/impl/delegate/HadoopIgfsSecondaryFileSystemDelegateImpl.java @@ -409,12 +409,12 @@ public HadoopIgfsSecondaryFileSystemDelegateImpl(IgniteHadoopIgfsSecondaryFileSy } /** {@inheritDoc} */ - public void start() { + @Override public void start() { factory.start(); } /** {@inheritDoc} */ - public void stop() { + @Override public void stop() { factory.stop(); } diff --git a/modules/hadoop/src/main/java/org/apache/ignite/internal/processors/hadoop/jobtracker/HadoopJobMetadata.java b/modules/hadoop/src/main/java/org/apache/ignite/internal/processors/hadoop/jobtracker/HadoopJobMetadata.java index 1035701727648..e78305acd908d 100644 --- a/modules/hadoop/src/main/java/org/apache/ignite/internal/processors/hadoop/jobtracker/HadoopJobMetadata.java +++ b/modules/hadoop/src/main/java/org/apache/ignite/internal/processors/hadoop/jobtracker/HadoopJobMetadata.java @@ -308,7 +308,7 @@ public int taskNumber(HadoopInputSplit split) { } /** {@inheritDoc} */ - public String toString() { + @Override public String toString() { return S.toString(HadoopJobMetadata.class, this, "pendingMaps", pendingSplits.size(), "pendingReduces", pendingReducers.size(), "failCause", failCause == null ? null : failCause.getClass().getName()); diff --git a/modules/indexing/src/main/java/org/apache/ignite/internal/processors/query/h2/H2CachedStatementKey.java b/modules/indexing/src/main/java/org/apache/ignite/internal/processors/query/h2/H2CachedStatementKey.java index 360c2adda17d9..6653ddd942af0 100644 --- a/modules/indexing/src/main/java/org/apache/ignite/internal/processors/query/h2/H2CachedStatementKey.java +++ b/modules/indexing/src/main/java/org/apache/ignite/internal/processors/query/h2/H2CachedStatementKey.java @@ -18,7 +18,6 @@ package org.apache.ignite.internal.processors.query.h2; import org.apache.ignite.cache.query.SqlFieldsQuery; -import org.apache.ignite.internal.processors.query.h2.dml.UpdatePlanBuilder; import org.apache.ignite.internal.util.typedef.F; import org.apache.ignite.internal.util.typedef.internal.S; diff --git a/modules/indexing/src/main/java/org/apache/ignite/internal/processors/query/h2/dml/DmlArguments.java b/modules/indexing/src/main/java/org/apache/ignite/internal/processors/query/h2/dml/DmlArguments.java index c2405e30105e4..e9ec4bd7a0df1 100644 --- a/modules/indexing/src/main/java/org/apache/ignite/internal/processors/query/h2/dml/DmlArguments.java +++ b/modules/indexing/src/main/java/org/apache/ignite/internal/processors/query/h2/dml/DmlArguments.java @@ -71,7 +71,7 @@ private ConstantArgument(Object val) { } /** {@inheritDoc} */ - public Object get(Object[] params) { + @Override public Object get(Object[] params) { return val; } } diff --git a/modules/indexing/src/main/java/org/apache/ignite/internal/processors/query/h2/sql/GridSqlElement.java b/modules/indexing/src/main/java/org/apache/ignite/internal/processors/query/h2/sql/GridSqlElement.java index 00a8f220a9ab6..20246eee06c9b 100644 --- a/modules/indexing/src/main/java/org/apache/ignite/internal/processors/query/h2/sql/GridSqlElement.java +++ b/modules/indexing/src/main/java/org/apache/ignite/internal/processors/query/h2/sql/GridSqlElement.java @@ -38,10 +38,8 @@ protected GridSqlElement(List children) { this.children = children; } - /** - * @return Optional expression result type (if this is an expression and result type is known). - */ - public GridSqlType resultType() { + /** {@inheritDoc} */ + @Override public GridSqlType resultType() { return resultType; } @@ -87,10 +85,8 @@ public GridSqlElement addChild(GridSqlAst expr) { children.set(idx, child); } - /** - * @return Number of children. - */ - public int size() { + /** {@inheritDoc} */ + @Override public int size() { return children.size(); } diff --git a/modules/indexing/src/test/java/org/apache/ignite/internal/processors/cache/BinarySerializationQuerySelfTest.java b/modules/indexing/src/test/java/org/apache/ignite/internal/processors/cache/BinarySerializationQuerySelfTest.java index 949f5983852bf..0c3a67fde84a0 100644 --- a/modules/indexing/src/test/java/org/apache/ignite/internal/processors/cache/BinarySerializationQuerySelfTest.java +++ b/modules/indexing/src/test/java/org/apache/ignite/internal/processors/cache/BinarySerializationQuerySelfTest.java @@ -406,12 +406,12 @@ public EntityWriteReadObject(int val) { this.val = val; } - /** {@inheritDoc} */ + /** */ private void writeObject(ObjectOutputStream s) throws IOException{ s.writeInt(val); } - /** {@inheritDoc} */ + /** */ private void readObject(ObjectInputStream s) throws IOException, ClassNotFoundException { val = s.readInt(); } diff --git a/modules/indexing/src/test/java/org/apache/ignite/internal/processors/cache/CacheQueryAfterDynamicCacheStartFailureTest.java b/modules/indexing/src/test/java/org/apache/ignite/internal/processors/cache/CacheQueryAfterDynamicCacheStartFailureTest.java index 36184680b5a3c..420115427a5fc 100644 --- a/modules/indexing/src/test/java/org/apache/ignite/internal/processors/cache/CacheQueryAfterDynamicCacheStartFailureTest.java +++ b/modules/indexing/src/test/java/org/apache/ignite/internal/processors/cache/CacheQueryAfterDynamicCacheStartFailureTest.java @@ -1,62 +1,63 @@ -/* - * Licensed to the Apache Software Foundation (ASF) under one or more - * contributor license agreements. See the NOTICE file distributed with - * this work for additional information regarding copyright ownership. - * The ASF licenses this file to You under the Apache License, Version 2.0 - * (the "License"); you may not use this file except in compliance with - * the License. You may obtain a copy of the License at - * - * http://www.apache.org/licenses/LICENSE-2.0 - * - * Unless required by applicable law or agreed to in writing, software - * distributed under the License is distributed on an "AS IS" BASIS, - * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. - * See the License for the specific language governing permissions and - * limitations under the License. - */ - -package org.apache.ignite.internal.processors.cache; - -import java.util.List; -import javax.cache.Cache; -import org.apache.ignite.IgniteCache; -import org.apache.ignite.cache.query.SqlQuery; -import org.apache.ignite.configuration.CacheConfiguration; -import org.apache.ignite.configuration.IgniteConfiguration; - -public class CacheQueryAfterDynamicCacheStartFailureTest extends IgniteAbstractDynamicCacheStartFailTest { - /** {@inheritDoc} */ - @Override protected IgniteConfiguration getConfiguration(String gridName) throws Exception { - IgniteConfiguration cfg = super.getConfiguration(gridName); - - return cfg; - } - - /** {@inheritDoc} */ - @Override protected void beforeTestsStarted() throws Exception { - startGrids(gridCount()); - - awaitPartitionMapExchange(); - } - - /** {@inheritDoc} */ - protected CacheConfiguration createCacheConfiguration(String cacheName) { - CacheConfiguration cfg = new CacheConfiguration() - .setName(cacheName) - .setIndexedTypes(Integer.class, Value.class); - - return cfg; - } - - protected void checkCacheOperations(IgniteCache cache) throws Exception { - super.checkCacheOperations(cache); - - // Check SQL API. - String sql = "fieldVal >= ? and fieldVal <= ?"; - List> res = cache.query( - new SqlQuery(Value.class, sql).setArgs(1, 100)).getAll(); - - assertNotNull(res); - assertEquals(100, res.size()); - } -} +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.ignite.internal.processors.cache; + +import java.util.List; +import javax.cache.Cache; +import org.apache.ignite.IgniteCache; +import org.apache.ignite.cache.query.SqlQuery; +import org.apache.ignite.configuration.CacheConfiguration; +import org.apache.ignite.configuration.IgniteConfiguration; + +public class CacheQueryAfterDynamicCacheStartFailureTest extends IgniteAbstractDynamicCacheStartFailTest { + /** {@inheritDoc} */ + @Override protected IgniteConfiguration getConfiguration(String gridName) throws Exception { + IgniteConfiguration cfg = super.getConfiguration(gridName); + + return cfg; + } + + /** {@inheritDoc} */ + @Override protected void beforeTestsStarted() throws Exception { + startGrids(gridCount()); + + awaitPartitionMapExchange(); + } + + /** {@inheritDoc} */ + @Override protected CacheConfiguration createCacheConfiguration(String cacheName) { + CacheConfiguration cfg = new CacheConfiguration() + .setName(cacheName) + .setIndexedTypes(Integer.class, Value.class); + + return cfg; + } + + /** {@inheritDoc} */ + @Override protected void checkCacheOperations(IgniteCache cache) throws Exception { + super.checkCacheOperations(cache); + + // Check SQL API. + String sql = "fieldVal >= ? and fieldVal <= ?"; + List> res = cache.query( + new SqlQuery(Value.class, sql).setArgs(1, 100)).getAll(); + + assertNotNull(res); + assertEquals(100, res.size()); + } +} diff --git a/modules/indexing/src/test/java/org/apache/ignite/internal/processors/cache/IgniteCacheSqlDmlErrorSelfTest.java b/modules/indexing/src/test/java/org/apache/ignite/internal/processors/cache/IgniteCacheSqlDmlErrorSelfTest.java index 00ea790b31fd7..18ad07035e87e 100644 --- a/modules/indexing/src/test/java/org/apache/ignite/internal/processors/cache/IgniteCacheSqlDmlErrorSelfTest.java +++ b/modules/indexing/src/test/java/org/apache/ignite/internal/processors/cache/IgniteCacheSqlDmlErrorSelfTest.java @@ -28,7 +28,6 @@ import org.apache.ignite.internal.processors.query.h2.dml.UpdatePlanBuilder; import org.apache.ignite.internal.util.typedef.F; import org.apache.ignite.testframework.GridTestUtils; -import org.apache.ignite.testframework.junits.common.GridCommonAbstractTest; import org.junit.Before; import org.junit.Test; diff --git a/modules/indexing/src/test/java/org/apache/ignite/internal/processors/cache/IgniteCacheSqlInsertValidationSelfTest.java b/modules/indexing/src/test/java/org/apache/ignite/internal/processors/cache/IgniteCacheSqlInsertValidationSelfTest.java index 9e58f80c10ec6..4d14d137bf783 100644 --- a/modules/indexing/src/test/java/org/apache/ignite/internal/processors/cache/IgniteCacheSqlInsertValidationSelfTest.java +++ b/modules/indexing/src/test/java/org/apache/ignite/internal/processors/cache/IgniteCacheSqlInsertValidationSelfTest.java @@ -34,7 +34,6 @@ import org.apache.ignite.internal.processors.query.IgniteSQLException; import org.apache.ignite.internal.processors.query.h2.dml.UpdatePlanBuilder; import org.apache.ignite.testframework.GridTestUtils; -import org.apache.ignite.testframework.junits.common.GridCommonAbstractTest; import org.apache.ignite.transactions.TransactionDuplicateKeyException; import org.junit.Test; diff --git a/modules/indexing/src/test/java/org/apache/ignite/internal/processors/cache/index/DynamicColumnsAbstractConcurrentSelfTest.java b/modules/indexing/src/test/java/org/apache/ignite/internal/processors/cache/index/DynamicColumnsAbstractConcurrentSelfTest.java index 691cf5cf10750..90deb48dae242 100644 --- a/modules/indexing/src/test/java/org/apache/ignite/internal/processors/cache/index/DynamicColumnsAbstractConcurrentSelfTest.java +++ b/modules/indexing/src/test/java/org/apache/ignite/internal/processors/cache/index/DynamicColumnsAbstractConcurrentSelfTest.java @@ -30,7 +30,6 @@ import java.util.concurrent.ThreadLocalRandom; import java.util.concurrent.atomic.AtomicBoolean; import java.util.concurrent.atomic.AtomicInteger; -import java.util.concurrent.locks.StampedLock; import javax.cache.Cache; import org.apache.ignite.Ignite; import org.apache.ignite.IgniteCache; diff --git a/modules/indexing/src/test/java/org/apache/ignite/internal/processors/cache/index/DynamicIndexAbstractSelfTest.java b/modules/indexing/src/test/java/org/apache/ignite/internal/processors/cache/index/DynamicIndexAbstractSelfTest.java index 4356383607391..7e97375766845 100644 --- a/modules/indexing/src/test/java/org/apache/ignite/internal/processors/cache/index/DynamicIndexAbstractSelfTest.java +++ b/modules/indexing/src/test/java/org/apache/ignite/internal/processors/cache/index/DynamicIndexAbstractSelfTest.java @@ -119,14 +119,8 @@ protected IgniteConfiguration clientConfiguration(int idx) throws Exception { return commonConfiguration(idx).setClientMode(true); } - /** - * Create common node configuration. - * - * @param idx Index. - * @return Configuration. - * @throws Exception If failed. - */ - protected IgniteConfiguration commonConfiguration(int idx) throws Exception { + /** {@inheritDoc} */ + @Override protected IgniteConfiguration commonConfiguration(int idx) throws Exception { IgniteConfiguration cfg = super.getConfiguration(getTestIgniteInstanceName(idx)); cfg.setFailureHandler(new StopNodeFailureHandler()); diff --git a/modules/indexing/src/test/java/org/apache/ignite/internal/processors/cache/index/StaticCacheDdlTest.java b/modules/indexing/src/test/java/org/apache/ignite/internal/processors/cache/index/StaticCacheDdlTest.java index ad5dc9e3f96a6..dfdf10f81880a 100644 --- a/modules/indexing/src/test/java/org/apache/ignite/internal/processors/cache/index/StaticCacheDdlTest.java +++ b/modules/indexing/src/test/java/org/apache/ignite/internal/processors/cache/index/StaticCacheDdlTest.java @@ -38,7 +38,6 @@ import org.junit.After; import org.junit.Assert; import org.junit.Before; -import org.junit.Ignore; import org.junit.Test; /** diff --git a/modules/indexing/src/test/java/org/apache/ignite/internal/processors/cache/mvcc/CacheMvccReplicatedSqlTxQueriesWithReducerTest.java b/modules/indexing/src/test/java/org/apache/ignite/internal/processors/cache/mvcc/CacheMvccReplicatedSqlTxQueriesWithReducerTest.java index 173c43f126d60..9268c08ca189d 100644 --- a/modules/indexing/src/test/java/org/apache/ignite/internal/processors/cache/mvcc/CacheMvccReplicatedSqlTxQueriesWithReducerTest.java +++ b/modules/indexing/src/test/java/org/apache/ignite/internal/processors/cache/mvcc/CacheMvccReplicatedSqlTxQueriesWithReducerTest.java @@ -24,7 +24,7 @@ /** */ public class CacheMvccReplicatedSqlTxQueriesWithReducerTest extends CacheMvccSqlTxQueriesWithReducerAbstractTest { /** {@inheritDoc} */ - protected CacheMode cacheMode() { + @Override protected CacheMode cacheMode() { return REPLICATED; } } diff --git a/modules/indexing/src/test/java/org/apache/ignite/internal/processors/cache/persistence/db/wal/IgniteWalRecoveryTest.java b/modules/indexing/src/test/java/org/apache/ignite/internal/processors/cache/persistence/db/wal/IgniteWalRecoveryTest.java index 7db5664a76b24..b714c536df430 100644 --- a/modules/indexing/src/test/java/org/apache/ignite/internal/processors/cache/persistence/db/wal/IgniteWalRecoveryTest.java +++ b/modules/indexing/src/test/java/org/apache/ignite/internal/processors/cache/persistence/db/wal/IgniteWalRecoveryTest.java @@ -43,7 +43,6 @@ import org.apache.ignite.IgniteCompute; import org.apache.ignite.IgniteException; import org.apache.ignite.IgniteLogger; -import org.apache.ignite.IgniteSystemProperties; import org.apache.ignite.cache.CacheAtomicityMode; import org.apache.ignite.cache.CacheMode; import org.apache.ignite.cache.CacheRebalanceMode; diff --git a/modules/indexing/src/test/java/org/apache/ignite/internal/processors/query/IgniteQueryDedicatedPoolTest.java b/modules/indexing/src/test/java/org/apache/ignite/internal/processors/query/IgniteQueryDedicatedPoolTest.java index 4cd3faf161919..df0fc7c205e63 100644 --- a/modules/indexing/src/test/java/org/apache/ignite/internal/processors/query/IgniteQueryDedicatedPoolTest.java +++ b/modules/indexing/src/test/java/org/apache/ignite/internal/processors/query/IgniteQueryDedicatedPoolTest.java @@ -36,7 +36,6 @@ import org.apache.ignite.internal.managers.communication.GridIoManager; import org.apache.ignite.internal.managers.communication.GridIoPolicy; import org.apache.ignite.internal.processors.cache.CacheEntryImpl; -import org.apache.ignite.internal.processors.cache.query.GridCacheTwoStepQuery; import org.apache.ignite.internal.util.typedef.F; import org.apache.ignite.lang.IgniteBiPredicate; import org.apache.ignite.spi.IgniteSpiAdapter; diff --git a/modules/indexing/src/test/java/org/apache/ignite/internal/processors/query/KillQueryOnClientDisconnectTest.java b/modules/indexing/src/test/java/org/apache/ignite/internal/processors/query/KillQueryOnClientDisconnectTest.java index e9c2c9d8a12c1..5384acd0c9ff6 100644 --- a/modules/indexing/src/test/java/org/apache/ignite/internal/processors/query/KillQueryOnClientDisconnectTest.java +++ b/modules/indexing/src/test/java/org/apache/ignite/internal/processors/query/KillQueryOnClientDisconnectTest.java @@ -98,7 +98,7 @@ public void before() throws Exception { stmt = conn.createStatement(); } - /** {@inheritDoc} */ + /** */ protected IgniteEx clientNode() { IgniteEx clientNode = grid(1); @@ -107,7 +107,7 @@ protected IgniteEx clientNode() { return clientNode; } - /** {@inheritDoc} */ + /** */ protected IgniteEx serverNode() { IgniteEx srvNode = grid(0); diff --git a/modules/indexing/src/test/java/org/apache/ignite/internal/processors/query/h2/GridIndexRebuildWithMvccEnabledSelfTest.java b/modules/indexing/src/test/java/org/apache/ignite/internal/processors/query/h2/GridIndexRebuildWithMvccEnabledSelfTest.java index 7a9630a20007b..72118433badf6 100644 --- a/modules/indexing/src/test/java/org/apache/ignite/internal/processors/query/h2/GridIndexRebuildWithMvccEnabledSelfTest.java +++ b/modules/indexing/src/test/java/org/apache/ignite/internal/processors/query/h2/GridIndexRebuildWithMvccEnabledSelfTest.java @@ -46,7 +46,7 @@ public class GridIndexRebuildWithMvccEnabledSelfTest extends GridIndexRebuildSel /** {@inheritDoc} */ @Test - public void testIndexRebuild() throws Exception { + @Override public void testIndexRebuild() throws Exception { IgniteEx srv = startServer(); execute(srv, "CREATE TABLE T(k int primary key, v int) WITH \"cache_name=T,wrap_value=false," + @@ -90,7 +90,7 @@ private static void lockVersion(IgniteEx node) throws IgniteCheckedException { } /** {@inheritDoc} */ - protected void checkDataState(IgniteEx srv, boolean afterRebuild) throws IgniteCheckedException { + @Override protected void checkDataState(IgniteEx srv, boolean afterRebuild) throws IgniteCheckedException { IgniteInternalCache icache = srv.cachex(CACHE_NAME); assertNotNull(icache); diff --git a/modules/jta/src/test/java/org/apache/ignite/internal/processors/cache/GridJtaLifecycleAwareSelfTest.java b/modules/jta/src/test/java/org/apache/ignite/internal/processors/cache/GridJtaLifecycleAwareSelfTest.java index 914e9092ad198..d3337eb143792 100644 --- a/modules/jta/src/test/java/org/apache/ignite/internal/processors/cache/GridJtaLifecycleAwareSelfTest.java +++ b/modules/jta/src/test/java/org/apache/ignite/internal/processors/cache/GridJtaLifecycleAwareSelfTest.java @@ -146,7 +146,7 @@ public static class TestTxFactory extends GridAbstractLifecycleAwareSelfTest.Tes // No-op, see anothre tests. } - /** {@inheritDoc} */ + /** */ @Test public void testCacheLookupLifecycleAware() throws Exception { tmConfigurationType = TmConfigurationType.CACHE_LOOKUP; @@ -154,7 +154,7 @@ public void testCacheLookupLifecycleAware() throws Exception { checkLifecycleAware(); } - /** {@inheritDoc} */ + /** */ @Test public void testGlobalLookupLifecycleAware() throws Exception { tmConfigurationType = TmConfigurationType.GLOBAL_LOOKUP; @@ -162,7 +162,7 @@ public void testGlobalLookupLifecycleAware() throws Exception { checkLifecycleAware(); } - /** {@inheritDoc} */ + /** */ @Test public void testFactoryLifecycleAware() throws Exception { tmConfigurationType = TmConfigurationType.FACTORY; diff --git a/modules/kubernetes/src/main/java/org/apache/ignite/spi/discovery/tcp/ipfinder/kubernetes/TcpDiscoveryKubernetesIpFinder.java b/modules/kubernetes/src/main/java/org/apache/ignite/spi/discovery/tcp/ipfinder/kubernetes/TcpDiscoveryKubernetesIpFinder.java index 51b68dfcf6534..03e00b5c50e52 100644 --- a/modules/kubernetes/src/main/java/org/apache/ignite/spi/discovery/tcp/ipfinder/kubernetes/TcpDiscoveryKubernetesIpFinder.java +++ b/modules/kubernetes/src/main/java/org/apache/ignite/spi/discovery/tcp/ipfinder/kubernetes/TcpDiscoveryKubernetesIpFinder.java @@ -92,15 +92,15 @@ public class TcpDiscoveryKubernetesIpFinder extends TcpDiscoveryIpFinderAdapter /** Trust manager. */ private TrustManager[] trustAll = new TrustManager[] { new X509TrustManager() { - public void checkServerTrusted(X509Certificate[] certs, String authType) {} - public void checkClientTrusted(X509Certificate[] certs, String authType) {} - public X509Certificate[] getAcceptedIssuers() { return null; } + @Override public void checkServerTrusted(X509Certificate[] certs, String authType) {} + @Override public void checkClientTrusted(X509Certificate[] certs, String authType) {} + @Override public X509Certificate[] getAcceptedIssuers() { return null; } } }; /** Host verifier. */ private HostnameVerifier trustAllHosts = new HostnameVerifier() { - public boolean verify(String hostname, SSLSession session) { + @Override public boolean verify(String hostname, SSLSession session) { return true; } }; diff --git a/modules/ml/src/main/java/org/apache/ignite/ml/clustering/kmeans/KMeansModel.java b/modules/ml/src/main/java/org/apache/ignite/ml/clustering/kmeans/KMeansModel.java index f177aa4488654..500c5bfcb2ce3 100644 --- a/modules/ml/src/main/java/org/apache/ignite/ml/clustering/kmeans/KMeansModel.java +++ b/modules/ml/src/main/java/org/apache/ignite/ml/clustering/kmeans/KMeansModel.java @@ -53,21 +53,17 @@ public DistanceMeasure distanceMeasure() { return distanceMeasure; } - /** Amount of centers in clusterization. */ + /** {@inheritDoc} */ @Override public int getAmountOfClusters() { return centers.length; } - /** Get centers of clusters. */ + /** {@inheritDoc} */ @Override public Vector[] getCenters() { return Arrays.copyOf(centers, centers.length); } - /** - * Predict closest center index for a given vector. - * - * @param vec Vector. - */ + /** {@inheritDoc} */ @Override public Integer predict(Vector vec) { int res = -1; double minDist = Double.POSITIVE_INFINITY; diff --git a/modules/ml/src/main/java/org/apache/ignite/ml/genetic/CrossOverJob.java b/modules/ml/src/main/java/org/apache/ignite/ml/genetic/CrossOverJob.java index 0b8d17c00be24..77b09a29a218a 100644 --- a/modules/ml/src/main/java/org/apache/ignite/ml/genetic/CrossOverJob.java +++ b/modules/ml/src/main/java/org/apache/ignite/ml/genetic/CrossOverJob.java @@ -93,9 +93,7 @@ private long[] crossOver(long[] newKeySwapArrForChrome, int updateIdx, long[] ge return newGeneKeys; } - /** - * Perform crossover operation - */ + /** {@inheritDoc} */ @Override public Object execute() throws IgniteException { if (this.crossOverRate > Math.random()) { diff --git a/modules/ml/src/main/java/org/apache/ignite/ml/genetic/CrossOverTask.java b/modules/ml/src/main/java/org/apache/ignite/ml/genetic/CrossOverTask.java index e6acada2983b6..50d7362f5ef51 100644 --- a/modules/ml/src/main/java/org/apache/ignite/ml/genetic/CrossOverTask.java +++ b/modules/ml/src/main/java/org/apache/ignite/ml/genetic/CrossOverTask.java @@ -58,13 +58,7 @@ public CrossOverTask(GAConfiguration cfg) { this.cfg = cfg; } - /** - * Map Jobs to nodes using data affinity. - * - * @param nodes Cluster Nodes - * @param chromosomeKeys Primary keys for respective chromosomes - * @return A map of nodes to jobs. - */ + /** {@inheritDoc} */ @Override public Map map(List nodes, List chromosomeKeys) throws IgniteException { Map map = new HashMap<>(); @@ -80,22 +74,13 @@ public CrossOverTask(GAConfiguration cfg) { return map; } - /** - * We return TRUE if success, else Exection is thrown. - * - * @param list ComputeJobResult - * @return Boolean value; if operationa was successful return true, otherwise Exception - */ + /** {@inheritDoc} */ @Override public Boolean reduce(List list) throws IgniteException { // TODO Auto-generated method stub return Boolean.TRUE; } - /** - * @param res ComputeJobResult - * @param rcvd List of ComputeJobResult - * @return ComputeJobResultPolicy - */ + /** {@inheritDoc} */ @Override public ComputeJobResultPolicy result(ComputeJobResult res, List rcvd) { IgniteException err = res.getException(); diff --git a/modules/ml/src/main/java/org/apache/ignite/ml/genetic/FitnessJob.java b/modules/ml/src/main/java/org/apache/ignite/ml/genetic/FitnessJob.java index 5bf7f833871e4..757d6755e4003 100644 --- a/modules/ml/src/main/java/org/apache/ignite/ml/genetic/FitnessJob.java +++ b/modules/ml/src/main/java/org/apache/ignite/ml/genetic/FitnessJob.java @@ -58,13 +58,7 @@ public FitnessJob(Long key, IFitnessFunction fitnessFunction) { this.fitnessFuncton = fitnessFunction; } - /** - * Perform fitness operation utilizing IFitnessFunction - * - * Update chromosome's fitness value - * - * @return Fitness score - */ + /** {@inheritDoc} */ @Override public Double execute() throws IgniteException { IgniteCache populationCache = ignite.cache(GAGridConstants.POPULATION_CACHE); diff --git a/modules/ml/src/main/java/org/apache/ignite/ml/genetic/FitnessTask.java b/modules/ml/src/main/java/org/apache/ignite/ml/genetic/FitnessTask.java index 5a02bed960bd1..9062bac80de07 100644 --- a/modules/ml/src/main/java/org/apache/ignite/ml/genetic/FitnessTask.java +++ b/modules/ml/src/main/java/org/apache/ignite/ml/genetic/FitnessTask.java @@ -50,11 +50,7 @@ public FitnessTask(GAConfiguration cfg) { this.cfg = cfg; } - /** - * @param nodes List of ClusterNode - * @param chromosomeKeys List of chromosome keys - * @return Map of jobs to nodes - */ + /** {@inheritDoc} */ @Override public Map map(List nodes, List chromosomeKeys) throws IgniteException { Map map = new HashMap<>(); @@ -72,20 +68,13 @@ public FitnessTask(GAConfiguration cfg) { return map; } - /** - * @param list List of ComputeJobResult - * @return Boolean value - */ + /** {@inheritDoc} */ @Override public Boolean reduce(List list) throws IgniteException { return Boolean.TRUE; } - /** - * @param res ComputeJobResult - * @param rcvd List of ComputeJobResult - * @return ComputeJobResultPolicy - */ + /** {@inheritDoc} */ @Override public ComputeJobResultPolicy result(ComputeJobResult res, List rcvd) { IgniteException err = res.getException(); diff --git a/modules/ml/src/main/java/org/apache/ignite/ml/genetic/GAGrid.java b/modules/ml/src/main/java/org/apache/ignite/ml/genetic/GAGrid.java index 553124100ccd4..9eea278913b95 100644 --- a/modules/ml/src/main/java/org/apache/ignite/ml/genetic/GAGrid.java +++ b/modules/ml/src/main/java/org/apache/ignite/ml/genetic/GAGrid.java @@ -176,7 +176,7 @@ public Chromosome evolve() { double averageFitnessScore = calculateAverageFitness(); Long key = map.keySet().iterator().next(); - + fittestChomosome = populationCache.get(key); // while NOT terminateCondition met @@ -219,8 +219,8 @@ public Chromosome evolve() { * @return Map of primary key/fitness score pairs for chromosomes. */ private LinkedHashMap getChromosomesByFittest() { - LinkedHashMap orderChromKeysByFittest = new LinkedHashMap<>(); - + LinkedHashMap orderChromKeysByFittest = new LinkedHashMap<>(); + String orderDirection = "desc"; if (!cfg.isHigherFitnessValFitter()) @@ -232,11 +232,11 @@ private LinkedHashMap getChromosomesByFittest() { QueryCursor> cursor = populationCache.query(new SqlFieldsQuery(fittestSQL)); List> res = cursor.getAll(); - + for (List row : res) { - Long key = (Long)row.get(0); - Double fitnessScore= (Double)row.get(1); - orderChromKeysByFittest.put(key, fitnessScore); + Long key = (Long)row.get(0); + Double fitnessScore = (Double)row.get(1); + orderChromKeysByFittest.put(key, fitnessScore); } return orderChromKeysByFittest; @@ -338,8 +338,8 @@ private List selectByTruncation(List keys) { * @return List of primary Keys for respective chromosomes that will breed */ private List selectByRouletteWheel(LinkedHashMap map) { - List populationKeys = this.ignite.compute().execute(new RouletteWheelSelectionTask(this.cfg), map); - + List populationKeys = this.ignite.compute().execute(new RouletteWheelSelectionTask(this.cfg), map); + return populationKeys; } @@ -421,7 +421,7 @@ private List selection(LinkedHashMap map) { break; case SELECTION_METHOD_ROULETTE_WHEEL: selectedKeys = this.selectByRouletteWheel(map); - + default: break; } @@ -435,9 +435,9 @@ private List selection(LinkedHashMap map) { * @return List of Chromosome primary keys */ List getPopulationKeys() { - String fittestSQL = "select _key from Chromosome"; + String fittestSQL = "select _key from Chromosome"; - // Execute query to retrieve keys for ALL Chromosomes + // Execute query to retrieve keys for ALL Chromosomes QueryCursor> cursor = populationCache.query(new SqlFieldsQuery(fittestSQL)); List> res = cursor.getAll(); diff --git a/modules/ml/src/main/java/org/apache/ignite/ml/genetic/MutateJob.java b/modules/ml/src/main/java/org/apache/ignite/ml/genetic/MutateJob.java index 5e102a561e6ee..e1f1dd2bc6326 100644 --- a/modules/ml/src/main/java/org/apache/ignite/ml/genetic/MutateJob.java +++ b/modules/ml/src/main/java/org/apache/ignite/ml/genetic/MutateJob.java @@ -54,11 +54,7 @@ public MutateJob(Long key, List mutatedGeneKeys, double mutationRate) { this.mutatedGeneKeys = mutatedGeneKeys; } - /** - * Perform mutation - * - * @return Boolean value - */ + /** {@inheritDoc} */ @Override public Boolean execute() throws IgniteException { IgniteCache populationCache = ignite.cache(GAGridConstants.POPULATION_CACHE); diff --git a/modules/ml/src/main/java/org/apache/ignite/ml/genetic/MutateTask.java b/modules/ml/src/main/java/org/apache/ignite/ml/genetic/MutateTask.java index 51c602a51c4c9..592ac442faf04 100644 --- a/modules/ml/src/main/java/org/apache/ignite/ml/genetic/MutateTask.java +++ b/modules/ml/src/main/java/org/apache/ignite/ml/genetic/MutateTask.java @@ -74,11 +74,7 @@ private List getMutatedGenes() { return mutatedGenes; } - /** - * @param nodes List of ClusterNode - * @param chromosomeKeys Primary keys for respective chromosomes - * @return Mapping compute jobs to nodes. - */ + /** {@inheritDoc} */ @Override public Map map(List nodes, List chromosomeKeys) throws IgniteException { Map map = new HashMap<>(); @@ -92,21 +88,12 @@ private List getMutatedGenes() { return map; } - /** - * We return TRUE if success, else Exection is thrown. - * - * @param list List of ComputeJobResult - * @return Boolean value - */ + /** {@inheritDoc} */ @Override public Boolean reduce(List list) throws IgniteException { return Boolean.TRUE; } - /** - * @param res ComputeJobResult - * @param rcvd List of ComputeJobResult - * @return ComputeJobResultPolicy - */ + /** {@inheritDoc} */ @Override public ComputeJobResultPolicy result(ComputeJobResult res, List rcvd) { IgniteException err = res.getException(); diff --git a/modules/ml/src/main/java/org/apache/ignite/ml/genetic/TruncateSelectionJob.java b/modules/ml/src/main/java/org/apache/ignite/ml/genetic/TruncateSelectionJob.java index 4586ff622de6d..a56ad2cee6634 100644 --- a/modules/ml/src/main/java/org/apache/ignite/ml/genetic/TruncateSelectionJob.java +++ b/modules/ml/src/main/java/org/apache/ignite/ml/genetic/TruncateSelectionJob.java @@ -49,11 +49,7 @@ public TruncateSelectionJob(Long key, List mutatedGeneKeys) { this.mutatedGeneKeys = mutatedGeneKeys; } - /** - * Perform mutation - * - * @return Boolean value - */ + /** {@inheritDoc} */ @Override public Boolean execute() throws IgniteException { IgniteCache populationCache = ignite.cache(GAGridConstants.POPULATION_CACHE); diff --git a/modules/ml/src/main/java/org/apache/ignite/ml/genetic/TruncateSelectionTask.java b/modules/ml/src/main/java/org/apache/ignite/ml/genetic/TruncateSelectionTask.java index 81da7fbdd8ec3..b3dabdaed608e 100644 --- a/modules/ml/src/main/java/org/apache/ignite/ml/genetic/TruncateSelectionTask.java +++ b/modules/ml/src/main/java/org/apache/ignite/ml/genetic/TruncateSelectionTask.java @@ -107,11 +107,7 @@ private List> getEnhancedPopulation() { return list; } - /** - * @param nodes List of ClusterNode. - * @param chromosomeKeys Primary keys for respective chromosomes. - * @return Map of nodes to jobs. - */ + /** {@inheritDoc} */ @Override public Map map(List nodes, List chromosomeKeys) throws IgniteException { Map map = new HashMap<>(); Affinity affinity = ignite.affinity(GAGridConstants.POPULATION_CACHE); @@ -129,21 +125,12 @@ private List> getEnhancedPopulation() { return map; } - /** - * We return TRUE if success, else Exception is thrown. - * - * @param list List of ComputeJobResult. - * @return Boolean value. - */ + /** {@inheritDoc} */ @Override public Boolean reduce(List list) throws IgniteException { return Boolean.TRUE; } - /** - * @param res ComputeJobResult. - * @param rcvd List of ComputeJobResult. - * @return ComputeJobResultPolicy. - */ + /** {@inheritDoc} */ @Override public ComputeJobResultPolicy result(ComputeJobResult res, List rcvd) { IgniteException err = res.getException(); diff --git a/modules/ml/src/main/java/org/apache/ignite/ml/knn/NNClassificationModel.java b/modules/ml/src/main/java/org/apache/ignite/ml/knn/NNClassificationModel.java index 2bda392a473ed..8173ad8bd6425 100644 --- a/modules/ml/src/main/java/org/apache/ignite/ml/knn/NNClassificationModel.java +++ b/modules/ml/src/main/java/org/apache/ignite/ml/knn/NNClassificationModel.java @@ -228,6 +228,6 @@ protected void copyParametersFrom(NNClassificationModel mdl) { this.stgy = mdl.stgy; } - /** */ + /** {@inheritDoc} */ @Override public abstract

void saveModel(Exporter exporter, P path); } diff --git a/modules/ml/src/main/java/org/apache/ignite/ml/math/primitives/matrix/Matrix.java b/modules/ml/src/main/java/org/apache/ignite/ml/math/primitives/matrix/Matrix.java index c9523472848e5..47e89afd78b5f 100644 --- a/modules/ml/src/main/java/org/apache/ignite/ml/math/primitives/matrix/Matrix.java +++ b/modules/ml/src/main/java/org/apache/ignite/ml/math/primitives/matrix/Matrix.java @@ -505,9 +505,7 @@ interface Element { */ public Vector viewDiagonal(); - /** - * Destroys matrix if managed outside of JVM. It's a no-op in all other cases. - */ + /** {@inheritDoc} */ @Override public default void destroy() { // No-op. } diff --git a/modules/ml/src/main/java/org/apache/ignite/ml/math/primitives/matrix/storage/DenseMatrixStorage.java b/modules/ml/src/main/java/org/apache/ignite/ml/math/primitives/matrix/storage/DenseMatrixStorage.java index 111526cce81bd..ae32d9c5f3eca 100644 --- a/modules/ml/src/main/java/org/apache/ignite/ml/math/primitives/matrix/storage/DenseMatrixStorage.java +++ b/modules/ml/src/main/java/org/apache/ignite/ml/math/primitives/matrix/storage/DenseMatrixStorage.java @@ -183,7 +183,7 @@ private IgniteIntIntToIntBiFunction indexMapper(int stoMode) { data = (double[])in.readObject(); } - /** Get the access mode of this storage. */ + /** {@inheritDoc} */ @Override public int accessMode() { return stoMode; } diff --git a/modules/ml/src/main/java/org/apache/ignite/ml/math/primitives/matrix/storage/SparseMatrixStorage.java b/modules/ml/src/main/java/org/apache/ignite/ml/math/primitives/matrix/storage/SparseMatrixStorage.java index e30be45d4ef1f..20046cfe44007 100644 --- a/modules/ml/src/main/java/org/apache/ignite/ml/math/primitives/matrix/storage/SparseMatrixStorage.java +++ b/modules/ml/src/main/java/org/apache/ignite/ml/math/primitives/matrix/storage/SparseMatrixStorage.java @@ -68,9 +68,7 @@ public SparseMatrixStorage(int rows, int cols, int acsMode, int stoMode) { sto = new HashMap<>(); } - /** - * @return Matrix elements storage mode. - */ + /** {@inheritDoc} */ @Override public int storageMode() { return stoMode; } diff --git a/modules/ml/src/main/java/org/apache/ignite/ml/nn/MultilayerPerceptron.java b/modules/ml/src/main/java/org/apache/ignite/ml/nn/MultilayerPerceptron.java index 7322924c32c82..4e17480dc7994 100644 --- a/modules/ml/src/main/java/org/apache/ignite/ml/nn/MultilayerPerceptron.java +++ b/modules/ml/src/main/java/org/apache/ignite/ml/nn/MultilayerPerceptron.java @@ -354,8 +354,10 @@ public MLPArchitecture architecture() { } /** {@inheritDoc} */ - @Override public Vector differentiateByParameters(IgniteFunction loss, - Matrix inputsBatch, Matrix truthBatch) { + @Override public Vector differentiateByParameters( + IgniteFunction loss, + Matrix inputsBatch, Matrix truthBatch + ) { // Backpropagation algorithm is used here. int batchSize = inputsBatch.columnSize(); double invBatchSize = 1 / (double)batchSize; diff --git a/modules/ml/src/main/java/org/apache/ignite/ml/nn/ReplicatedVectorMatrix.java b/modules/ml/src/main/java/org/apache/ignite/ml/nn/ReplicatedVectorMatrix.java index 854af7553d069..12fa3103557bf 100644 --- a/modules/ml/src/main/java/org/apache/ignite/ml/nn/ReplicatedVectorMatrix.java +++ b/modules/ml/src/main/java/org/apache/ignite/ml/nn/ReplicatedVectorMatrix.java @@ -173,7 +173,7 @@ public ReplicatedVectorMatrix() { return asCol ? new ReplicatedVectorMatrix(swap(row1, row2), replicationCnt, asCol) : this; } - /** {@inheritDoc} */ + /** */ private Vector swap(int idx1, int idx2) { double val = vector.getX(idx1); diff --git a/modules/ml/src/main/java/org/apache/ignite/ml/trainers/DatasetTrainer.java b/modules/ml/src/main/java/org/apache/ignite/ml/trainers/DatasetTrainer.java index 91da2bf241121..8cef0f0b712ba 100644 --- a/modules/ml/src/main/java/org/apache/ignite/ml/trainers/DatasetTrainer.java +++ b/modules/ml/src/main/java/org/apache/ignite/ml/trainers/DatasetTrainer.java @@ -338,7 +338,7 @@ private Preprocessor getNewExtractor( return new PatchedPreprocessor(func, extractor); } - /** {@inheritDoc} */ + /** */ public M fit(DatasetBuilder datasetBuilder, Vectorizer extractor) { return old.fit(datasetBuilder, getNewExtractor(extractor)); diff --git a/modules/ml/src/test/java/org/apache/ignite/ml/TestUtils.java b/modules/ml/src/test/java/org/apache/ignite/ml/TestUtils.java index 36bc29426fe1e..4203b149eaea5 100644 --- a/modules/ml/src/test/java/org/apache/ignite/ml/TestUtils.java +++ b/modules/ml/src/test/java/org/apache/ignite/ml/TestUtils.java @@ -448,7 +448,7 @@ public static IgniteModel constantModel(V v) { */ public static , L> DatasetTrainer constantTrainer(M ml) { return new DatasetTrainer() { - /** {@inheritDoc} */ + /** */ public M fit(DatasetBuilder datasetBuilder, Vectorizer extractor) { return ml; @@ -468,8 +468,8 @@ public M fit(DatasetBuilder datasetBuilder, return null; } - /** {@inheritDoc} */ - public M updateModel(M mdl, DatasetBuilder datasetBuilder, + /** */ + public M updateModel(M mdl, DatasetBuilder datasetBuilder, Vectorizer extractor) { return ml; } diff --git a/modules/ml/src/test/java/org/apache/ignite/ml/math/primitives/vector/VectorImplementationsFixtures.java b/modules/ml/src/test/java/org/apache/ignite/ml/math/primitives/vector/VectorImplementationsFixtures.java index 08fcb0191da6d..d1fb56bc27249 100644 --- a/modules/ml/src/test/java/org/apache/ignite/ml/math/primitives/vector/VectorImplementationsFixtures.java +++ b/modules/ml/src/test/java/org/apache/ignite/ml/math/primitives/vector/VectorImplementationsFixtures.java @@ -215,7 +215,7 @@ private static class VectorSizesExtraIterator extends VectorSizesIterator { return (size, delta) -> ctor.apply(size + delta, extras[extraIdx]); } - /** */ + /** {@inheritDoc} */ @Override void selfTest() { final Set extraIdxs = new HashSet<>(); diff --git a/modules/ml/src/test/java/org/apache/ignite/ml/preprocessing/binarization/BinarizationTrainerTest.java b/modules/ml/src/test/java/org/apache/ignite/ml/preprocessing/binarization/BinarizationTrainerTest.java index 45485d180e41a..c7aa45dd16f32 100644 --- a/modules/ml/src/test/java/org/apache/ignite/ml/preprocessing/binarization/BinarizationTrainerTest.java +++ b/modules/ml/src/test/java/org/apache/ignite/ml/preprocessing/binarization/BinarizationTrainerTest.java @@ -25,7 +25,6 @@ import org.apache.ignite.ml.dataset.feature.extractor.Vectorizer; import org.apache.ignite.ml.dataset.feature.extractor.impl.DummyVectorizer; import org.apache.ignite.ml.dataset.impl.local.LocalDatasetBuilder; -import org.apache.ignite.ml.math.functions.IgniteBiFunction; import org.apache.ignite.ml.math.primitives.vector.Vector; import org.apache.ignite.ml.math.primitives.vector.VectorUtils; import org.junit.Test; diff --git a/modules/ml/src/test/java/org/apache/ignite/ml/selection/scoring/evaluator/BinaryClassificationEvaluatorTest.java b/modules/ml/src/test/java/org/apache/ignite/ml/selection/scoring/evaluator/BinaryClassificationEvaluatorTest.java index a8e1a845dbaa9..f8ae61f0930cd 100644 --- a/modules/ml/src/test/java/org/apache/ignite/ml/selection/scoring/evaluator/BinaryClassificationEvaluatorTest.java +++ b/modules/ml/src/test/java/org/apache/ignite/ml/selection/scoring/evaluator/BinaryClassificationEvaluatorTest.java @@ -22,7 +22,6 @@ import org.apache.ignite.ml.dataset.feature.extractor.impl.DummyVectorizer; import org.apache.ignite.ml.knn.NNClassificationModel; import org.apache.ignite.ml.knn.classification.KNNClassificationTrainer; -import org.apache.ignite.ml.math.functions.IgniteBiFunction; import org.apache.ignite.ml.math.primitives.vector.Vector; import org.apache.ignite.ml.math.primitives.vector.VectorUtils; import org.apache.ignite.ml.selection.scoring.metric.classification.Accuracy; diff --git a/modules/ml/src/test/java/org/apache/ignite/ml/selection/scoring/evaluator/RegressionEvaluatorTest.java b/modules/ml/src/test/java/org/apache/ignite/ml/selection/scoring/evaluator/RegressionEvaluatorTest.java index 1f11b3527666e..e8a6bb27b7ae6 100644 --- a/modules/ml/src/test/java/org/apache/ignite/ml/selection/scoring/evaluator/RegressionEvaluatorTest.java +++ b/modules/ml/src/test/java/org/apache/ignite/ml/selection/scoring/evaluator/RegressionEvaluatorTest.java @@ -24,7 +24,6 @@ import org.apache.ignite.ml.knn.regression.KNNRegressionModel; import org.apache.ignite.ml.knn.regression.KNNRegressionTrainer; import org.apache.ignite.ml.math.distances.EuclideanDistance; -import org.apache.ignite.ml.math.functions.IgniteBiFunction; import org.apache.ignite.ml.math.primitives.vector.Vector; import org.apache.ignite.ml.math.primitives.vector.VectorUtils; import org.apache.ignite.ml.selection.scoring.metric.regression.RegressionMetricValues; diff --git a/modules/osgi/src/main/java/org/apache/ignite/osgi/classloaders/BundleDelegatingClassLoader.java b/modules/osgi/src/main/java/org/apache/ignite/osgi/classloaders/BundleDelegatingClassLoader.java index 92919b91eb057..36f1856697aab 100644 --- a/modules/osgi/src/main/java/org/apache/ignite/osgi/classloaders/BundleDelegatingClassLoader.java +++ b/modules/osgi/src/main/java/org/apache/ignite/osgi/classloaders/BundleDelegatingClassLoader.java @@ -71,26 +71,13 @@ public BundleDelegatingClassLoader(Bundle bundle, ClassLoader classLoader) { return resource; } - /** - * Finds a given resource from within the {@link #bundle}. - * - * @param name The resource name. - * @return URLs of resources. - * @throws IOException - */ + /** {@inheritDoc} */ @SuppressWarnings({"unchecked", "rawtypes"}) - protected Enumeration findResources(String name) throws IOException { + @Override protected Enumeration findResources(String name) throws IOException { return bundle.getResources(name); } - /** - * Loads a class trying the {@link #bundle} first, falling back to the ClassLoader {@link #clsLdr}. - * - * @param name Class name. - * @param resolve {@code true} to resolve the class. - * @return The Class. - * @throws ClassNotFoundException - */ + /** {@inheritDoc} */ @Override protected Class loadClass(String name, boolean resolve) throws ClassNotFoundException { Class cls; diff --git a/modules/spark/src/test/java/org/apache/ignite/spark/JavaEmbeddedIgniteRDDSelfTest.java b/modules/spark/src/test/java/org/apache/ignite/spark/JavaEmbeddedIgniteRDDSelfTest.java index e6977f5e7149f..bf256c6c5d1cb 100644 --- a/modules/spark/src/test/java/org/apache/ignite/spark/JavaEmbeddedIgniteRDDSelfTest.java +++ b/modules/spark/src/test/java/org/apache/ignite/spark/JavaEmbeddedIgniteRDDSelfTest.java @@ -25,8 +25,6 @@ import org.apache.ignite.configuration.IgniteConfiguration; import org.apache.ignite.internal.util.typedef.F; import org.apache.ignite.lang.IgniteOutClosure; -import org.apache.ignite.spi.discovery.tcp.TcpDiscoverySpi; -import org.apache.ignite.spi.discovery.tcp.ipfinder.vm.TcpDiscoveryVmIpFinder; import org.apache.ignite.testframework.junits.common.GridCommonAbstractTest; import org.apache.spark.SparkConf; import org.apache.spark.api.java.JavaRDD; diff --git a/modules/tensorflow/src/main/java/org/apache/ignite/tensorflow/core/util/PythonProcessBuilderSupplier.java b/modules/tensorflow/src/main/java/org/apache/ignite/tensorflow/core/util/PythonProcessBuilderSupplier.java index ffb5e820d198b..f3882e9e774e0 100644 --- a/modules/tensorflow/src/main/java/org/apache/ignite/tensorflow/core/util/PythonProcessBuilderSupplier.java +++ b/modules/tensorflow/src/main/java/org/apache/ignite/tensorflow/core/util/PythonProcessBuilderSupplier.java @@ -48,12 +48,8 @@ public PythonProcessBuilderSupplier(boolean interactive, String... meta) { this.meta = meta; } - /** - * Returns process builder to be used to start Python process. - * - * @return Process builder to be used to start Python process. - */ - public ProcessBuilder get() { + /** {@inheritDoc} */ + @Override public ProcessBuilder get() { String python = System.getenv(PYTHON_ENV_NAME); if (python == null) diff --git a/modules/urideploy/src/main/java/org/apache/ignite/spi/deployment/uri/scanners/UriDeploymentScannerManager.java b/modules/urideploy/src/main/java/org/apache/ignite/spi/deployment/uri/scanners/UriDeploymentScannerManager.java index f5bb6d35f1a4d..7cb0cb70627e8 100644 --- a/modules/urideploy/src/main/java/org/apache/ignite/spi/deployment/uri/scanners/UriDeploymentScannerManager.java +++ b/modules/urideploy/src/main/java/org/apache/ignite/spi/deployment/uri/scanners/UriDeploymentScannerManager.java @@ -164,14 +164,14 @@ public void join() { } /** {@inheritDoc} */ - public boolean isCancelled() { + @Override public boolean isCancelled() { assert scannerThread != null; return scannerThread.isInterrupted(); } /** {@inheritDoc} */ - public File createTempFile(String fileName, File tmpDir) throws IOException { + @Override public File createTempFile(String fileName, File tmpDir) throws IOException { assert fileName != null; int idx = fileName.lastIndexOf('.'); @@ -190,32 +190,32 @@ public File createTempFile(String fileName, File tmpDir) throws IOException { } /** {@inheritDoc} */ - public boolean isFirstScan() { + @Override public boolean isFirstScan() { return firstScan; } /** {@inheritDoc} */ - public URI getUri() { + @Override public URI getUri() { return uri; } /** {@inheritDoc} */ - public File getDeployDirectory() { + @Override public File getDeployDirectory() { return deployDir; } /** {@inheritDoc} */ - public FilenameFilter getFilter() { + @Override public FilenameFilter getFilter() { return filter; } /** {@inheritDoc} */ - public GridUriDeploymentScannerListener getListener() { + @Override public GridUriDeploymentScannerListener getListener() { return lsnr; } /** {@inheritDoc} */ - public IgniteLogger getLogger() { + @Override public IgniteLogger getLogger() { return log; } diff --git a/modules/urideploy/src/test/java/org/apache/ignite/spi/deployment/uri/GridUriDeploymentAbstractSelfTest.java b/modules/urideploy/src/test/java/org/apache/ignite/spi/deployment/uri/GridUriDeploymentAbstractSelfTest.java index 3333300540c99..603297785a950 100644 --- a/modules/urideploy/src/test/java/org/apache/ignite/spi/deployment/uri/GridUriDeploymentAbstractSelfTest.java +++ b/modules/urideploy/src/test/java/org/apache/ignite/spi/deployment/uri/GridUriDeploymentAbstractSelfTest.java @@ -93,7 +93,7 @@ protected void checkNoTask(String taskName) throws Exception { protected void waitForTask(String taskName, boolean expectDeployed, long timeout) throws IgniteCheckedException { assertTrue("Failed to wait for (un)deployment of " + taskName, GridTestUtils.waitForCondition(new GridAbsPredicateX() { - public boolean applyx() throws IgniteCheckedException { + @Override public boolean applyx() throws IgniteCheckedException { if (expectDeployed) return getSpi().findResource(taskName) != null; else diff --git a/modules/yardstick/src/main/java/org/apache/ignite/yardstick/IgniteThinClient.java b/modules/yardstick/src/main/java/org/apache/ignite/yardstick/IgniteThinClient.java index 22e27b0a1a6a5..dcc6a5afc3b69 100644 --- a/modules/yardstick/src/main/java/org/apache/ignite/yardstick/IgniteThinClient.java +++ b/modules/yardstick/src/main/java/org/apache/ignite/yardstick/IgniteThinClient.java @@ -56,7 +56,7 @@ public IgniteThinClient(IgniteClient client) { this.client = client; } - /** {@inheritDoc} */ + /** */ public IgniteClient start(BenchmarkConfiguration cfg, String host) throws Exception { IgniteBenchmarkArguments args = new IgniteBenchmarkArguments(); diff --git a/modules/yarn/src/main/java/org/apache/ignite/yarn/ApplicationMaster.java b/modules/yarn/src/main/java/org/apache/ignite/yarn/ApplicationMaster.java index bef5f5d5dc25d..f42edb1cad76a 100644 --- a/modules/yarn/src/main/java/org/apache/ignite/yarn/ApplicationMaster.java +++ b/modules/yarn/src/main/java/org/apache/ignite/yarn/ApplicationMaster.java @@ -107,7 +107,7 @@ public ApplicationMaster(String ignitePath, ClusterProperties props) throws Exce } /** {@inheritDoc} */ - public synchronized void onContainersAllocated(List conts) { + @Override public synchronized void onContainersAllocated(List conts) { for (Container c : conts) { if (checkContainer(c)) { try { @@ -226,7 +226,7 @@ private String getAddress(String addr) { } /** {@inheritDoc} */ - public synchronized void onContainersCompleted(List statuses) { + @Override public synchronized void onContainersCompleted(List statuses) { for (ContainerStatus status : statuses) { containers.remove(status.getContainerId()); @@ -236,7 +236,7 @@ public synchronized void onContainersCompleted(List statuses) { } /** {@inheritDoc} */ - public synchronized void onNodesUpdated(List updated) { + @Override public synchronized void onNodesUpdated(List updated) { for (NodeReport node : updated) { // If node unusable. if (node.getNodeState().isUnusable()) { @@ -256,17 +256,17 @@ public synchronized void onNodesUpdated(List updated) { } /** {@inheritDoc} */ - public void onShutdownRequest() { + @Override public void onShutdownRequest() { // No-op. } /** {@inheritDoc} */ - public void onError(Throwable t) { + @Override public void onError(Throwable t) { nmClient.stop(); } /** {@inheritDoc} */ - public float getProgress() { + @Override public float getProgress() { return 50; } diff --git a/modules/zookeeper/src/main/java/org/apache/ignite/spi/discovery/zk/internal/ZookeeperClusterNode.java b/modules/zookeeper/src/main/java/org/apache/ignite/spi/discovery/zk/internal/ZookeeperClusterNode.java index f90bc01dd124d..39eed3725bf82 100644 --- a/modules/zookeeper/src/main/java/org/apache/ignite/spi/discovery/zk/internal/ZookeeperClusterNode.java +++ b/modules/zookeeper/src/main/java/org/apache/ignite/spi/discovery/zk/internal/ZookeeperClusterNode.java @@ -158,7 +158,7 @@ public ZookeeperClusterNode( } /** {@inheritDoc} */ - public void setConsistentId(Serializable consistentId) { + @Override public void setConsistentId(Serializable consistentId) { this.consistentId = consistentId; final Map map = new HashMap<>(attrs); @@ -211,7 +211,7 @@ Map getAttributes() { } /** {@inheritDoc} */ - public void setMetrics(ClusterMetrics metrics) { + @Override public void setMetrics(ClusterMetrics metrics) { assert metrics != null; this.metrics = metrics; @@ -231,7 +231,7 @@ public void setMetrics(ClusterMetrics metrics) { } /** {@inheritDoc} */ - public void setCacheMetrics(Map cacheMetrics) { + @Override public void setCacheMetrics(Map cacheMetrics) { this.cacheMetrics = cacheMetrics != null ? cacheMetrics : Collections.emptyMap(); } diff --git a/modules/zookeeper/src/test/java/org/apache/ignite/spi/discovery/tcp/ipfinder/zk/curator/TestingZooKeeperServer.java b/modules/zookeeper/src/test/java/org/apache/ignite/spi/discovery/tcp/ipfinder/zk/curator/TestingZooKeeperServer.java index 808e617e17edb..dbe651a5f8629 100644 --- a/modules/zookeeper/src/test/java/org/apache/ignite/spi/discovery/tcp/ipfinder/zk/curator/TestingZooKeeperServer.java +++ b/modules/zookeeper/src/test/java/org/apache/ignite/spi/discovery/tcp/ipfinder/zk/curator/TestingZooKeeperServer.java @@ -79,7 +79,7 @@ public TestingZooKeeperServer(QuorumConfigBuilder configBuilder, int thisInstanc } /** {@inheritDoc} */ - public QuorumPeer getQuorumPeer() { + @Override public QuorumPeer getQuorumPeer() { return main.getQuorumPeer(); } @@ -153,7 +153,7 @@ public void start() throws Exception { return; new Thread(new Runnable() { - public void run() { + @Override public void run() { try { QuorumPeerConfig config = configBuilder.buildConfig(thisInstanceIndex); main.runFromConfig(config); diff --git a/parent/pom.xml b/parent/pom.xml index 1b31cf0da3f34..21abd5fa6330f 100644 --- a/parent/pom.xml +++ b/parent/pom.xml @@ -103,6 +103,8 @@ 7.4.0 1.5.0 3.5.0 + 3.0.0 + 8.19 1.10.19 8.0.13 1.1.2 @@ -797,6 +799,45 @@ + + checkstyle + + + + org.apache.maven.plugins + maven-checkstyle-plugin + ${maven.checkstyle.plugin.version} + + + style + + check + + validate + + true + true + true + true + ${project.build.directory}/checkstyle-result.xml + ../checkstyle/checkstyle.xml + ../checkstyle/checkstyle-suppressions.xml + true + + + + + + com.puppycrawl.tools + checkstyle + ${checkstyle.puppycrawl.version} + + + + + + + check-licenses @@ -872,10 +913,7 @@ **/keystore/ca/*serial **/META-INF/services/** - idea/disabled_plugins.txt idea/ignite_codeStyle.xml - idea/ignite_inspections.xml - idea/ignite_inspections_teamcity.xml **/DEVNOTES*.txt **/NOTICE* **/LICENSE* @@ -1275,6 +1313,5 @@ -