From df55ba925969ff0345dbbc3e686a522ef1cefe39 Mon Sep 17 00:00:00 2001 From: Alexey Goncharuk Date: Thu, 12 Feb 2015 13:43:02 -0800 Subject: [PATCH] Ignite-9655-merge - Fixed compilation. --- .../communication/GridIoMessageFactory.java | 10 ---- .../GridCachePartitionExchangeManager.java | 7 --- .../GridDistributedLockRequest.java | 30 ---------- .../GridDistributedTxFinishRequest.java | 30 ---------- .../GridDistributedTxPrepareRequest.java | 14 ----- .../distributed/dht/GridDhtLockFuture.java | 2 +- .../dht/GridDhtTxFinishRequest.java | 60 ------------------- .../dht/GridDhtTxPrepareFuture.java | 12 ++-- .../distributed/near/GridNearLockRequest.java | 6 -- .../near/GridNearTxPrepareFuture.java | 7 +-- .../cache/transactions/IgniteTxAdapter.java | 5 -- .../transactions/IgniteTxLocalAdapter.java | 8 +-- .../cache/transactions/IgniteTxProxyImpl.java | 2 +- .../GridCacheAbstractFullApiSelfTest.java | 15 ++--- ...riginatingNodeFailureAbstractSelfTest.java | 2 +- 15 files changed, 19 insertions(+), 191 deletions(-) diff --git a/modules/core/src/main/java/org/apache/ignite/internal/managers/communication/GridIoMessageFactory.java b/modules/core/src/main/java/org/apache/ignite/internal/managers/communication/GridIoMessageFactory.java index e8481f1688ca9..2c5be43e23c3e 100644 --- a/modules/core/src/main/java/org/apache/ignite/internal/managers/communication/GridIoMessageFactory.java +++ b/modules/core/src/main/java/org/apache/ignite/internal/managers/communication/GridIoMessageFactory.java @@ -173,16 +173,6 @@ public GridIoMessageFactory(MessageFormatter formatter, MessageFactory[] ext) { break; - case 18: - msg = new GridCachePessimisticCheckCommittedTxRequest(); - - break; - - case 19: - msg = new GridCachePessimisticCheckCommittedTxResponse(); - - break; - case 20: msg = new GridCacheTtlUpdateRequest(); diff --git a/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/GridCachePartitionExchangeManager.java b/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/GridCachePartitionExchangeManager.java index 1d064e261f437..d7b1914c516f6 100644 --- a/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/GridCachePartitionExchangeManager.java +++ b/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/GridCachePartitionExchangeManager.java @@ -280,13 +280,6 @@ public class GridCachePartitionExchangeManager extends GridCacheSharedMana cctx.time().removeTimeoutObject(resendTimeoutObj); } - /** {@inheritDoc} */ - @Override protected void stop0(boolean cancel) { - super.stop0(cancel); - - exchFuts = null; - } - /** {@inheritDoc} */ @SuppressWarnings("LockAcquiredButNotSafelyReleased") @Override protected void stop0(boolean cancel) { diff --git a/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/distributed/GridDistributedLockRequest.java b/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/distributed/GridDistributedLockRequest.java index f1ad5435c3d01..b2ed1d08a2d4b 100644 --- a/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/distributed/GridDistributedLockRequest.java +++ b/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/distributed/GridDistributedLockRequest.java @@ -397,12 +397,6 @@ public long timeout() { } switch (state) { - case 8: - if (!writer.writeObjectArray("drVersByIdx", drVersByIdx, GridCacheVersion.class)) - return false; - - state++; - case 9: if (!writer.writeIgniteUuid("futId", futId)) return false; @@ -486,13 +480,6 @@ public long timeout() { return false; state++; - - case 23: - if (!writer.writeByteArray("writeEntriesBytes", writeEntriesBytes)) - return false; - - state++; - } return true; @@ -507,14 +494,6 @@ public long timeout() { return false; switch (state) { - case 8: - drVersByIdx = reader.readObjectArray("drVersByIdx", GridCacheVersion.class); - - if (!reader.isLastRead()) - return false; - - state++; - case 9: futId = reader.readIgniteUuid("futId"); @@ -626,15 +605,6 @@ public long timeout() { return false; state++; - - case 23: - writeEntriesBytes = reader.readByteArray("writeEntriesBytes"); - - if (!reader.isLastRead()) - return false; - - state++; - } return true; diff --git a/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/distributed/GridDistributedTxFinishRequest.java b/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/distributed/GridDistributedTxFinishRequest.java index 9b12d1f863490..78fc317389f2e 100644 --- a/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/distributed/GridDistributedTxFinishRequest.java +++ b/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/distributed/GridDistributedTxFinishRequest.java @@ -328,12 +328,6 @@ public boolean groupLock() { state++; - case 14: - if (!writer.writeCollection("recoveryWritesBytes", recoveryWritesBytes, byte[].class)) - return false; - - state++; - case 15: if (!writer.writeBoolean("syncCommit", syncCommit)) return false; @@ -363,13 +357,6 @@ public boolean groupLock() { return false; state++; - - case 20: - if (!writer.writeCollection("writeEntriesBytes", writeEntriesBytes, byte[].class)) - return false; - - state++; - } return true; @@ -432,14 +419,6 @@ public boolean groupLock() { state++; - case 14: - recoveryWritesBytes = reader.readCollection("recoveryWritesBytes", byte[].class); - - if (!reader.isLastRead()) - return false; - - state++; - case 15: syncCommit = reader.readBoolean("syncCommit"); @@ -481,15 +460,6 @@ public boolean groupLock() { return false; state++; - - case 20: - writeEntriesBytes = reader.readCollection("writeEntriesBytes", byte[].class); - - if (!reader.isLastRead()) - return false; - - state++; - } return true; diff --git a/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/distributed/GridDistributedTxPrepareRequest.java b/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/distributed/GridDistributedTxPrepareRequest.java index 7478b8871d948..4140a21a0271c 100644 --- a/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/distributed/GridDistributedTxPrepareRequest.java +++ b/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/distributed/GridDistributedTxPrepareRequest.java @@ -469,12 +469,6 @@ private void writeCollection(ObjectOutput out, Collection> c } switch (state) { - case 8: - if (!writer.writeMessage("commitVer", commitVer)) - return false; - - state++; - case 9: if (!writer.writeEnum("concurrency", concurrency)) return false; @@ -567,14 +561,6 @@ private void writeCollection(ObjectOutput out, Collection> c return false; switch (state) { - case 8: - commitVer = reader.readMessage("commitVer"); - - if (!reader.isLastRead()) - return false; - - state++; - case 9: concurrency = reader.readEnum("concurrency", IgniteTxConcurrency.class); diff --git a/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/distributed/dht/GridDhtLockFuture.java b/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/distributed/dht/GridDhtLockFuture.java index f1ea7c2baa257..9ff2ca55ccfba 100644 --- a/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/distributed/dht/GridDhtLockFuture.java +++ b/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/distributed/dht/GridDhtLockFuture.java @@ -1045,7 +1045,7 @@ void onResult(GridDhtLockResponse res) { // Fail the whole compound future. onError(res.error()); else { - Set invalidParts = res.invalidPartitions(); + Collection invalidParts = res.invalidPartitions(); // Removing mappings for invalid partitions. if (!F.isEmpty(invalidParts)) { diff --git a/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/distributed/dht/GridDhtTxFinishRequest.java b/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/distributed/dht/GridDhtTxFinishRequest.java index 8e39b1159d4dd..bc0520d5730f9 100644 --- a/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/distributed/dht/GridDhtTxFinishRequest.java +++ b/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/distributed/dht/GridDhtTxFinishRequest.java @@ -23,7 +23,6 @@ import org.apache.ignite.internal.processors.cache.version.*; import org.apache.ignite.lang.*; import org.apache.ignite.transactions.*; -import org.apache.ignite.internal.util.*; import org.apache.ignite.internal.util.tostring.*; import org.apache.ignite.internal.util.typedef.internal.*; import org.apache.ignite.plugin.extensions.communication.*; @@ -246,13 +245,10 @@ public Collection pendingVersions() { _clone.sysInvalidate = sysInvalidate; _clone.topVer = topVer; _clone.pendingVers = pendingVers; - _clone.onePhaseCommit = onePhaseCommit; _clone.writeVer = writeVer != null ? (GridCacheVersion)writeVer.clone() : null; _clone.writeVer = writeVer; _clone.subjId = subjId; _clone.taskNameHash = taskNameHash; - _clone.ttls = ttls != null ? (GridLongList)ttls.clone() : null; - _clone.nearTtls = nearTtls != null ? (GridLongList)nearTtls.clone() : null; } /** {@inheritDoc} */ @@ -289,24 +285,6 @@ public Collection pendingVersions() { state++; - case 24: - if (!writer.writeMessage("nearTtls", nearTtls)) - return false; - - state++; - - case 25: - if (!writer.writeCollection("nearWritesBytes", nearWritesBytes, byte[].class)) - return false; - - state++; - - case 26: - if (!writer.writeBoolean("onePhaseCommit", onePhaseCommit)) - return false; - - state++; - case 27: if (!writer.writeCollection("pendingVers", pendingVers, GridCacheVersion.class)) return false; @@ -337,12 +315,6 @@ public Collection pendingVersions() { state++; - case 32: - if (!writer.writeMessage("ttls", ttls)) - return false; - - state++; - case 33: if (!writer.writeMessage("writeVer", writeVer)) return false; @@ -387,30 +359,6 @@ public Collection pendingVersions() { state++; - case 24: - nearTtls = reader.readMessage("nearTtls"); - - if (!reader.isLastRead()) - return false; - - state++; - - case 25: - nearWritesBytes = reader.readCollection("nearWritesBytes", byte[].class); - - if (!reader.isLastRead()) - return false; - - state++; - - case 26: - onePhaseCommit = reader.readBoolean("onePhaseCommit"); - - if (!reader.isLastRead()) - return false; - - state++; - case 27: pendingVers = reader.readCollection("pendingVers", GridCacheVersion.class); @@ -451,14 +399,6 @@ public Collection pendingVersions() { state++; - case 32: - ttls = reader.readMessage("ttls"); - - if (!reader.isLastRead()) - return false; - - state++; - case 33: writeVer = reader.readMessage("writeVer"); diff --git a/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/distributed/dht/GridDhtTxPrepareFuture.java b/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/distributed/dht/GridDhtTxPrepareFuture.java index 7d75f92b94847..e4e886e7e9861 100644 --- a/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/distributed/dht/GridDhtTxPrepareFuture.java +++ b/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/distributed/dht/GridDhtTxPrepareFuture.java @@ -30,7 +30,6 @@ import org.apache.ignite.internal.util.*; import org.apache.ignite.internal.util.future.*; import org.apache.ignite.internal.util.tostring.*; -import org.apache.ignite.transactions.*; import org.apache.ignite.internal.util.typedef.*; import org.apache.ignite.internal.util.typedef.internal.*; import org.apache.ignite.lang.*; @@ -46,7 +45,6 @@ import static org.apache.ignite.transactions.IgniteTxState.*; import static org.apache.ignite.events.EventType.*; import static org.apache.ignite.internal.managers.communication.GridIoPolicy.*; -import static org.apache.ignite.transactions.IgniteTxState.*; /** * @@ -326,7 +324,7 @@ private void onEntriesLocked() { for (T2, Object[]> t : txEntry.entryProcessors()) { try { - CacheInvokeEntry invokeEntry = new CacheInvokeEntry<>(key, val); + CacheInvokeEntry invokeEntry = new CacheInvokeEntry<>(txEntry.context(), key, val); EntryProcessor processor = t.get1(); @@ -530,11 +528,11 @@ private boolean mapIfLocked() { onComplete(); if (!tx.near()) { - if (tx.markFinalizing(IgniteTxEx.FinalizationStatus.USER_FINISH)) { - IgniteInternalFuture fut = this.err.get() == null ? tx.commitAsync() : tx.rollbackAsync(); + if (tx.markFinalizing(IgniteInternalTx.FinalizationStatus.USER_FINISH)) { + IgniteInternalFuture fut = this.err.get() == null ? tx.commitAsync() : tx.rollbackAsync(); - fut.listenAsync(new CIX1>() { - @Override public void applyx(IgniteInternalFuture gridCacheTxGridFuture) { + fut.listenAsync(new CIX1>() { + @Override public void applyx(IgniteInternalFuture gridCacheTxGridFuture) { try { if (replied.compareAndSet(false, true)) sendPrepareResponse(res); diff --git a/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/distributed/near/GridNearLockRequest.java b/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/distributed/near/GridNearLockRequest.java index 09385255b0948..79b7dfbf06db2 100644 --- a/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/distributed/near/GridNearLockRequest.java +++ b/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/distributed/near/GridNearLockRequest.java @@ -404,12 +404,6 @@ public long accessTtl() { state++; - case 29: - if (!commState.putBoolean(syncCommit)) - return false; - - commState.idx++; - case 30: if (!writer.writeIgniteUuid("miniId", miniId)) return false; diff --git a/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/distributed/near/GridNearTxPrepareFuture.java b/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/distributed/near/GridNearTxPrepareFuture.java index cd4ea349ade25..4dd77bd2cc167 100644 --- a/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/distributed/near/GridNearTxPrepareFuture.java +++ b/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/distributed/near/GridNearTxPrepareFuture.java @@ -26,19 +26,17 @@ import org.apache.ignite.internal.processors.cache.distributed.*; import org.apache.ignite.internal.processors.cache.distributed.dht.colocated.*; import org.apache.ignite.internal.processors.cache.version.*; +import org.apache.ignite.internal.util.*; import org.apache.ignite.lang.*; import org.apache.ignite.transactions.*; -import org.apache.ignite.internal.managers.discovery.*; import org.apache.ignite.internal.processors.cache.distributed.dht.*; import org.apache.ignite.internal.processors.cache.transactions.*; -import org.apache.ignite.internal.processors.cache.version.*; import org.apache.ignite.internal.transactions.*; import org.apache.ignite.internal.util.future.*; import org.apache.ignite.internal.util.lang.*; import org.apache.ignite.internal.util.tostring.*; import org.apache.ignite.internal.util.typedef.*; import org.apache.ignite.internal.util.typedef.internal.*; -import org.apache.ignite.lang.*; import org.jdk8.backport.*; import org.jetbrains.annotations.*; @@ -47,7 +45,6 @@ import java.util.*; import java.util.concurrent.atomic.*; -import static org.apache.ignite.internal.managers.communication.GridIoPolicy.*; import static org.apache.ignite.internal.processors.cache.GridCacheOperation.*; import static org.apache.ignite.transactions.IgniteTxState.*; @@ -626,7 +623,7 @@ private void preparePessimistic() { } else { try { - cctx.io().send(node, req); + cctx.io().send(node, req, tx.ioPolicy()); } catch (IgniteCheckedException e) { // Fail the whole thing. diff --git a/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/transactions/IgniteTxAdapter.java b/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/transactions/IgniteTxAdapter.java index 75838dab62262..5e130eedc02f0 100644 --- a/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/transactions/IgniteTxAdapter.java +++ b/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/transactions/IgniteTxAdapter.java @@ -1832,11 +1832,6 @@ private static class TxShadow implements IgniteInternalTx { return null; } - /** {@inheritDoc} */ - @Override public Collection recoveryWrites() { - return null; - } - /** {@inheritDoc} */ @Override public Collection optimisticLockEntries() { return null; diff --git a/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/transactions/IgniteTxLocalAdapter.java b/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/transactions/IgniteTxLocalAdapter.java index ad3b89056f069..5c8d1ace0b611 100644 --- a/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/transactions/IgniteTxLocalAdapter.java +++ b/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/transactions/IgniteTxLocalAdapter.java @@ -2705,8 +2705,8 @@ else if (cacheCtx.portableEnabled()) { return new GridFinishedFutureEx<>(new GridCacheReturn(), e); } - return commitAsync().chain(new CX1, GridCacheReturn>() { - @Override public GridCacheReturn applyx(IgniteInternalFuture txFut) throws IgniteCheckedException { + return commitAsync().chain(new CX1, GridCacheReturn>() { + @Override public GridCacheReturn applyx(IgniteInternalFuture txFut) throws IgniteCheckedException { txFut.get(); return implicitRes; @@ -2922,8 +2922,8 @@ else if (cacheCtx.portableEnabled()) { // with prepare response, if required. assert loadFut.isDone(); - return commitAsync().chain(new CX1, GridCacheReturn>() { - @Override public GridCacheReturn applyx(IgniteInternalFuture txFut) throws IgniteCheckedException { + return commitAsync().chain(new CX1, GridCacheReturn>() { + @Override public GridCacheReturn applyx(IgniteInternalFuture txFut) throws IgniteCheckedException { txFut.get(); return implicitRes; diff --git a/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/transactions/IgniteTxProxyImpl.java b/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/transactions/IgniteTxProxyImpl.java index 81d5573cb9c60..480ccb45abf74 100644 --- a/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/transactions/IgniteTxProxyImpl.java +++ b/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/transactions/IgniteTxProxyImpl.java @@ -75,7 +75,7 @@ public IgniteTxProxyImpl(IgniteInternalTx tx, GridCacheSharedContext /** * @return Transaction. */ - public IgniteTxEx tx() { + public IgniteInternalTx tx() { return tx; } diff --git a/modules/core/src/test/java/org/apache/ignite/internal/processors/cache/GridCacheAbstractFullApiSelfTest.java b/modules/core/src/test/java/org/apache/ignite/internal/processors/cache/GridCacheAbstractFullApiSelfTest.java index a518074b9825a..6b21114b49ca1 100644 --- a/modules/core/src/test/java/org/apache/ignite/internal/processors/cache/GridCacheAbstractFullApiSelfTest.java +++ b/modules/core/src/test/java/org/apache/ignite/internal/processors/cache/GridCacheAbstractFullApiSelfTest.java @@ -406,11 +406,10 @@ public void testGetAll() throws Exception { // Now do the same checks but within transaction. if (txEnabled()) { - tx = transactions().txStart(); + try (IgniteTx tx0 = transactions().txStart()) { + assert cache.getAll(Collections.emptySet()).isEmpty(); - assert cache.getAll(Collections.emptySet()).isEmpty(); - - map1 = cache.getAll(ImmutableSet.of("key1", "key2", "key9999")); + map1 = cache.getAll(ImmutableSet.of("key1", "key2", "key9999")); info("Retrieved map1: " + map1); @@ -420,7 +419,7 @@ public void testGetAll() throws Exception { assertEquals(2, (int)map1.get("key2")); assertNull(map1.get("key9999")); - map2 = cache.getAll(ImmutableSet.of("key1", "key2", "key9999")); + map2 = cache.getAll(ImmutableSet.of("key1", "key2", "key9999")); info("Retrieved map2: " + map2); @@ -430,11 +429,7 @@ public void testGetAll() throws Exception { assertEquals(2, (int)map2.get("key2")); assertNull(map2.get("key9999")); - tx.commit(); - } - finally { - if (tx != null) - tx.close(); + tx0.commit(); } } } diff --git a/modules/core/src/test/java/org/apache/ignite/internal/processors/cache/distributed/IgniteTxPessimisticOriginatingNodeFailureAbstractSelfTest.java b/modules/core/src/test/java/org/apache/ignite/internal/processors/cache/distributed/IgniteTxPessimisticOriginatingNodeFailureAbstractSelfTest.java index df2c32e14581d..cf18e96c29ea6 100644 --- a/modules/core/src/test/java/org/apache/ignite/internal/processors/cache/distributed/IgniteTxPessimisticOriginatingNodeFailureAbstractSelfTest.java +++ b/modules/core/src/test/java/org/apache/ignite/internal/processors/cache/distributed/IgniteTxPessimisticOriginatingNodeFailureAbstractSelfTest.java @@ -330,7 +330,7 @@ private void checkPrimaryNodeCrash(final boolean commmit) throws Exception { IgniteTxProxyImpl txProxy = (IgniteTxProxyImpl)tx; - IgniteTxEx txEx = txProxy.tx(); + IgniteInternalTx txEx = txProxy.tx(); if (commmit) { txEx.prepare();