From 5496341a7ccca6edb553af6f4ee4e2f8859ce015 Mon Sep 17 00:00:00 2001 From: Maxim Muzafarov Date: Sun, 22 Apr 2018 17:00:01 +0300 Subject: [PATCH 01/12] IGNITE-6538: test 500 times --- .../testsuites/IgniteStandByClusterSuite.java | 53 ++++++++++--------- 1 file changed, 29 insertions(+), 24 deletions(-) diff --git a/modules/core/src/test/java/org/apache/ignite/testsuites/IgniteStandByClusterSuite.java b/modules/core/src/test/java/org/apache/ignite/testsuites/IgniteStandByClusterSuite.java index fd124b72b1796..c43c8e9391373 100644 --- a/modules/core/src/test/java/org/apache/ignite/testsuites/IgniteStandByClusterSuite.java +++ b/modules/core/src/test/java/org/apache/ignite/testsuites/IgniteStandByClusterSuite.java @@ -49,31 +49,36 @@ public class IgniteStandByClusterSuite extends TestSuite { public static TestSuite suite() { TestSuite suite = new TestSuite("Ignite Activate/DeActivate Cluster Test Suite"); - suite.addTestSuite(IgniteClusterActivateDeactivateTest.class); +// suite.addTestSuite(IgniteClusterActivateDeactivateTest.class); +// +// suite.addTestSuite(IgniteStandByClusterTest.class); +// suite.addTestSuite(IgniteStandByClientReconnectTest.class); +// suite.addTestSuite(IgniteStandByClientReconnectToNewClusterTest.class); +// +// suite.addTestSuite(JoinActiveNodeToActiveCluster.class); +// suite.addTestSuite(JoinActiveNodeToInActiveCluster.class); +// suite.addTestSuite(JoinInActiveNodeToActiveCluster.class); +// suite.addTestSuite(JoinInActiveNodeToInActiveCluster.class); +// +// suite.addTestSuite(JoinActiveNodeToActiveClusterWithPersistence.class); +// suite.addTestSuite(JoinActiveNodeToInActiveClusterWithPersistence.class); +// suite.addTestSuite(JoinInActiveNodeToActiveClusterWithPersistence.class); +// suite.addTestSuite(JoinInActiveNodeToInActiveClusterWithPersistence.class); - suite.addTestSuite(IgniteStandByClusterTest.class); - suite.addTestSuite(IgniteStandByClientReconnectTest.class); - suite.addTestSuite(IgniteStandByClientReconnectToNewClusterTest.class); - - suite.addTestSuite(JoinActiveNodeToActiveCluster.class); - suite.addTestSuite(JoinActiveNodeToInActiveCluster.class); - suite.addTestSuite(JoinInActiveNodeToActiveCluster.class); - suite.addTestSuite(JoinInActiveNodeToInActiveCluster.class); - - suite.addTestSuite(JoinActiveNodeToActiveClusterWithPersistence.class); - suite.addTestSuite(JoinActiveNodeToInActiveClusterWithPersistence.class); - suite.addTestSuite(JoinInActiveNodeToActiveClusterWithPersistence.class); - suite.addTestSuite(JoinInActiveNodeToInActiveClusterWithPersistence.class); - - suite.addTestSuite(IgniteChangeGlobalStateTest.class); - suite.addTestSuite(IgniteChangeGlobalStateCacheTest.class); - suite.addTestSuite(IgniteChangeGlobalStateDataStructureTest.class); - suite.addTestSuite(IgniteChangeGlobalStateDataStreamerTest.class); - suite.addTestSuite(IgniteChangeGlobalStateFailOverTest.class); - suite.addTestSuite(IgniteChangeGlobalStateServiceTest.class); - - suite.addTestSuite(CacheBaselineTopologyTest.class); - suite.addTestSuite(IgniteBaselineAffinityTopologyActivationTest.class); + for (int i = 0; i < 500; i ++) { + IgniteChangeGlobalStateTest t = new IgniteChangeGlobalStateTest(); + t.setName("testActivateAfterFailGetLock"); + suite.addTest(t); + } +// suite.addTestSuite(IgniteChangeGlobalStateTest.class); +// suite.addTestSuite(IgniteChangeGlobalStateCacheTest.class); +// suite.addTestSuite(IgniteChangeGlobalStateDataStructureTest.class); +// suite.addTestSuite(IgniteChangeGlobalStateDataStreamerTest.class); +// suite.addTestSuite(IgniteChangeGlobalStateFailOverTest.class); +// suite.addTestSuite(IgniteChangeGlobalStateServiceTest.class); +// +// suite.addTestSuite(CacheBaselineTopologyTest.class); +// suite.addTestSuite(IgniteBaselineAffinityTopologyActivationTest.class); return suite; } From a4e572be30ab55e23190b3c6f331cba88cd2f07a Mon Sep 17 00:00:00 2001 From: Maxim Muzafarov Date: Sun, 22 Apr 2018 19:02:40 +0300 Subject: [PATCH 02/12] IGNITE-6538: test count 250 --- .../org/apache/ignite/testsuites/IgniteStandByClusterSuite.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/modules/core/src/test/java/org/apache/ignite/testsuites/IgniteStandByClusterSuite.java b/modules/core/src/test/java/org/apache/ignite/testsuites/IgniteStandByClusterSuite.java index c43c8e9391373..b1bfe91e9b850 100644 --- a/modules/core/src/test/java/org/apache/ignite/testsuites/IgniteStandByClusterSuite.java +++ b/modules/core/src/test/java/org/apache/ignite/testsuites/IgniteStandByClusterSuite.java @@ -65,7 +65,7 @@ public static TestSuite suite() { // suite.addTestSuite(JoinInActiveNodeToActiveClusterWithPersistence.class); // suite.addTestSuite(JoinInActiveNodeToInActiveClusterWithPersistence.class); - for (int i = 0; i < 500; i ++) { + for (int i = 0; i < 250; i ++) { IgniteChangeGlobalStateTest t = new IgniteChangeGlobalStateTest(); t.setName("testActivateAfterFailGetLock"); suite.addTest(t); From 7c899cb54e17be65cd3f5c5f744bd4e791b31e21 Mon Sep 17 00:00:00 2001 From: Maxim Muzafarov Date: Sun, 22 Apr 2018 21:13:38 +0300 Subject: [PATCH 03/12] IGNITE-6538: test count set 100 --- .../org/apache/ignite/testsuites/IgniteStandByClusterSuite.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/modules/core/src/test/java/org/apache/ignite/testsuites/IgniteStandByClusterSuite.java b/modules/core/src/test/java/org/apache/ignite/testsuites/IgniteStandByClusterSuite.java index b1bfe91e9b850..5b36e32de7a84 100644 --- a/modules/core/src/test/java/org/apache/ignite/testsuites/IgniteStandByClusterSuite.java +++ b/modules/core/src/test/java/org/apache/ignite/testsuites/IgniteStandByClusterSuite.java @@ -65,7 +65,7 @@ public static TestSuite suite() { // suite.addTestSuite(JoinInActiveNodeToActiveClusterWithPersistence.class); // suite.addTestSuite(JoinInActiveNodeToInActiveClusterWithPersistence.class); - for (int i = 0; i < 250; i ++) { + for (int i = 0; i < 100; i ++) { IgniteChangeGlobalStateTest t = new IgniteChangeGlobalStateTest(); t.setName("testActivateAfterFailGetLock"); suite.addTest(t); From dbbfaf8daff5d77882aeca022fd68c763eb5c89e Mon Sep 17 00:00:00 2001 From: Mmuzaf Date: Sun, 22 Apr 2018 23:42:43 +0300 Subject: [PATCH 04/12] ignite-6538: count 50 --- .../org/apache/ignite/testsuites/IgniteStandByClusterSuite.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/modules/core/src/test/java/org/apache/ignite/testsuites/IgniteStandByClusterSuite.java b/modules/core/src/test/java/org/apache/ignite/testsuites/IgniteStandByClusterSuite.java index 5b36e32de7a84..3d8880cd5521a 100644 --- a/modules/core/src/test/java/org/apache/ignite/testsuites/IgniteStandByClusterSuite.java +++ b/modules/core/src/test/java/org/apache/ignite/testsuites/IgniteStandByClusterSuite.java @@ -65,7 +65,7 @@ public static TestSuite suite() { // suite.addTestSuite(JoinInActiveNodeToActiveClusterWithPersistence.class); // suite.addTestSuite(JoinInActiveNodeToInActiveClusterWithPersistence.class); - for (int i = 0; i < 100; i ++) { + for (int i = 0; i < 50; i ++) { IgniteChangeGlobalStateTest t = new IgniteChangeGlobalStateTest(); t.setName("testActivateAfterFailGetLock"); suite.addTest(t); From 0e20eed3d9eb8c77e22f5d094611a1f543ff7a0e Mon Sep 17 00:00:00 2001 From: Maxim Muzafarov Date: Mon, 23 Apr 2018 10:44:54 +0300 Subject: [PATCH 05/12] IGNITE-6538: remove deprecated --- .../IgniteChangeGlobalStateTest.java | 44 +++++-------------- .../testsuites/IgniteStandByClusterSuite.java | 2 +- 2 files changed, 12 insertions(+), 34 deletions(-) diff --git a/modules/core/src/test/java/org/apache/ignite/internal/processors/cache/persistence/standbycluster/IgniteChangeGlobalStateTest.java b/modules/core/src/test/java/org/apache/ignite/internal/processors/cache/persistence/standbycluster/IgniteChangeGlobalStateTest.java index cbf0ec9256b2e..5bbfb5df40ae1 100644 --- a/modules/core/src/test/java/org/apache/ignite/internal/processors/cache/persistence/standbycluster/IgniteChangeGlobalStateTest.java +++ b/modules/core/src/test/java/org/apache/ignite/internal/processors/cache/persistence/standbycluster/IgniteChangeGlobalStateTest.java @@ -545,36 +545,25 @@ public void testFailGetLock() throws Exception { public void testActivateAfterFailGetLock() throws Exception { Ignite ig1P = primary(0); Ignite ig2P = primary(1); - Ignite ig3P = primary(2); Ignite ig1CP = primaryClient(0); - Ignite ig2CP = primaryClient(1); - Ignite ig3CP = primaryClient(2); Ignite ig1B = backUp(0); - Ignite ig2B = backUp(1); - Ignite ig3B = backUp(2); Ignite ig1CB = backUpClient(0); Ignite ig2CB = backUpClient(1); Ignite ig3CB = backUpClient(2); - assertTrue(ig1P.active()); - assertTrue(ig2P.active()); - assertTrue(ig3P.active()); + assertTrue(ig1P.cluster().active()); - assertTrue(!ig1B.active()); - assertTrue(!ig2B.active()); - assertTrue(!ig3B.active()); + assertTrue(!ig1B.cluster().active()); - assertTrue(!ig1CB.active()); - assertTrue(!ig2CB.active()); - assertTrue(!ig3CB.active()); + assertTrue(!ig1CB.cluster().active()); stopPrimary(0); try { - ig3CB.active(true); + ig3CB.cluster().active(true); fail("Activation should fail"); } @@ -585,32 +574,21 @@ public void testActivateAfterFailGetLock() throws Exception { assertTrue(t.getMessage().contains("can't get lock during")); } - assertTrue(!ig1B.active()); - assertTrue(!ig2B.active()); - assertTrue(!ig3B.active()); + assertTrue(!ig1B.cluster().active()); - assertTrue(!ig1CB.active()); - assertTrue(!ig2CB.active()); - assertTrue(!ig3CB.active()); + assertTrue(!ig1CB.cluster().active()); - assertTrue(ig2P.active()); - assertTrue(ig3P.active()); + assertTrue(ig2P.cluster().active()); - assertTrue(ig1CP.active()); - assertTrue(ig2CP.active()); - assertTrue(ig3CP.active()); + assertTrue(ig1CP.cluster().active()); stopAllPrimary(); - ig2CB.active(true); + ig2CB.cluster().active(true); - assertTrue(ig1B.active()); - assertTrue(ig2B.active()); - assertTrue(ig3B.active()); + assertTrue(ig1B.cluster().active()); - assertTrue(ig1CB.active()); - assertTrue(ig2CB.active()); - assertTrue(ig3CB.active()); + assertTrue(ig1CB.cluster().active()); } /** diff --git a/modules/core/src/test/java/org/apache/ignite/testsuites/IgniteStandByClusterSuite.java b/modules/core/src/test/java/org/apache/ignite/testsuites/IgniteStandByClusterSuite.java index 3d8880cd5521a..5b36e32de7a84 100644 --- a/modules/core/src/test/java/org/apache/ignite/testsuites/IgniteStandByClusterSuite.java +++ b/modules/core/src/test/java/org/apache/ignite/testsuites/IgniteStandByClusterSuite.java @@ -65,7 +65,7 @@ public static TestSuite suite() { // suite.addTestSuite(JoinInActiveNodeToActiveClusterWithPersistence.class); // suite.addTestSuite(JoinInActiveNodeToInActiveClusterWithPersistence.class); - for (int i = 0; i < 50; i ++) { + for (int i = 0; i < 100; i ++) { IgniteChangeGlobalStateTest t = new IgniteChangeGlobalStateTest(); t.setName("testActivateAfterFailGetLock"); suite.addTest(t); From 43ea4b5130ab0c9caec4b23c61a443c3429eb220 Mon Sep 17 00:00:00 2001 From: Maxim Muzafarov Date: Mon, 23 Apr 2018 10:53:45 +0300 Subject: [PATCH 06/12] IGNITE-6538: set lock wait time 1 sec --- .../standbycluster/IgniteChangeGlobalStateAbstractTest.java | 1 + 1 file changed, 1 insertion(+) diff --git a/modules/core/src/test/java/org/apache/ignite/internal/processors/cache/persistence/standbycluster/IgniteChangeGlobalStateAbstractTest.java b/modules/core/src/test/java/org/apache/ignite/internal/processors/cache/persistence/standbycluster/IgniteChangeGlobalStateAbstractTest.java index c30c8e90f65fd..96c2975db0502 100644 --- a/modules/core/src/test/java/org/apache/ignite/internal/processors/cache/persistence/standbycluster/IgniteChangeGlobalStateAbstractTest.java +++ b/modules/core/src/test/java/org/apache/ignite/internal/processors/cache/persistence/standbycluster/IgniteChangeGlobalStateAbstractTest.java @@ -351,6 +351,7 @@ private void stopAll(String suffix) { pCfg.setConcurrencyLevel(64); pCfg.setWalMode(WALMode.LOG_ONLY); + pCfg.setLockWaitTime(1_000); pCfg.setDefaultDataRegionConfiguration( new DataRegionConfiguration().setMaxSize(200 * 1024 * 1024).setPersistenceEnabled(true)); From f596a0bef7edaeba7efc597e0011c8aa8ed3ef58 Mon Sep 17 00:00:00 2001 From: Maxim Muzafarov Date: Thu, 26 Apr 2018 15:18:36 +0300 Subject: [PATCH 07/12] IGNITE-6538: rerun test suite --- .../apache/ignite/testframework/junits/GridAbstractTest.java | 3 ++- .../apache/ignite/testsuites/IgniteStandByClusterSuite.java | 4 ++-- 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/modules/core/src/test/java/org/apache/ignite/testframework/junits/GridAbstractTest.java b/modules/core/src/test/java/org/apache/ignite/testframework/junits/GridAbstractTest.java index f5784ebcdccd2..fc07a45e9e53b 100755 --- a/modules/core/src/test/java/org/apache/ignite/testframework/junits/GridAbstractTest.java +++ b/modules/core/src/test/java/org/apache/ignite/testframework/junits/GridAbstractTest.java @@ -1709,7 +1709,8 @@ protected static ClassLoader getExternalClassLoader() { stopAllGrids(false); // Remove counters. - tests.remove(getClass()); + //tests.remove(getClass()); + tests.get(getClass()).reset(); // Remove resources cached in static, if any. GridClassLoaderCache.clear(); diff --git a/modules/core/src/test/java/org/apache/ignite/testsuites/IgniteStandByClusterSuite.java b/modules/core/src/test/java/org/apache/ignite/testsuites/IgniteStandByClusterSuite.java index 5b36e32de7a84..a15b9c8cd2c8b 100644 --- a/modules/core/src/test/java/org/apache/ignite/testsuites/IgniteStandByClusterSuite.java +++ b/modules/core/src/test/java/org/apache/ignite/testsuites/IgniteStandByClusterSuite.java @@ -65,10 +65,10 @@ public static TestSuite suite() { // suite.addTestSuite(JoinInActiveNodeToActiveClusterWithPersistence.class); // suite.addTestSuite(JoinInActiveNodeToInActiveClusterWithPersistence.class); - for (int i = 0; i < 100; i ++) { + for (int i = 0; i < 100; i++) { IgniteChangeGlobalStateTest t = new IgniteChangeGlobalStateTest(); t.setName("testActivateAfterFailGetLock"); - suite.addTest(t); + suite.addTest(t); } // suite.addTestSuite(IgniteChangeGlobalStateTest.class); // suite.addTestSuite(IgniteChangeGlobalStateCacheTest.class); From 933dc9076cb6c31d62e0b1cd23524a0aa4c67c8a Mon Sep 17 00:00:00 2001 From: Maxim Muzafarov Date: Mon, 7 May 2018 19:36:42 +0300 Subject: [PATCH 08/12] IGNITE-6538: small dataregion --- .../standbycluster/IgniteChangeGlobalStateAbstractTest.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/modules/core/src/test/java/org/apache/ignite/internal/processors/cache/persistence/standbycluster/IgniteChangeGlobalStateAbstractTest.java b/modules/core/src/test/java/org/apache/ignite/internal/processors/cache/persistence/standbycluster/IgniteChangeGlobalStateAbstractTest.java index 96c2975db0502..0451f8419dab2 100644 --- a/modules/core/src/test/java/org/apache/ignite/internal/processors/cache/persistence/standbycluster/IgniteChangeGlobalStateAbstractTest.java +++ b/modules/core/src/test/java/org/apache/ignite/internal/processors/cache/persistence/standbycluster/IgniteChangeGlobalStateAbstractTest.java @@ -354,7 +354,7 @@ private void stopAll(String suffix) { pCfg.setLockWaitTime(1_000); pCfg.setDefaultDataRegionConfiguration( - new DataRegionConfiguration().setMaxSize(200 * 1024 * 1024).setPersistenceEnabled(true)); + new DataRegionConfiguration().setMaxSize(1024 * 1024).setPersistenceEnabled(true)); cfg.setDataStorageConfiguration(pCfg); From 3670094fcca66c908597a85e9237bb587202c1e9 Mon Sep 17 00:00:00 2001 From: Maxim Muzafarov Date: Mon, 7 May 2018 20:36:35 +0300 Subject: [PATCH 09/12] IGNITE-6538: 10 Mb dataregion --- .../standbycluster/IgniteChangeGlobalStateAbstractTest.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/modules/core/src/test/java/org/apache/ignite/internal/processors/cache/persistence/standbycluster/IgniteChangeGlobalStateAbstractTest.java b/modules/core/src/test/java/org/apache/ignite/internal/processors/cache/persistence/standbycluster/IgniteChangeGlobalStateAbstractTest.java index 0451f8419dab2..6a0d2a3fcd623 100644 --- a/modules/core/src/test/java/org/apache/ignite/internal/processors/cache/persistence/standbycluster/IgniteChangeGlobalStateAbstractTest.java +++ b/modules/core/src/test/java/org/apache/ignite/internal/processors/cache/persistence/standbycluster/IgniteChangeGlobalStateAbstractTest.java @@ -354,7 +354,7 @@ private void stopAll(String suffix) { pCfg.setLockWaitTime(1_000); pCfg.setDefaultDataRegionConfiguration( - new DataRegionConfiguration().setMaxSize(1024 * 1024).setPersistenceEnabled(true)); + new DataRegionConfiguration().setMaxSize(10 * 1024 * 1024).setPersistenceEnabled(true)); cfg.setDataStorageConfiguration(pCfg); From d24299fb15f6b16ddfa98af44520144a1144b43f Mon Sep 17 00:00:00 2001 From: Maxim Muzafarov Date: Mon, 7 May 2018 20:59:55 +0300 Subject: [PATCH 10/12] IGNITE-6538: 500 runs --- .../org/apache/ignite/testsuites/IgniteStandByClusterSuite.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/modules/core/src/test/java/org/apache/ignite/testsuites/IgniteStandByClusterSuite.java b/modules/core/src/test/java/org/apache/ignite/testsuites/IgniteStandByClusterSuite.java index a15b9c8cd2c8b..aa4377f07feef 100644 --- a/modules/core/src/test/java/org/apache/ignite/testsuites/IgniteStandByClusterSuite.java +++ b/modules/core/src/test/java/org/apache/ignite/testsuites/IgniteStandByClusterSuite.java @@ -65,7 +65,7 @@ public static TestSuite suite() { // suite.addTestSuite(JoinInActiveNodeToActiveClusterWithPersistence.class); // suite.addTestSuite(JoinInActiveNodeToInActiveClusterWithPersistence.class); - for (int i = 0; i < 100; i++) { + for (int i = 0; i < 500; i++) { IgniteChangeGlobalStateTest t = new IgniteChangeGlobalStateTest(); t.setName("testActivateAfterFailGetLock"); suite.addTest(t); From 38c0b2e3d26f3190f6d981ffa5f9a5862610f795 Mon Sep 17 00:00:00 2001 From: Maxim Muzafarov Date: Fri, 11 May 2018 21:23:28 +0300 Subject: [PATCH 11/12] IGNITE-8469: release memory in case initialization multi times --- .../internal/mem/unsafe/UnsafeMemoryProvider.java | 12 ++++++++++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/modules/core/src/main/java/org/apache/ignite/internal/mem/unsafe/UnsafeMemoryProvider.java b/modules/core/src/main/java/org/apache/ignite/internal/mem/unsafe/UnsafeMemoryProvider.java index 276e10e1783c9..77321dba1f5a5 100644 --- a/modules/core/src/main/java/org/apache/ignite/internal/mem/unsafe/UnsafeMemoryProvider.java +++ b/modules/core/src/main/java/org/apache/ignite/internal/mem/unsafe/UnsafeMemoryProvider.java @@ -52,12 +52,21 @@ public UnsafeMemoryProvider(IgniteLogger log) { @Override public void initialize(long[] sizes) { this.sizes = sizes; + freeRegions(); + regions = new ArrayList<>(); } /** {@inheritDoc} */ @Override public void shutdown() { - if (regions != null) { + freeRegions(); + } + + /** + * Relese memory allocated earlier. + */ + private void freeRegions() { + if (regions != null) for (Iterator it = regions.iterator(); it.hasNext(); ) { DirectMemoryRegion chunk = it.next(); @@ -66,7 +75,6 @@ public UnsafeMemoryProvider(IgniteLogger log) { // Safety. it.remove(); } - } } /** {@inheritDoc} */ From cf26d4d333fa9fe05f4daf586146e041abe2f29b Mon Sep 17 00:00:00 2001 From: Maxim Muzafarov Date: Mon, 14 May 2018 15:30:32 +0300 Subject: [PATCH 12/12] IGNITE-6538: run 150 times --- .../org/apache/ignite/testsuites/IgniteStandByClusterSuite.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/modules/core/src/test/java/org/apache/ignite/testsuites/IgniteStandByClusterSuite.java b/modules/core/src/test/java/org/apache/ignite/testsuites/IgniteStandByClusterSuite.java index aa4377f07feef..32413bdb0305c 100644 --- a/modules/core/src/test/java/org/apache/ignite/testsuites/IgniteStandByClusterSuite.java +++ b/modules/core/src/test/java/org/apache/ignite/testsuites/IgniteStandByClusterSuite.java @@ -65,7 +65,7 @@ public static TestSuite suite() { // suite.addTestSuite(JoinInActiveNodeToActiveClusterWithPersistence.class); // suite.addTestSuite(JoinInActiveNodeToInActiveClusterWithPersistence.class); - for (int i = 0; i < 500; i++) { + for (int i = 0; i < 150; i++) { IgniteChangeGlobalStateTest t = new IgniteChangeGlobalStateTest(); t.setName("testActivateAfterFailGetLock"); suite.addTest(t);