Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IGNITE-12602 Calcite integration. JDBC Thin driver support. #7377

Closed
wants to merge 3 commits into from

Conversation

gvvinblade
Copy link
Contributor

No description provided.


/** {@inheritDoc} */
@Override public void send(UUID nodeId, CalciteMessage msg) {
@Override public void send(UUID nodeId, CalciteMessage msg) throws IgniteCheckedException {
if (localNodeId().equals(nodeId))
onMessage(nodeId, msg, true);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we get into some troubles (races?) here because of handling the message in the current thread instead of submitting it into the specified pool?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We submit it to another thread (async=true)

return experimentalQueryEngine.query(QueryContext.of(qry, cancel), qry.getSchema(), qry.getSql(), qry.getArgs());
}
catch (IgniteSQLException e) {
U.warn(log, "Failed to execute SQL query using experimental engine. [qry=" + qry + ']', e);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should not write this warning to log for DDL/DML queries.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure, actually here we highlight an issue - it's been handled but still an issue and a user should be aware on it, because this mean you were wrong setting "useExperimentalEngine" flag to true.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants