New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AIRFLOW-1692] Changed test_views filename #2673

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
5 participants
@NielsZeilemaker
Contributor

NielsZeilemaker commented Oct 7, 2017

to support windows

Dear Airflow maintainers,

Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below!

JIRA

Description

  • Here are some details about my PR, including screenshots of any UI changes:
    The test_views unit-test used a file which contained colons. Such a file is not supported on windows.

Tests

  • My PR adds the following unit tests OR does not need testing for this extremely good reason:

Commits

  • My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"
@codecov-io

This comment has been minimized.

Show comment
Hide comment
@codecov-io

codecov-io Oct 7, 2017

Codecov Report

Merging #2673 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2673   +/-   ##
=======================================
  Coverage   71.68%   71.68%           
=======================================
  Files         154      154           
  Lines       11808    11808           
=======================================
  Hits         8465     8465           
  Misses       3343     3343
Impacted Files Coverage Δ
airflow/models.py 87.09% <0%> (-0.05%) ⬇️
airflow/executors/dask_executor.py 81.39% <0%> (+2.32%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2078dac...a35a4fd. Read the comment docs.

codecov-io commented Oct 7, 2017

Codecov Report

Merging #2673 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2673   +/-   ##
=======================================
  Coverage   71.68%   71.68%           
=======================================
  Files         154      154           
  Lines       11808    11808           
=======================================
  Hits         8465     8465           
  Misses       3343     3343
Impacted Files Coverage Δ
airflow/models.py 87.09% <0%> (-0.05%) ⬇️
airflow/executors/dask_executor.py 81.39% <0%> (+2.32%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2078dac...a35a4fd. Read the comment docs.

@NielsZeilemaker NielsZeilemaker referenced this pull request Oct 7, 2017

Closed

[AIRFLOW-1520] Boto3 S3Hook, S3Log #2532

4 of 4 tasks complete
@Fokko

This comment has been minimized.

Show comment
Hide comment
@Fokko

Fokko Oct 10, 2017

Contributor

+1 Let the tests pass on Windows

Contributor

Fokko commented Oct 10, 2017

+1 Let the tests pass on Windows

@NielsZeilemaker

This comment has been minimized.

Show comment
Hide comment
@NielsZeilemaker

NielsZeilemaker Oct 10, 2017

Contributor

Not really, as the unit-tests don't run on windows. But, it will allow me to do a git checkout on windows.

Contributor

NielsZeilemaker commented Oct 10, 2017

Not really, as the unit-tests don't run on windows. But, it will allow me to do a git checkout on windows.

@andyxhadji

This comment has been minimized.

Show comment
Hide comment
@andyxhadji

andyxhadji Oct 11, 2017

Contributor

LGTM - Can we merge this? It'll unblock #2532!

Contributor

andyxhadji commented Oct 11, 2017

LGTM - Can we merge this? It'll unblock #2532!

@NielsZeilemaker

This comment has been minimized.

Show comment
Hide comment
@NielsZeilemaker

NielsZeilemaker Oct 16, 2017

Contributor

@bolkedebruin would it be possible to merge this pull request?

Contributor

NielsZeilemaker commented Oct 16, 2017

@bolkedebruin would it be possible to merge this pull request?

asfgit pushed a commit that referenced this pull request Oct 18, 2017

[AIRFLOW-1692] Change test_views filename to support Windows
Closes #2673 from NielsZeilemaker/AIRFLOW-1692

(cherry picked from commit 2da4856)
Signed-off-by: Bolke de Bruin <bolke@xs4all.nl>

@asfgit asfgit closed this in 2da4856 Oct 18, 2017

@bolkedebruin

This comment has been minimized.

Show comment
Hide comment
@bolkedebruin

bolkedebruin Oct 18, 2017

Contributor

Done sorry for the delay.

Contributor

bolkedebruin commented Oct 18, 2017

Done sorry for the delay.

jfantom added a commit to jfantom/incubator-airflow that referenced this pull request Oct 18, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment