New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AIRFLOW-2553] Add webserver.pid to .gitignore #3451

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
1 participant
@r39132
Contributor

r39132 commented Jun 2, 2018

Make sure you have checked all steps below.

JIRA

  • My PR addresses the following Airflow JIRA issues and references them in the PR title. For example, "[AIRFLOW-XXX] My Airflow PR"

Description

  • Here are some details about my PR, including screenshots of any UI changes:

Tests

  • My PR adds the following unit tests OR does not need testing for this extremely good reason: Not needed as this is a .git config change

Commits

  • My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

Documentation

  • In case of new functionality, my PR adds documentation that describes how to use it.
    • When adding new operators/hooks/sensors, the autoclass documentation generation needs to be added.

Code Quality

  • Passes git diff upstream/master -u -- "*.py" | flake8 --diff

@asfgit asfgit closed this in 2ed6188 Jun 2, 2018

afernandez pushed a commit to afernandez/incubator-airflow that referenced this pull request Jun 26, 2018

afernandez pushed a commit to afernandez/incubator-airflow that referenced this pull request Jun 30, 2018

@r39132 r39132 deleted the r39132:update_gitignore branch Jul 18, 2018

@r39132 r39132 restored the r39132:update_gitignore branch Jul 18, 2018

@r39132 r39132 deleted the r39132:update_gitignore branch Jul 18, 2018

@r39132 r39132 restored the r39132:update_gitignore branch Jul 18, 2018

@r39132 r39132 deleted the r39132:update_gitignore branch Sep 6, 2018

dlebech added a commit to trustpilot/incubator-airflow that referenced this pull request Sep 11, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment