Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AIRFLOW-2864] Fix docstrings for SubDagOperator #3712

Merged
merged 1 commit into from Aug 7, 2018

Conversation

kaxil
Copy link
Member

@kaxil kaxil commented Aug 7, 2018

Make sure you have checked all steps below.

Jira

Description

  • Here are some details about my PR, including screenshots of any UI changes:
    The docstrings are currently in the __init__ method, due to which they are not automatically shown in the Sphinx documentation.

image

Tests

  • My PR adds the following unit tests OR does not need testing for this extremely good reason:
    N/a - not needed. Just doc change

Commits

  • My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters (not including Jira issue reference)
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

Documentation

  • In case of new functionality, my PR adds documentation that describes how to use it.
    • When adding new operators/hooks/sensors, the autoclass documentation generation needs to be added.

Code Quality

  • Passes git diff upstream/master -u -- "*.py" | flake8 --diff

The docstrings are currently in the `__init__` method, due to which they are not automatically shown in the Sphinx documentation.
@kaxil kaxil requested a review from feng-tao August 7, 2018 13:59
:param executor: the executor for this subdag. Default to use SequentialExecutor.
Please find AIRFLOW-74 for more details.
:type executor: airflow.executors.
"""
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Curious. I thought sphinx looked here for class-level docs. I guess not!

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kaxil kaxil merged commit b74a712 into apache:master Aug 7, 2018
@kaxil kaxil deleted the fix-subdag-docstrings branch August 7, 2018 14:15
@codecov-io
Copy link

codecov-io commented Aug 7, 2018

Codecov Report

Merging #3712 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3712   +/-   ##
=======================================
  Coverage   77.56%   77.56%           
=======================================
  Files         204      204           
  Lines       15766    15766           
=======================================
  Hits        12229    12229           
  Misses       3537     3537
Impacted Files Coverage Δ
airflow/operators/subdag_operator.py 90.32% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 27b436e...1f8e2f1. Read the comment docs.

lxneng pushed a commit to lxneng/incubator-airflow that referenced this pull request Aug 10, 2018
The docstrings are currently in the `__init__` method, due to which they are not automatically shown in the Sphinx documentation.
aliceabe pushed a commit to aliceabe/incubator-airflow that referenced this pull request Jan 3, 2019
The docstrings are currently in the `__init__` method, due to which they are not automatically shown in the Sphinx documentation.
ashb pushed a commit that referenced this pull request Mar 26, 2019
The docstrings are currently in the `__init__` method, due to which they are not automatically shown in the Sphinx documentation.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants