From 6fd0782fbb74d65ee7a535f721804a38badfa1d9 Mon Sep 17 00:00:00 2001 From: Dan Halperin Date: Thu, 1 Dec 2016 11:21:30 -0800 Subject: [PATCH] DataflowRunner: reject job submission when the version has not been properly set --- .../org/apache/beam/runners/dataflow/DataflowRunner.java | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/runners/google-cloud-dataflow-java/src/main/java/org/apache/beam/runners/dataflow/DataflowRunner.java b/runners/google-cloud-dataflow-java/src/main/java/org/apache/beam/runners/dataflow/DataflowRunner.java index 0099856441550..e1b64d4b78e04 100644 --- a/runners/google-cloud-dataflow-java/src/main/java/org/apache/beam/runners/dataflow/DataflowRunner.java +++ b/runners/google-cloud-dataflow-java/src/main/java/org/apache/beam/runners/dataflow/DataflowRunner.java @@ -513,10 +513,14 @@ public DataflowPipelineJob run(Pipeline pipeline) { Job newJob = jobSpecification.getJob(); newJob.setClientRequestId(requestId); - String version = ReleaseInfo.getReleaseInfo().getVersion(); + ReleaseInfo releaseInfo = ReleaseInfo.getReleaseInfo(); + String version = releaseInfo.getVersion(); + checkState( + !version.equals("${pom.version}"), + "Unable to submit a job to the Dataflow service with unset version ${pom.version}"); System.out.println("Dataflow SDK version: " + version); - newJob.getEnvironment().setUserAgent(ReleaseInfo.getReleaseInfo()); + newJob.getEnvironment().setUserAgent(releaseInfo); // The Dataflow Service may write to the temporary directory directly, so // must be verified. if (!isNullOrEmpty(options.getGcpTempLocation())) {