From d8943fd552071d95e7650770cbed77e2eee6eab8 Mon Sep 17 00:00:00 2001 From: Lucas Amorim Date: Mon, 4 Jul 2016 16:26:24 -0700 Subject: [PATCH] [BEAM-397] - Fixes Format string - it should use %n instead of \n It fixes format string on Coder.NonDeterministicExeption.getMessage. For more information: https://issues.apache.org/jira/browse/BEAM-397 --- .../build-tools/src/main/resources/beam/findbugs-filter.xml | 6 ------ .../src/main/java/org/apache/beam/sdk/coders/Coder.java | 4 ++-- 2 files changed, 2 insertions(+), 8 deletions(-) diff --git a/sdks/java/build-tools/src/main/resources/beam/findbugs-filter.xml b/sdks/java/build-tools/src/main/resources/beam/findbugs-filter.xml index 3f1583563fcb..93040f5560fa 100644 --- a/sdks/java/build-tools/src/main/resources/beam/findbugs-filter.xml +++ b/sdks/java/build-tools/src/main/resources/beam/findbugs-filter.xml @@ -68,12 +68,6 @@ - - - - - - diff --git a/sdks/java/core/src/main/java/org/apache/beam/sdk/coders/Coder.java b/sdks/java/core/src/main/java/org/apache/beam/sdk/coders/Coder.java index d2666f060b3f..74af59e8a34f 100644 --- a/sdks/java/core/src/main/java/org/apache/beam/sdk/coders/Coder.java +++ b/sdks/java/core/src/main/java/org/apache/beam/sdk/coders/Coder.java @@ -293,8 +293,8 @@ public Iterable getReasons() { @Override public String getMessage() { - return String.format("%s is not deterministic because:\n %s", - coder, Joiner.on("\n ").join(reasons)); + return String.format("%s is not deterministic because:%n %s", + coder, Joiner.on("%n ").join(reasons)); } } }