Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tidy up Webhook APIs #7550

Merged
merged 3 commits into from
May 31, 2024
Merged

Tidy up Webhook APIs #7550

merged 3 commits into from
May 31, 2024

Conversation

klesh
Copy link
Contributor

@klesh klesh commented May 31, 2024

Summary

Fine-grain #7545 according to the discussion with @Startrekzky

  1. Change field names of Webhook Issues API request body to camelCase
  2. Webhook Deployment API:
    • Removed pipelineId and use id as the replacement
    • Renamed createdTime to createdDate, startedTime to startedDate and endedTime to finishedDate to align with the DB schema

@klesh klesh requested a review from Startrekzky May 31, 2024 03:16
@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label May 31, 2024
@klesh klesh changed the title Kw webhook deployment no2 Tidy up Webhook APIs May 31, 2024
@dosubot dosubot bot added component/plugins This issue or PR relates to plugins pr-type/refactor This PR refactors existing features labels May 31, 2024
Startrekzky
Startrekzky approved these changes May 31, 2024
View reviewed changes
Copy link
Contributor

@Startrekzky Startrekzky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label May 31, 2024
@klesh klesh merged commit 35f814e into main May 31, 2024
15 checks passed
@klesh klesh deleted the kw-webhook-deployment-no2 branch May 31, 2024 03:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Startrekzky Startrekzky Startrekzky approved these changes

Assignees
No one assigned
Labels
breaking-change component/plugins This issue or PR relates to plugins lgtm This PR has been approved by a maintainer pr-type/refactor This PR refactors existing features size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@klesh @Startrekzky